Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix flaky TestHnswByteVectorGraph.testSortedAndUnsortedIndicesReturnSameResults test (#12110)

This commit is contained in:
Benjamin Trent 2023-01-25 04:47:20 -05:00 committed by GitHub
parent 5a51ce1d5d
commit d1fa52e62f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lucene/core/src/test/org/apache/lucene/util/hnsw/HnswGraphTestCase.java
View File

@ -215,26 +215,32 @@ abstract class HnswGraphTestCase<T> extends LuceneTestCase {
// ask to explore a lot of candidates to ensure the same returned hits, // ask to explore a lot of candidates to ensure the same returned hits,
// as graphs of 2 indices are organized differently // as graphs of 2 indices are organized differently
Query query = knnQuery("vector", randomVector(dim), 50); Query query = knnQuery("vector", randomVector(dim), 50);
List<String> ids1 = new ArrayList<>(); int searchSize = 5;
List<Integer> docs1 = new ArrayList<>(); List<String> ids1 = new ArrayList<>(searchSize);
List<String> ids2 = new ArrayList<>(); List<Integer> docs1 = new ArrayList<>(searchSize);
List<Integer> docs2 = new ArrayList<>(); List<String> ids2 = new ArrayList<>(searchSize);
List<Integer> docs2 = new ArrayList<>(searchSize);
TopDocs topDocs = searcher.search(query, 5); // Check if a duplicate score exists in n+1, if so, this test is invalid
// Else, continue to fail on ID equality as this test failed
TopDocs topDocs = searcher.search(query, searchSize + 1);
float lastScore = -1; float lastScore = -1;
StoredFields storedFields = reader.storedFields(); StoredFields storedFields = reader.storedFields();
for (ScoreDoc scoreDoc : topDocs.scoreDocs) { for (int j = 0; j < searchSize + 1; j++) {
ScoreDoc scoreDoc = topDocs.scoreDocs[j];
if (scoreDoc.score == lastScore) { if (scoreDoc.score == lastScore) {
// if we have repeated score this test is invalid // if we have repeated score this test is invalid
continue OUTER; continue OUTER;
} else { } else {
lastScore = scoreDoc.score; lastScore = scoreDoc.score;
} }
if (j < searchSize) {
Document doc = storedFields.document(scoreDoc.doc, Set.of("id")); Document doc = storedFields.document(scoreDoc.doc, Set.of("id"));
ids1.add(doc.get("id")); ids1.add(doc.get("id"));
docs1.add(scoreDoc.doc); docs1.add(scoreDoc.doc);
} }
TopDocs topDocs2 = searcher2.search(query, 5); }
TopDocs topDocs2 = searcher2.search(query, searchSize);
StoredFields storedFields2 = reader2.storedFields(); StoredFields storedFields2 = reader2.storedFields();
for (ScoreDoc scoreDoc : topDocs2.scoreDocs) { for (ScoreDoc scoreDoc : topDocs2.scoreDocs) {
Document doc = storedFields2.document(scoreDoc.doc, Set.of("id")); Document doc = storedFields2.document(scoreDoc.doc, Set.of("id"));