Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-3478: use a relative rather than abs score delta for score vs explain comparisons 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1178406 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Muir 2011-10-03 13:12:00 +00:00
parent 52e8d40c2f
commit d3b2ff9af2
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lucene/src/test-framework/org/apache/lucene/search/CheckHits.java
View File

@ -34,9 +34,9 @@ public class CheckHits {
/** /**
* Some explains methods calculate their values though a slightly * Some explains methods calculate their values though a slightly
* different order of operations from the actual scoring method ... * different order of operations from the actual scoring method ...
* this allows for a small amount of variation * this allows for a small amount of relative variation
*/ */
public static float EXPLAIN_SCORE_TOLERANCE_DELTA = 0.02f; public static float EXPLAIN_SCORE_TOLERANCE_DELTA = 0.001f;
/** /**
* Tests that all documents up to maxDoc which are *not* in the * Tests that all documents up to maxDoc which are *not* in the
@ -305,6 +305,10 @@ public class CheckHits {
} }
private static float explainToleranceDelta(float f1, float f2) {
return Math.max(f1, f2) * EXPLAIN_SCORE_TOLERANCE_DELTA;
}
/** /**
* Assert that an explanation has the expected score, and optionally that its * Assert that an explanation has the expected score, and optionally that its
* sub-details max/sum/factor match to that score. * sub-details max/sum/factor match to that score.
@ -323,7 +327,7 @@ public class CheckHits {
float value = expl.getValue(); float value = expl.getValue();
Assert.assertEquals(q+": score(doc="+doc+")="+score+ Assert.assertEquals(q+": score(doc="+doc+")="+score+
" != explanationScore="+value+" Explanation: "+expl, " != explanationScore="+value+" Explanation: "+expl,
score,value,EXPLAIN_SCORE_TOLERANCE_DELTA); score,value,explainToleranceDelta(score, value));
if (!deep) return; if (!deep) return;
@ -393,7 +397,7 @@ public class CheckHits {
} }
Assert.assertEquals(q+": actual subDetails combined=="+combined+ Assert.assertEquals(q+": actual subDetails combined=="+combined+
" != value="+value+" Explanation: "+expl, " != value="+value+" Explanation: "+expl,
combined,value,EXPLAIN_SCORE_TOLERANCE_DELTA); combined,value,explainToleranceDelta(combined, value));
} }
} }
} }