From d6461eab0b942057c4c969d758898f9c13fcd387 Mon Sep 17 00:00:00 2001 From: Robert Muir Date: Thu, 21 Apr 2022 08:30:10 -0400 Subject: [PATCH] improve spotless error to suggest running 'gradlew tidy' (#817) The current error isn't helpful as it suggests a per-module command. If the user has modified multiple modules, they will be running gradle commands to try to fix each one of them, when it would be easier to just run 'gradlew tidy' a single time and fix everything. --- gradle/validation/spotless.gradle | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gradle/validation/spotless.gradle b/gradle/validation/spotless.gradle index 372bcf2f9e7..860c0ca9b43 100644 --- a/gradle/validation/spotless.gradle +++ b/gradle/validation/spotless.gradle @@ -111,3 +111,9 @@ configure(project(":lucene").subprojects) { prj -> v.dependsOn ":checkJdkInternalsExportedToGradle" } } + +gradle.taskGraph.afterTask { Task task, TaskState state -> + if (task.name == 'spotlessJavaCheck' && state.failure) { + throw new GradleException("\n****************************\n*PLEASE RUN ./gradlew tidy!*\n****************************"); + } +}