Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove double-counting 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene4547@1439168 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Muir 2013-01-27 20:22:22 +00:00
parent 31407be62d
commit d7ad96f234
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java
View File

@ -36,17 +36,12 @@ class BinaryDocValuesWriter extends DocValuesWriter {
private final FieldInfo fieldInfo; private final FieldInfo fieldInfo;
private int addedValues = 0; private int addedValues = 0;
private final BytesRef emptyBytesRef = new BytesRef(); private final BytesRef emptyBytesRef = new BytesRef();
private final Counter iwBytesUsed;
private long bytesUsed;
// nocommit this needs to update bytesUsed? // nocommit this needs to update bytesUsed?
public BinaryDocValuesWriter(FieldInfo fieldInfo, Counter iwBytesUsed) { public BinaryDocValuesWriter(FieldInfo fieldInfo, Counter iwBytesUsed) {
this.fieldInfo = fieldInfo; this.fieldInfo = fieldInfo;
this.bytesRefArray = new BytesRefArray(iwBytesUsed); this.bytesRefArray = new BytesRefArray(iwBytesUsed); // nocommit: test that this thing really accounts correctly
bytesUsed = bytesRefArray.bytesUsed(); // nocommit: totally wrong!!!!
this.iwBytesUsed = iwBytesUsed;
//nocommit WRONG iwBytesUsed.addAndGet(bytesUsed);
} }
public void addValue(int docID, BytesRef value) { public void addValue(int docID, BytesRef value) {
@ -67,13 +62,6 @@ class BinaryDocValuesWriter extends DocValuesWriter {
} }
addedValues++; addedValues++;
bytesRefArray.append(value); bytesRefArray.append(value);
updateBytesUsed();
}
private void updateBytesUsed() {
final long newBytesUsed = bytesRefArray.bytesUsed();
// nocommit: WRONG iwBytesUsed.addAndGet(newBytesUsed - bytesUsed);
bytesUsed = newBytesUsed;
} }
@Override @Override