Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-10489: Fix an occasional NPE.

This commit is contained in:
Andrzej Bialecki 2017-04-26 12:31:39 +02:00
parent 1f77776937
commit d8ec25bdc5
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
solr/core/src/test/org/apache/solr/handler/admin/StatsReloadRaceTest.java
View File

@ -117,11 +117,18 @@ public class StatsReloadRaceTest extends SolrTestCaseJ4 {
req("prefix", "SEARCHER", "registry", registry, "compact", "true"), rsp); req("prefix", "SEARCHER", "registry", registry, "compact", "true"), rsp);
NamedList values = rsp.getValues(); NamedList values = rsp.getValues();
NamedList metrics = (NamedList)values.get("metrics");
metrics = (NamedList)metrics.get(registry);
// this is not guaranteed to exist right away after core reload - there's a // this is not guaranteed to exist right away after core reload - there's a
// small window between core load and before searcher metrics are registered // small window between core load and before searcher metrics are registered
// so we may have to check a few times // so we may have to check a few times, and then fail softly if reload is not complete yet
NamedList metrics = (NamedList)values.get("metrics");
if (metrics == null) {
if (softFail) {
return;
} else {
fail("missing 'metrics' element in handler's output: " + values.asMap(5).toString());
}
}
metrics = (NamedList)metrics.get(registry);
if (metrics.get(key) != null) { if (metrics.get(key) != null) {
found = true; found = true;
assertTrue(metrics.get(key) instanceof Long); assertTrue(metrics.get(key) instanceof Long);