Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-14433: Improve SolrShardReporter default metrics list (#1453) 

Now includes TLOG and UPDATE./update.
These were small bugs to begin with but from user perspective this is an incremental improvement.
This commit is contained in:
David Smiley 2020-04-27 23:48:34 -04:00 committed by GitHub
parent 960610a615
commit daeaffa9d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
solr/CHANGES.txt
View File

@ -98,6 +98,8 @@ Improvements
* SOLR-12845: Add a default autoscaling cluster policy. (shalin, varunthacker, ab)
* SOLR-14433: Metrics: SolrShardReporter's default metrics list now includes TLOG and UPDATE./update (David Smiley)
Optimizations
---------------------
* SOLR-8306: Do not collect expand documents when expand.rows=0 (Marshall Sanders, Amelia Henderson)

2
solr/core/src/java/org/apache/solr/metrics/reporters/solr/SolrShardReporter.java
View File

@ -68,7 +68,7 @@ public class SolrShardReporter extends SolrCoreReporter {
add("REPLICATION.*");
add("INDEX\\.flush.*");
add("INDEX\\.merge\\.major.*");
add("UPDATE\\./update/.*requests");
add("UPDATE\\./update.*requests");
add("QUERY\\./select.*requests");
}};

4
solr/core/src/test-files/solr/solr-solrreporter.xml
View File

@ -41,7 +41,7 @@
</reporter>
<reporter name="test" group="shard" class="org.apache.solr.metrics.reporters.solr.SolrShardReporter">
<int name="period">5</int>
<str name="filter">UPDATE\./update/.*requests</str>
<str name="filter">UPDATE\./update.*requests</str>
<str name="filter">QUERY\./select.*requests</str>
</reporter>
<reporter name="test" group="cluster" class="org.apache.solr.metrics.reporters.solr.SolrClusterReporter">
@ -60,7 +60,7 @@
<str name="group">cluster</str>
<str name="label">leader.$1</str>
<str name="registry">solr\.collection\.(.*)\.leader</str>
<str name="filter">UPDATE\./update/.*</str>
<str name="filter">UPDATE\./update.*</str>
</lst>
</reporter>
</metrics>

4
solr/core/src/test/org/apache/solr/metrics/reporters/solr/SolrCloudReportersTest.java
View File

@ -140,7 +140,7 @@ public class SolrCloudReportersTest extends SolrCloudTestCase {
String key = "QUERY./select.requests";
assertTrue(key, metrics.containsKey(key));
assertTrue(key, metrics.get(key) instanceof AggregateMetric);
key = "UPDATE./update/json.requests";
key = "UPDATE./update.requests";
assertTrue(key, metrics.containsKey(key));
assertTrue(key, metrics.get(key) instanceof AggregateMetric);
}
@ -150,7 +150,7 @@ public class SolrCloudReportersTest extends SolrCloudTestCase {
String key = "jvm.memory.heap.init";
assertTrue(key, metrics.containsKey(key));
assertTrue(key, metrics.get(key) instanceof AggregateMetric);
key = "leader.test_collection.shard1.UPDATE./update/json.requests.max";
key = "leader.test_collection.shard1.UPDATE./update.requests.max";
assertTrue(key, metrics.containsKey(key));
assertTrue(key, metrics.get(key) instanceof AggregateMetric);
}