SOLR-14541: Remove IntelliJ //noinspection comments

solr/CHANGES.txt

@@ -380,6 +380,8 @@ Other Changes
   Only mentioned in 8.6 because I backported some more warning suppressions but not
   the fail-on-warnings.
 
+* SOLR-14589: Remove IntelliJ //noinspection comments (Erick Erickson)
+
 ==================  8.5.2 ==================
 
 Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.

solr/core/src/java/org/apache/solr/cloud/api/collections/RoutedAlias.java

@@ -130,7 +130,6 @@ public abstract class RoutedAlias {
       // this next remove is checked for key because when we build from aliases.json's data it we get an
       // immutable map which would cause  UnsupportedOperationException to be thrown. This remove is here
       // to prevent this property from making it into aliases.json
-      //noinspection RedundantCollectionOperation
       if (props.containsKey("router.routerList")) {
         props.remove("router.routerList");
       }

solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java

@@ -668,7 +668,6 @@ public class QueryElevationComponent extends SearchComponent implements SolrCore
     }
 
     if (context != null) {
-      //noinspection unchecked
       context.put(BOOSTED_DOCIDS, boostDocs);
     }
 

solr/core/src/java/org/apache/solr/handler/component/ShardFieldSortedHitQueue.java

@@ -160,7 +160,6 @@ public class ShardFieldSortedHitQueue extends PriorityQueue<ShardDoc> {
       @Override
       @SuppressWarnings({"unchecked"})
       public int compare(final ShardDoc o1, final ShardDoc o2) {
-        //noinspection unchecked
         return -fieldComparator.compareValues(sortVal(o1), sortVal(o2));
       }
     };

solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java

@@ -118,7 +118,6 @@ public class AliasIntegrationTest extends SolrCloudTestCase {
     assertEquals("collection2meta", aliases.get(1));
     //ensure we have the back-compat format in ZK:
     final byte[] rawBytes = zkStateReader.getZkClient().getData(ALIASES, null, null, true);
-    //noinspection unchecked
     assertTrue(((Map<String,Map<String,?>>)Utils.fromJSON(rawBytes)).get("collection").get("meta1") instanceof String);
 
     // set properties

solr/core/src/test/org/apache/solr/core/ResourceLoaderTest.java

@@ -76,7 +76,6 @@ public class ResourceLoaderTest extends SolrTestCaseJ4 {
     
     final Class<?> clazz1 = ResourceLoaderAware.class;
     // Check ResourceLoaderAware valid objects
-    //noinspection unchecked
     assertAwareCompatibility(clazz1, new NGramFilterFactory(map("minGramSize", "1", "maxGramSize", "2")));
     assertAwareCompatibility(clazz1, new KeywordTokenizerFactory(new HashMap<>()));
     
@@ -99,7 +98,6 @@ public class ResourceLoaderTest extends SolrTestCaseJ4 {
     assertAwareCompatibility(clazz2, new JSONResponseWriter());
     
     // Make sure it throws an error for invalid objects
-    //noinspection unchecked
     invalid = new Object[] {
         new NGramFilterFactory(map("minGramSize", "1", "maxGramSize", "2")),
         "hello",   12.3f ,

solr/solrj/src/java/org/apache/solr/common/util/CommandOperation.java

@@ -73,7 +73,6 @@ public class CommandOperation {
   @SuppressWarnings({"unchecked"})
   public Map<String, Object> getDataMap() {
     if (commandData instanceof Map) {
-      //noinspection unchecked
       return (Map<String, Object>) commandData;
     }
     addError(StrUtils.formatString("The command ''{0}'' should have the values as a json object '{'key:val'}' format but is ''{1}''", name, commandData));