Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-10389 Adjust TestHnswGraph.testRandom (#626) 

Before PR #608 this test when searching HnswGraph was using
numSeed (the search queue size) equal to 100.
This patch returns the original value of the search queue to 100,
and gets the top topK results from it.
This commit is contained in:
Mayya Sharipova 2022-01-27 09:06:48 -05:00 committed by GitHub
parent eda9c29b8c
commit dcd9e3d6f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lucene/core/src/test/org/apache/lucene/util/hnsw/TestHnswGraph.java
View File

@ -365,7 +365,6 @@ public class TestHnswGraph extends LuceneTestCase {
actual);
}
@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/LUCENE-10389")
public void testRandom() throws IOException {
int size = atLeast(100);
int dim = atLeast(10);
@ -384,7 +383,10 @@ public class TestHnswGraph extends LuceneTestCase {
for (int i = 0; i < 100; i++) {
float[] query = randomVector(random(), dim);
NeighborQueue actual =
HnswGraph.search(query, topK, vectors, similarityFunction, hnsw, acceptOrds);
HnswGraph.search(query, 100, vectors, similarityFunction, hnsw, acceptOrds);
while (actual.size() > topK) {
actual.pop();
}
NeighborQueue expected = new NeighborQueue(topK, similarityFunction.reversed);
for (int j = 0; j < size; j++) {
if (vectors.vectorValue(j) != null && (acceptOrds == null || acceptOrds.get(j))) {
@ -399,7 +401,7 @@ public class TestHnswGraph extends LuceneTestCase {
}
double overlap = totalMatches / (double) (100 * topK);
System.out.println("overlap=" + overlap + " totalMatches=" + totalMatches);
assertTrue("overlap=" + overlap, overlap > 0.8);
assertTrue("overlap=" + overlap, overlap > 0.9);
}
private int computeOverlap(int[] a, int[] b) {