Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-8171: Check only for exactly zero magnitude vector, and otherwise let the iterative code try to converge.

This commit is contained in:
Karl Wright 2018-02-13 10:31:13 -05:00
parent 8a5a4a6317
commit dd08400a3d
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/Vector.java
View File

@ -106,10 +106,9 @@ public class Vector {
final double thisZ = AX * BY - AY * BX; final double thisZ = AX * BY - AY * BX;
final double magnitude = magnitude(thisX, thisY, thisZ); final double magnitude = magnitude(thisX, thisY, thisZ);
if (magnitude < MINIMUM_RESOLUTION) { if (magnitude == 0.0) {
throw new IllegalArgumentException("Degenerate/parallel vector constructed"); throw new IllegalArgumentException("Degenerate/parallel vector constructed");
} }
final double inverseMagnitude = 1.0/magnitude; final double inverseMagnitude = 1.0/magnitude;
double normalizeX = thisX * inverseMagnitude; double normalizeX = thisX * inverseMagnitude;
@ -215,7 +214,7 @@ public class Vector {
final double thisZ = A.x * B.y - A.y * B.x; final double thisZ = A.x * B.y - A.y * B.x;
final double magnitude = magnitude(thisX, thisY, thisZ); final double magnitude = magnitude(thisX, thisY, thisZ);
if (magnitude < MINIMUM_RESOLUTION) { if (magnitude == 0.0) {
return true; return true;
} }

1
lucene/spatial3d/src/test/org/apache/lucene/spatial3d/geom/RandomPlaneTest.java
View File

@ -52,7 +52,6 @@ public class RandomPlaneTest extends RandomGeo3dShapeGenerator {
} }
} }
@Ignore
@Test @Test
@Repeat(iterations = 10) @Repeat(iterations = 10)
public void testPlaneThreePointsAccuracy() { public void testPlaneThreePointsAccuracy() {