diff --git a/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudClusterSSL.java b/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudClusterSSL.java index 946f3d16b3e..b9e8a0417c6 100644 --- a/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudClusterSSL.java +++ b/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudClusterSSL.java @@ -85,8 +85,7 @@ public class TestMiniSolrCloudClusterSSL extends SolrTestCaseJ4 { @Before public void before() { - assumeFalse("SOLR-12988: TLSv1.3 in Java 11.0.2 or lower versions does not working correctly with HttpClient", - Constants.JRE_IS_MINIMUM_JAVA11 && Runtime.version().compareTo(Runtime.Version.parse("11.0.3")) < 0); + assumeFalse("@AwaitsFix: SOLR-12988 - ssl issues on Java 11/12", Constants.JRE_IS_MINIMUM_JAVA11); // undo the randomization of our super class log.info("NOTE: This Test ignores the randomized SSL & clientAuth settings selected by base class"); diff --git a/solr/core/src/test/org/apache/solr/cloud/TestSSLRandomization.java b/solr/core/src/test/org/apache/solr/cloud/TestSSLRandomization.java index 773ddacbc36..12411895553 100644 --- a/solr/core/src/test/org/apache/solr/cloud/TestSSLRandomization.java +++ b/solr/core/src/test/org/apache/solr/cloud/TestSSLRandomization.java @@ -44,8 +44,7 @@ public class TestSSLRandomization extends SolrCloudTestCase { @BeforeClass public static void createMiniSolrCloudCluster() throws Exception { - assumeFalse("SOLR-12988: TLSv1.3 in Java 11.0.2 or lower versions does not working correctly with HttpClient", - Constants.JRE_IS_MINIMUM_JAVA11 && Runtime.version().compareTo(Runtime.Version.parse("11.0.3")) < 0); + assumeFalse("@AwaitsFix: SOLR-12988 - ssl issues on Java 11/12", Constants.JRE_IS_MINIMUM_JAVA11); configureCluster(TestMiniSolrCloudClusterSSL.NUM_SERVERS).configure(); } diff --git a/solr/test-framework/src/java/org/apache/solr/util/SSLTestConfig.java b/solr/test-framework/src/java/org/apache/solr/util/SSLTestConfig.java index 3539995d7d7..fb21ef7bbbd 100644 --- a/solr/test-framework/src/java/org/apache/solr/util/SSLTestConfig.java +++ b/solr/test-framework/src/java/org/apache/solr/util/SSLTestConfig.java @@ -16,7 +16,7 @@ */ package org.apache.solr.util; -import java.lang.invoke.MethodHandles; +import javax.net.ssl.SSLContext; import java.security.KeyManagementException; import java.security.KeyStore; import java.security.KeyStoreException; @@ -26,8 +26,6 @@ import java.security.SecureRandomSpi; import java.security.UnrecoverableKeyException; import java.util.Random; -import javax.net.ssl.SSLContext; - import org.apache.http.config.Registry; import org.apache.http.config.RegistryBuilder; import org.apache.http.conn.socket.ConnectionSocketFactory; @@ -44,8 +42,6 @@ import org.apache.solr.client.solrj.impl.HttpClientUtil.SchemaRegistryProvider; import org.eclipse.jetty.util.resource.Resource; import org.eclipse.jetty.util.security.CertificateUtils; import org.eclipse.jetty.util.ssl.SslContextFactory; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; /** * An SSLConfig that provides {@link SSLConfig} and {@link SchemaRegistryProvider} for both clients and servers @@ -53,7 +49,6 @@ import org.slf4j.LoggerFactory; * Solr test-framework classes */ public class SSLTestConfig { - private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); private static final String TEST_KEYSTORE_BOGUSHOST_RESOURCE = "SSLTestConfig.hostname-and-ip-missmatch.keystore"; private static final String TEST_KEYSTORE_LOCALHOST_RESOURCE = "SSLTestConfig.testing.keystore"; private static final String TEST_PASSWORD = "secret"; @@ -104,11 +99,11 @@ public class SSLTestConfig { * @see HttpClientUtil#SYS_PROP_CHECK_PEER_NAME */ public SSLTestConfig(boolean useSSL, boolean clientAuth, boolean checkPeerName) { - if (useSSL) { - if (Constants.JRE_IS_MINIMUM_JAVA11 && Runtime.version().compareTo(Runtime.Version.parse("11.0.3")) < 0) { - log.warn("SOLR-12988: TLSv1.3 in Java 11.0.2 or lower versions does not working correctly with HttpClient, disabling SSL for tests"); - useSSL = false; - } + // @AwaitsFix: SOLR-12988 - ssl issues on Java 11/12 + if (Constants.JRE_IS_MINIMUM_JAVA11) { + this.useSsl = false; + } else { + this.useSsl = useSSL; } this.useSsl = useSSL; this.clientAuth = clientAuth;