Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-12275: test cleanup

This commit is contained in:
Mikhail Khludnev 2018-04-26 20:17:26 +03:00
parent e912ed2a2c
commit e3a9817174
1 changed files with 22 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
solr/core/src/test/org/apache/solr/search/join/BJQParserTest.java
View File

@ -16,9 +16,7 @@
*/ */
package org.apache.solr.search.join; package org.apache.solr.search.join;
import javax.xml.xpath.XPathConstants;
import java.io.IOException; import java.io.IOException;
import java.lang.invoke.MethodHandles;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collections; import java.util.Collections;
@ -27,6 +25,8 @@ import java.util.ListIterator;
import java.util.Locale; import java.util.Locale;
import java.util.Map; import java.util.Map;
import javax.xml.xpath.XPathConstants;
import org.apache.lucene.search.Query; import org.apache.lucene.search.Query;
import org.apache.lucene.search.TopDocs; import org.apache.lucene.search.TopDocs;
import org.apache.lucene.search.join.ScoreMode; import org.apache.lucene.search.join.ScoreMode;
@ -39,14 +39,12 @@ import org.apache.solr.request.SolrQueryRequest;
import org.apache.solr.search.QParser; import org.apache.solr.search.QParser;
import org.apache.solr.search.SyntaxError; import org.apache.solr.search.SyntaxError;
import org.apache.solr.util.BaseTestHarness; import org.apache.solr.util.BaseTestHarness;
import org.junit.After;
import org.junit.BeforeClass; import org.junit.BeforeClass;
import org.junit.Test; import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class BJQParserTest extends SolrTestCaseJ4 { public class BJQParserTest extends SolrTestCaseJ4 {
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private static final String[] klm = new String[] {"k", "l", "m"}; private static final String[] klm = new String[] {"k", "l", "m"};
private static final List<String> xyz = Arrays.asList("x", "y", "z"); private static final List<String> xyz = Arrays.asList("x", "y", "z");
private static final String[] abcdef = new String[] {"a", "b", "c", "d", "e", "f"}; private static final String[] abcdef = new String[] {"a", "b", "c", "d", "e", "f"};
@ -86,15 +84,8 @@ public class BJQParserTest extends SolrTestCaseJ4 {
} }
assertU(commit()); assertU(commit());
assertQ(req("q", "*:*"), "//*[@numFound='" + i + "']"); assertQ(req("q", "*:*"), "//*[@numFound='" + i + "']");
/*
* dump docs well System.out.println(h.query(req("q","*:*",
* "sort","_docid_ asc", "fl",
* "parent_s,child_s,parentchild_s,grand_s,grand_child_s,grand_parentchild_s"
* , "wt","csv", "rows","1000"))); /
*/
} }
private static int id=0;
private static List<List<String[]>> createBlocks() { private static List<List<String[]>> createBlocks() {
List<List<String[]>> blocks = new ArrayList<>(); List<List<String[]>> blocks = new ArrayList<>();
for (String parent : abcdef) { for (String parent : abcdef) {
@ -299,12 +290,11 @@ public class BJQParserTest extends SolrTestCaseJ4 {
@Test @Test
public void testCacheHit() throws IOException { public void testCacheHit() throws IOException {
MetricsMap parentFilterCache = (MetricsMap)((SolrMetricManager.GaugeWrapper)h.getCore().getCoreMetricManager().getRegistry() MetricsMap parentFilterCache = (MetricsMap)((SolrMetricManager.GaugeWrapper<?>)h.getCore().getCoreMetricManager().getRegistry()
.getMetrics().get("CACHE.searcher.perSegFilter")).getGauge(); .getMetrics().get("CACHE.searcher.perSegFilter")).getGauge();
MetricsMap filterCache = (MetricsMap)((SolrMetricManager.GaugeWrapper)h.getCore().getCoreMetricManager().getRegistry() MetricsMap filterCache = (MetricsMap)((SolrMetricManager.GaugeWrapper<?>)h.getCore().getCoreMetricManager().getRegistry()
.getMetrics().get("CACHE.searcher.filterCache")).getGauge(); .getMetrics().get("CACHE.searcher.filterCache")).getGauge();
Map<String,Object> parentsBefore = parentFilterCache.getValue(); Map<String,Object> parentsBefore = parentFilterCache.getValue();
Map<String,Object> filtersBefore = filterCache.getValue(); Map<String,Object> filtersBefore = filterCache.getValue();
@ -462,40 +452,32 @@ public class BJQParserTest extends SolrTestCaseJ4 {
"child.fq", "childparent_s:e", "child.fq", "childparent_s:e",
"child.fq", "child_s:l", "child.fq", "child_s:l",
"gchq", "child_s:[* TO *]"}; "gchq", "child_s:[* TO *]"};
assertQ(req(elFilterQuery), elChild); assertQ("precondition: single doc match",
req(elFilterQuery), elChild);
final Query query; final Query query;
{ try(final SolrQueryRequest req = req(elFilterQuery)) {
final SolrQueryRequest req = req(elFilterQuery); QParser parser = QParser.getParser(req.getParams().get("q"), null, req);
try { query = parser.getQuery();
QParser parser = QParser.getParser(req.getParams().get("q"), null, req); final TopDocs topDocs = req.getSearcher().search(query, 10);
query = parser.getQuery(); assertEquals(1, topDocs.totalHits);
final TopDocs topDocs = req.getSearcher().search(query, 10);
assertEquals(1, topDocs.totalHits);
}finally {
req.close();
}
} }
assertU(adoc("id", "12275", assertU(adoc("id", "12275",
"child_s", "l", "childparent_s", "e")); "child_s", "l", "childparent_s", "e"));
assertU(commit()); assertU(commit());
try {
assertQ("here we rely on autowarming for cathing cache leak", //cache=false assertQ("here we rely on autowarming for cathing cache leak", //cache=false
req(elFilterQuery), "//*[@numFound='2']"); req(elFilterQuery), "//*[@numFound='2']");
final SolrQueryRequest req = req();
try { try(final SolrQueryRequest req = req()) {
final TopDocs topDocs = req.getSearcher().search(query, 10); final TopDocs topDocs = req.getSearcher().search(query, 10);
assertEquals("expecting new doc is visible to old query", 2, topDocs.totalHits); assertEquals("expecting new doc is visible to old query", 2, topDocs.totalHits);
}finally {
req.close();
}
}finally {
try {
assertU(delI("12275"));
assertU(commit());
} catch(Throwable t) {
log.error("ignoring exception occuring in compensation routine", t);
}
} }
} }
@After
public void cleanAfterTestFiltersCache(){
assertU("should be noop", delI("12275"));
assertU("most of the time", commit());
}
} }