From e864ab6cd89542e2569c127de7605ed724fd883f Mon Sep 17 00:00:00 2001
From: Yonik Seeley <yonik@apache.org>
Date: Tue, 29 May 2007 16:33:23 +0000
Subject: [PATCH] add usage comments, reformat

git-svn-id: https://svn.apache.org/repos/asf/lucene/solr/trunk@542583 13f79535-47bb-0310-9956-ffa450edef68
---
 src/java/org/apache/solr/util/RefCounted.java | 36 +++++++++++++++----
 1 file changed, 30 insertions(+), 6 deletions(-)

diff --git a/src/java/org/apache/solr/util/RefCounted.java b/src/java/org/apache/solr/util/RefCounted.java
index 2a67a4ab015..b04fda34ea1 100644
--- a/src/java/org/apache/solr/util/RefCounted.java
+++ b/src/java/org/apache/solr/util/RefCounted.java
@@ -19,17 +19,41 @@ package org.apache.solr.util;
 
 import java.util.concurrent.atomic.AtomicInteger;
 
-/**
+/** Keep track of a reference count on a resource and close it when
+ * the count hits zero.
+ *
+ * By itself, this class could have some race conditions
+ * since there is no synchronization between the refcount
+ * check and the close.  Solr's use in reference counting searchers
+ * is safe since the count can only hit zero if it's unregistered (and
+ * hence incref() will not be called again on it).
+ *
  * @author yonik
  * @version $Id$
  */
 
 public abstract class RefCounted<Type> {
   protected final Type resource;
-  protected final AtomicInteger refcount= new AtomicInteger();
-  public RefCounted(Type resource) { this.resource = resource; }
-  public final RefCounted<Type> incref() { refcount.incrementAndGet(); return this; }
-  public final Type get() { return resource; }
-  public void decref() { if (refcount.decrementAndGet()==0) close(); }
+  protected final AtomicInteger refcount = new AtomicInteger();
+
+  public RefCounted(Type resource) {
+    this.resource = resource;
+  }
+
+  public final RefCounted<Type> incref() {
+    refcount.incrementAndGet();
+    return this;
+  }
+
+  public final Type get() {
+    return resource;
+  }
+
+  public void decref() {
+    if (refcount.decrementAndGet() == 0) {
+      close();
+    }
+  }
+
   protected abstract void close();
 }