Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add basic bounds checks for terms/payloads/etc 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1438164 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Muir 2013-01-24 20:30:59 +00:00
parent 7a66fc108f
commit e9e3721152
1 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
View File

@ -769,6 +769,8 @@ public class CheckIndex {
break;
}
checkBounds(term);
// make sure terms arrive in order according to
// the comp
if (lastTerm == null) {
@ -856,6 +858,9 @@ public class CheckIndex {
}
lastPos = pos;
BytesRef payload = postings.getPayload();
if (payload != null) {
checkBounds(payload);
}
if (payload != null && payload.length < 1) {
throw new RuntimeException("term " + term + ": doc " + doc + ": pos " + pos + " payload length is out of bounds " + payload.length);
}
@ -1366,6 +1371,31 @@ public class CheckIndex {
}
return status;
}
// basic value checks
private static void checkBounds(BytesRef b) {
if (b.bytes == null) {
throw new RuntimeException("bytes is null");
}
if (b.length < 0) {
throw new RuntimeException("length is negative: " + b.length);
}
if (b.length > b.bytes.length) {
throw new RuntimeException("length is out of bounds: " + b.length + ", bytes.length=" + b.bytes.length);
}
if (b.offset < 0) {
throw new RuntimeException("offset is negative: " + b.offset);
}
if (b.offset > b.bytes.length) {
throw new RuntimeException("offset out of bounds: " + b.offset + ", length=" + b.length);
}
if (b.offset + b.length < 0) {
throw new RuntimeException("offset+length is negative: offset=" + b.offset + ",length=" + b.length);
}
if (b.offset + b.length > b.bytes.length) {
throw new RuntimeException("offset+length out of bounds: offset=" + b.offset + ",length=" + b.length + ",bytes.length=" + b.bytes.length);
}
}
/**
* Test term vectors for a segment.