diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt index ba98721f27d..6dab4b25df5 100644 --- a/lucene/CHANGES.txt +++ b/lucene/CHANGES.txt @@ -690,6 +690,9 @@ Optimizations * LUCENE-3795: Replace contrib/spatial with modules/spatial. This includes a basic spatial strategy interface. (David Smiley, Chris Male, ryan) +* LUCENE-3932: Lucene3x codec loads terms index faster, by + pre-allocating the packed ints array based on the .tii file size + (Sean Bridges via Mike McCandless) Bug fixes diff --git a/lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java b/lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java index 7c23721f5fa..cd96af338be 100644 --- a/lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java +++ b/lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java @@ -22,6 +22,7 @@ import java.util.Arrays; import org.apache.lucene.store.BufferedIndexInput; import org.apache.lucene.store.IndexInput; +import org.apache.lucene.util.MathUtil; /** * This abstract class reads skip lists with multiple levels. @@ -184,21 +185,9 @@ public abstract class MultiLevelSkipListReader { } } - /** returns x == 0 ? 0 : Math.floor(Math.log(x) / Math.log(base)) */ - static int log(int x, int base) { - assert base >= 2; - int ret = 0; - long n = base; // needs to be a long to avoid overflow - while (x >= n) { - n *= base; - ret++; - } - return ret; - } - /** Loads the skip levels */ private void loadSkipLevels() throws IOException { - numberOfSkipLevels = log(docCount, skipInterval[0]); + numberOfSkipLevels = MathUtil.log(docCount, skipInterval[0]); if (numberOfSkipLevels > maxNumberOfSkipLevels) { numberOfSkipLevels = maxNumberOfSkipLevels; } diff --git a/lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListWriter.java b/lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListWriter.java index 30c91385ae3..89cbbca4d39 100644 --- a/lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListWriter.java +++ b/lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListWriter.java @@ -21,6 +21,7 @@ import java.io.IOException; import org.apache.lucene.store.IndexOutput; import org.apache.lucene.store.RAMOutputStream; +import org.apache.lucene.util.MathUtil; /** * This abstract class writes skip lists with multiple levels. @@ -61,7 +62,7 @@ public abstract class MultiLevelSkipListWriter { this.skipInterval = skipInterval; // calculate the maximum number of skip levels for this document frequency - numberOfSkipLevels = MultiLevelSkipListReader.log(df, skipInterval); + numberOfSkipLevels = MathUtil.log(df, skipInterval); // make sure it does not exceed maxSkipLevels if (numberOfSkipLevels > maxSkipLevels) { diff --git a/lucene/core/src/java/org/apache/lucene/codecs/lucene3x/TermInfosReaderIndex.java b/lucene/core/src/java/org/apache/lucene/codecs/lucene3x/TermInfosReaderIndex.java index b37384c713e..d5a2f3e0750 100644 --- a/lucene/core/src/java/org/apache/lucene/codecs/lucene3x/TermInfosReaderIndex.java +++ b/lucene/core/src/java/org/apache/lucene/codecs/lucene3x/TermInfosReaderIndex.java @@ -25,6 +25,7 @@ import java.util.List; import org.apache.lucene.index.Term; import org.apache.lucene.util.BitUtil; import org.apache.lucene.util.BytesRef; +import org.apache.lucene.util.MathUtil; import org.apache.lucene.util.PagedBytes.PagedBytesDataInput; import org.apache.lucene.util.PagedBytes.PagedBytesDataOutput; import org.apache.lucene.util.PagedBytes; @@ -72,7 +73,9 @@ class TermInfosReaderIndex { PagedBytes dataPagedBytes = new PagedBytes(estimatePageBits(initialSize)); PagedBytesDataOutput dataOutput = dataPagedBytes.getDataOutput(); - GrowableWriter indexToTerms = new GrowableWriter(4, indexSize, false); + final int bitEstimate = 1+MathUtil.log(tiiFileLength, 2); + GrowableWriter indexToTerms = new GrowableWriter(bitEstimate, indexSize, false); + String currentField = null; List fieldStrs = new ArrayList(); int fieldCounter = -1; diff --git a/lucene/core/src/java/org/apache/lucene/util/MathUtil.java b/lucene/core/src/java/org/apache/lucene/util/MathUtil.java new file mode 100644 index 00000000000..5382363e6f7 --- /dev/null +++ b/lucene/core/src/java/org/apache/lucene/util/MathUtil.java @@ -0,0 +1,36 @@ +package org.apache.lucene.util; + +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +public final class MathUtil { + + // No instance: + private MathUtil() { + } + + /** returns x == 0 ? 0 : Math.floor(Math.log(x) / Math.log(base)) */ + public static int log(long x, int base) { + assert base > 1; + int ret = 0; + while (x >= base) { + x /= base; + ret++; + } + return ret; + } +}