LUCENE-2952: restore src/tools and move validation there

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1084274 13f79535-47bb-0310-9956-ffa450edef68

common-build.xml

@@ -19,12 +19,12 @@
          xmlns:artifact="antlib:org.apache.maven.artifact.ant">
 
   <dirname file="${ant.file.all-common}" property="all.common.dir"/>
-  <path id="validation.runtime.classpath">
+  <path id="tools.runtime.classpath">
-    <pathelement location="${all.common.dir}/lucene/build/classes/test-framework"/>
+    <pathelement location="${all.common.dir}/lucene/build/classes/tools"/>
   </path>
-  <target name="compile-test-framework" description="Compile the Test Framework and Validation tools">
+  <target name="compile-tools" description="Compile the Test Framework and Validation tools">
     <sequential>
-      <subant target="compile-test-framework" inheritall="false" failonerror="true">
+      <subant target="compile-tools" inheritall="false" failonerror="true">
         <fileset dir="${all.common.dir}/lucene" includes="build.xml" />
       </subant>
     </sequential>

lucene/common-build.xml

@@ -424,6 +424,14 @@
   						test.classpath="test.classpath"/>
   </target>
 
+  <target name="compile-tools">
+    <compile
+      srcdir="${common.dir}/src/tools/java"
+      destdir="${build.dir}/classes/tools">
+      <classpath refid="classpath"/>
+    </compile>
+  </target>
+
   <target name="compile-test" depends="compile-test-framework">
   	<compile-test-macro srcdir="${tests.src.dir}" destdir="${build.dir}/classes/test"
   						test.classpath="test.classpath"/>
@@ -794,10 +802,10 @@
 
   <!-- VALIDATION work -->
 
-  <target name="check-legal-lucene" depends="compile-test-framework">
+  <target name="check-legal-lucene" depends="compile-tools">
     <java classname="org.apache.lucene.validation.DependencyChecker" failonerror="true" fork="true">
       <classpath>
-        <path refid="validation.runtime.classpath" />
+        <path refid="tools.runtime.classpath" />
       </classpath>
       <!-- TODO: it might be better to just automatically find all directories that contain jar files, but that could take a
        long time.  This should be faster, but we could miss a directory

modules/build.xml

@@ -66,10 +66,10 @@
   </target>
   <target name="validate" depends="validate-modules"/>
   <target name="validate-modules" depends="check-legal-modules" unless="validated-modules"/>
-  <target name="check-legal-modules" depends="compile-test-framework">
+  <target name="check-legal-modules" depends="compile-tools">
     <java classname="org.apache.lucene.validation.DependencyChecker" failonerror="true" fork="true">
       <classpath>
-        <path refid="validation.runtime.classpath" />
+        <path refid="tools.runtime.classpath" />
       </classpath>
       <!-- TODO: it might be better to just automatically find all directories that contain jar files, but that could take a
        long time.  This should be faster, but we could miss a directory

solr/common-build.xml

@@ -577,10 +577,10 @@
   <target name="validate" depends="validate-solr"/>
   <target name="validate-solr" depends="check-legal-solr" unless="validated-solr"/>
 
-  <target name="check-legal-solr" depends="compile-test-framework">
+  <target name="check-legal-solr" depends="compile-tools">
     <java classname="org.apache.lucene.validation.DependencyChecker" failonerror="true" fork="true">
       <classpath>
-        <path refid="validation.runtime.classpath" />
+        <path refid="tools.runtime.classpath" />
       </classpath>
       <!-- TODO: it might be better to just automatically find all directories that contain jar files, but that could take a
        long time.  This should be faster, but we could miss a directory