LUCENE-2523: Modify the test to check only for failure on IR.open(), add TODO to make IW.ctor() fail early, too

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@965883 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Uwe Schindler 2010-07-20 15:40:54 +00:00
parent 72d4191588
commit f608d4efc6
1 changed files with 8 additions and 5 deletions

View File

@ -28,6 +28,7 @@ import java.io.PrintStream;
import java.util.Arrays; import java.util.Arrays;
import java.util.Enumeration; import java.util.Enumeration;
import java.util.List; import java.util.List;
import java.util.Random;
import java.util.zip.ZipEntry; import java.util.zip.ZipEntry;
import java.util.zip.ZipFile; import java.util.zip.ZipFile;
@ -147,6 +148,7 @@ public class TestBackwardsCompatibility extends LuceneTestCase {
/** This test checks that *only* IndexFormatTooOldExceptions are throws when you open and operate on too old indexes! */ /** This test checks that *only* IndexFormatTooOldExceptions are throws when you open and operate on too old indexes! */
public void testUnsupportedOldIndexes() throws Exception { public void testUnsupportedOldIndexes() throws Exception {
final Random rnd = newRandom();
for(int i=0;i<unsupportedNames.length;i++) { for(int i=0;i<unsupportedNames.length;i++) {
unzip(getDataFile("unsupported." + unsupportedNames[i] + ".zip"), unsupportedNames[i]); unzip(getDataFile("unsupported." + unsupportedNames[i] + ".zip"), unsupportedNames[i]);
@ -157,8 +159,6 @@ public class TestBackwardsCompatibility extends LuceneTestCase {
IndexWriter writer = null; IndexWriter writer = null;
try { try {
reader = IndexReader.open(dir); reader = IndexReader.open(dir);
MultiFields.getFields(reader).terms("content");
reader.document(0); // to catch also 2.9->3.0 stored field change
fail("IndexReader.open should not pass for "+unsupportedNames[i]); fail("IndexReader.open should not pass for "+unsupportedNames[i]);
} catch (IndexFormatTooOldException e) { } catch (IndexFormatTooOldException e) {
// pass // pass
@ -172,9 +172,12 @@ public class TestBackwardsCompatibility extends LuceneTestCase {
TEST_VERSION_CURRENT, new MockAnalyzer()) TEST_VERSION_CURRENT, new MockAnalyzer())
.setMergeScheduler(new SerialMergeScheduler()) // no threads! .setMergeScheduler(new SerialMergeScheduler()) // no threads!
); );
writer.optimize(); // TODO: Make IndexWriter fail on open!
reader = writer.getReader(); if (rnd.nextBoolean()) {
reader.document(0); // to catch also 2.9->3.0 stored field change writer.optimize();
} else {
reader = writer.getReader();
}
fail("IndexWriter creation should not pass for "+unsupportedNames[i]); fail("IndexWriter creation should not pass for "+unsupportedNames[i]);
} catch (IndexFormatTooOldException e) { } catch (IndexFormatTooOldException e) {
// pass // pass