From fb7573adcc476fbe840d6097928fa5354fd79eaa Mon Sep 17 00:00:00 2001
From: Robert Muir <rmuir@apache.org>
Date: Mon, 4 Feb 2013 22:41:51 +0000
Subject: [PATCH] clear nocommits

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene4547@1442411 13f79535-47bb-0310-9956-ffa450edef68
---
 lucene/core/src/java/org/apache/lucene/index/FieldInfo.java | 1 -
 .../java/org/apache/lucene/index/NormsConsumerPerField.java | 6 ++----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java b/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java
index 6f40b2ff056..fc3236d8240 100644
--- a/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java
+++ b/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java
@@ -234,7 +234,6 @@ public final class FieldInfo {
     assert checkConsistency();
   }
 
-  // nocommit type is always number?  should we remove this?
   void setNormValueType(DocValuesType type) {
     if (normType != null && normType != type) {
       throw new IllegalArgumentException("cannot change Norm type from " + normType + " to " + type + " for field \"" + name + "\"");
diff --git a/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java b/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java
index 178aedbf15c..4a3219eaa23 100644
--- a/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java
+++ b/lucene/core/src/java/org/apache/lucene/index/NormsConsumerPerField.java
@@ -43,8 +43,6 @@ final class NormsConsumerPerField extends InvertedDocEndConsumerPerField impleme
   void finish() throws IOException {
     if (fieldInfo.isIndexed() && !fieldInfo.omitsNorms()) {
       if (consumer == null) {
-        // nocommit wrongish?  what about the
-        // only-doc-with-norms-enabled-hits-exc case?
         fieldInfo.setNormValueType(FieldInfo.DocValuesType.NUMERIC);
         consumer = new NumericDocValuesWriter(fieldInfo, docState.docWriter.bytesUsed);
       }
@@ -56,8 +54,8 @@ final class NormsConsumerPerField extends InvertedDocEndConsumerPerField impleme
     int docCount = state.segmentInfo.getDocCount();
     if (consumer == null) {
       return; // null type - not omitted but not written -
-              // nocommit meaning the only docs that had
-              // norms hit exceptions?
+              // meaning the only docs that had
+              // norms hit exceptions (but indexed=true is set...)
     }
     consumer.finish(docCount);
     consumer.flush(state, normsWriter);