diff --git a/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java b/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java index 726bc4cb0ac..70e386d0b61 100644 --- a/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java +++ b/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java @@ -481,7 +481,7 @@ public final class Lucene90HnswVectorsReader extends KnnVectorsReader { } @Override - public void seek(int level, int targetOrd) throws IOException { + public void seek(int targetOrd) throws IOException { // unsafe; no bounds checking dataIn.seek(entry.ordOffsets[targetOrd]); arcCount = dataIn.readInt(); diff --git a/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsWriter.java b/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsWriter.java index f82278a21bd..0c2832bf5cf 100644 --- a/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsWriter.java +++ b/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsWriter.java @@ -208,12 +208,11 @@ public final class Lucene90HnswVectorsWriter extends KnnVectorsWriter { hnswGraphBuilder.setInfoStream(segmentWriteState.infoStream); HnswGraph graph = hnswGraphBuilder.build(vectorValues.randomAccess()); - // TODO: implement storing of hierarchical graph; for now stores only 0th level for (int ord = 0; ord < count; ord++) { // write graph offsets[ord] = graphData.getFilePointer() - graphDataOffset; - NeighborArray neighbors = graph.getNeighbors(0, ord); + NeighborArray neighbors = graph.getNeighbors(ord); int size = neighbors.size(); // Destructively modify; it's ok we are discarding it after this diff --git a/lucene/core/src/java/org/apache/lucene/index/KnnGraphValues.java b/lucene/core/src/java/org/apache/lucene/index/KnnGraphValues.java index 4ff1e8654f1..f8f175acd04 100644 --- a/lucene/core/src/java/org/apache/lucene/index/KnnGraphValues.java +++ b/lucene/core/src/java/org/apache/lucene/index/KnnGraphValues.java @@ -35,18 +35,17 @@ public abstract class KnnGraphValues { * Move the pointer to exactly {@code target}, the id of a node in the graph. After this method * returns, call {@link #nextNeighbor()} to return successive (ordered) connected node ordinals. * - * @param level level of the graph * @param target must be a valid node in the graph, ie. ≥ 0 and < {@link * VectorValues#size()}. */ - public abstract void seek(int level, int target) throws IOException; + public abstract void seek(int target) throws IOException; /** Returns the number of nodes in the graph */ public abstract int size(); /** * Iterates over the neighbor list. It is illegal to call this method after it returns - * NO_MORE_DOCS without calling {@link #seek(int, int)}, which resets the iterator. + * NO_MORE_DOCS without calling {@link #seek(int)}, which resets the iterator. * * @return a node ordinal in the graph, or NO_MORE_DOCS if the iteration is complete. */ @@ -62,7 +61,7 @@ public abstract class KnnGraphValues { } @Override - public void seek(int level, int target) {} + public void seek(int target) {} @Override public int size() { diff --git a/lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java b/lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java index 8f6a8f046a3..d1f0420d3cf 100644 --- a/lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java +++ b/lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java @@ -40,10 +40,10 @@ import org.apache.lucene.util.SparseFixedBitSet; *

Hyperparameters

* *