From fd80ead4019201e5c0d748e9ba9d43d0a6e896e6 Mon Sep 17 00:00:00 2001
From: Christine Poerschke <cpoerschke@apache.org>
Date: Mon, 4 Jul 2016 11:42:30 +0100
Subject: [PATCH] LUCENE-7358: Remove redundant failonerror=true in
 (contrib|modules)-crawl elements.

---
 lucene/build.xml | 15 +++++++--------
 solr/build.xml   |  8 ++++----
 2 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/lucene/build.xml b/lucene/build.xml
index f7dffd62c96..383fbeb46f8 100644
--- a/lucene/build.xml
+++ b/lucene/build.xml
@@ -78,7 +78,7 @@
 
   <!-- Validation here depends on compile-tools: but we want to compile modules' tools too -->
   <target name="compile-tools" depends="common.compile-tools">
-    <modules-crawl target="compile-tools" failonerror="true"/>
+    <modules-crawl target="compile-tools"/>
   </target>
 
   <target name="check-licenses" depends="compile-tools,resolve,load-custom-tasks" description="Validate license stuff.">
@@ -123,7 +123,7 @@
       <ant dir="${common.dir}/tools" target="resolve" inheritAll="false">
          <propertyset refid="uptodate.and.compiled.properties"/>
       </ant>
-      <modules-crawl target="resolve" failonerror="true"/>
+      <modules-crawl target="resolve"/>
     </sequential>
   </target>
 
@@ -242,8 +242,7 @@
   </target>
   
   <target name="javadocs-modules" description="Generate javadoc for modules classes">
-    <modules-crawl target="javadocs"
-                   failonerror="true"/>
+    <modules-crawl target="javadocs"/>
   </target>
 
   <!-- rat-sources-typedef is *not* a useless dependency. do not remove -->
@@ -462,7 +461,7 @@
       <ant dir="test-framework" target="compile-test" inheritall="false">
         <propertyset refid="uptodate.and.compiled.properties"/>
       </ant>
-      <modules-crawl target="compile-test" failonerror="true"/>
+      <modules-crawl target="compile-test"/>
     </sequential>
   </target>
 
@@ -473,7 +472,7 @@
   </target>
   
   <target name="test-modules">
-    <modules-crawl target="test" failonerror="true"/>
+    <modules-crawl target="test"/>
   </target>
 
   <target name="changes-to-html">
@@ -492,7 +491,7 @@
     <ant dir="${common.dir}/test-framework" target="jacoco" inheritAll="false">
       <propertyset refid="uptodate.and.compiled.properties"/>
     </ant>
-    <modules-crawl target="jacoco" failonerror="true"/>
+    <modules-crawl target="jacoco"/>
 
     <!-- produce aggregate report -->
     <property name="jacoco.output.dir" location="${jacoco.report.dir}/lucene-all"/>
@@ -583,7 +582,7 @@
     <sequential>
       <ant dir="core" target="common.-append-module-dependencies-properties" inheritall="false"/>
       <ant dir="test-framework" target="common.-append-module-dependencies-properties" inheritall="false"/>
-      <modules-crawl target="-append-module-dependencies-properties" failonerror="true"/>
+      <modules-crawl target="-append-module-dependencies-properties"/>
     </sequential>
   </target>
 </project>
diff --git a/solr/build.xml b/solr/build.xml
index 61503dfb9a1..3b43730cc4d 100644
--- a/solr/build.xml
+++ b/solr/build.xml
@@ -250,7 +250,7 @@
 
   <!-- Solr contrib targets -->
   <target name="test-contrib" description="Run contrib unit tests.">
-    <contrib-crawl target="test" failonerror="true"/>
+    <contrib-crawl target="test"/>
   </target>
 
   <!-- Pitest targets -->
@@ -350,7 +350,7 @@
       <fileset dir="solrj" includes="build.xml"/>
       <fileset dir="test-framework" includes="build.xml"/>
     </subant>
-    <contrib-crawl target="check-forbidden-apis" failonerror="true"/>
+    <contrib-crawl target="check-forbidden-apis"/>
   </target>
 
   <!-- rat sources -->
@@ -363,7 +363,7 @@
       <fileset dir="test-framework" includes="build.xml"/>
       <fileset dir="webapp" includes="build.xml"/>
     </subant>
-    <contrib-crawl target="rat-sources" failonerror="true"/>
+    <contrib-crawl target="rat-sources"/>
   </target>
   
   <!-- Clean targets -->
@@ -426,7 +426,7 @@
   
   <target name="dist-contrib" depends="init-dist"
           description="Make the contribs ready for distribution">
-    <contrib-crawl target="dist" failonerror="true" />
+    <contrib-crawl target="dist"/>
   </target>
   
   <target name="prepare-release-no-sign" depends="clean, package, generate-maven-artifacts"/>