8354 Commits

Author SHA1 Message Date
Erick Erickson
1f1cdbffdf LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects 2020-04-18 19:08:15 -04:00
Erick Erickson
3af165b32a LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects 2020-04-17 20:40:32 -04:00
Jan Høydahl
03363f413f
SOLR-14371 Zk StatusHandler should know about dynamic zk config (#1392) 2020-04-17 16:30:27 +02:00
David Smiley
1fc4a546df Solr: Use QueryUtils.combineQueryAndFilter more
and check MatchAllDocsQuery (minor & cheap optimization)
 Closes #1407
2020-04-14 16:45:59 -04:00
Jan Høydahl
ceeb55c7f5 SOLR-14210: Fix precommit for javadocs 2020-04-14 16:26:43 +02:00
Jan Høydahl
60545a89e0 SOLR-14210: Add javadocs and refguide docs 2020-04-14 16:09:36 +02:00
Shalin Shekhar Mangar
13f19f6555 SOLR-9906: SolrjNamedThreadFactory is deprecated in favor of SolrNamedThreadFactory. DefaultSolrThreadFactory is removed from solr-core in favor of SolrNamedThreadFactory in solrj package and all solr-core classes now use SolrNamedThreadFactory 2020-04-13 08:16:35 +05:30
Trey Grainger
04f44399ba SOLR-14396: TaggerRequestHandler should not error on empty index
Fixes #1421
2020-04-12 21:54:27 -04:00
Shalin Shekhar Mangar
d52c1021e5 SOLR-14402: Avoid creating new exceptions for every request made to MDCAwareThreadPoolExecutor by distributed search.
This is a fix for incomplete optimization made by SOLR-11880 in Solr 7.4 which fixed distributed updates but not distributed search.
2020-04-11 08:56:01 +05:30
Munendra S N
36b280bd0a SOLR-11775: return long val for facet count in json facet
* Long value is returned for any count related to json facets
  irrespective of number of shards
2020-04-10 19:30:20 +05:30
Cao Manh Dat
71d335ff68 SOLR-14365: Automatically grow size of groupHeadValues 2020-04-10 20:37:04 +07:00
Cao Manh Dat
adbd714b37
SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) (#1395) 2020-04-10 15:24:10 +07:00
Christine Poerschke
ffdd29e6fb Fix typo in SolrRequestHandler's javadocs. 2020-04-09 17:21:47 +01:00
David Smiley
5bfbdc5325 SOLR-14376: optimize SolrIndexSearcher.getDocSet when matches everything
* getProcessedFilter now returns null filter if it's all docs more reliably
* getProcessedFilter now documented clearly as an internal method
* getDocSet detects all-docs and exits early with getLiveDocs
* small refactoring to getDocSetBits/makeDocSetBits
Closes #1399
2020-04-07 16:25:09 -04:00
Jan Høydahl
f2114b9935
SOLR-14210: Include replica health in healtcheck handler (#1387) 2020-04-07 12:26:11 +02:00
Shalin Shekhar Mangar
9322a7b375 SOLR-12067: Remove support for autoReplicaFailoverWaitAfterExpiration
This closes #1402.
2020-04-06 07:25:14 +05:30
David Smiley
1aeefc25d1 SOLR-14351: Fix/improve MDCLoggingContext usage
* Some set/clear were not balanced.
* Harden clear() in case of imbalance.
* Sometimes coreContainger.getCore was called unnecessarily; just need a descriptor
* SolrCore.open/close now calls MDCLoggerContext.setCore/clear
* no need to clear MDC in HttpSolrCall
2020-04-03 21:45:12 -04:00
David Smiley
7b3980c080 SOLR-14364: LTR SolrFeature fq improvements
Mostly general code improvements, though it should support postFilters now
Add QueryUtils.combineQueryAndFilter
2020-04-03 19:20:55 -04:00
Cao Manh Dat
28dea8d327 SOLR-14356: PeerSync should not fail with SocketTimeoutException from hanging nodes 2020-04-03 09:39:29 +07:00
Eric Pugh
927587d8ad
fix typo (#1302) 2020-04-02 10:38:15 -05:00
Chris Hostetter
f779bc632d SOLR-14307: User defined "<cache/>" entries in solrconfig.xml now support enabled="true|false" just like core searcher caches. 2020-04-01 11:29:08 -07:00
Jason Gerlowski
1f5705ff5c
SOLR-14363: Separate /get requests into their own type designation (#1379) 2020-04-01 08:41:48 -04:00
Erick Erickson
1ca7067a81 SOLR-12028: BadApple and AwaitsFix annotations usage, Unannotated tests that haven't failed in a while 2020-03-30 20:37:55 -04:00
Munendra S N
9de6811706 SOLR-13893: remove deprecated runtme.lib.size sys property 2020-03-28 11:59:30 +05:30
Munendra S N
1a2325a08f SOLR-13893: fix typo in BlobRepository's max jar size sys property
* runtime.lib.size is the new property name
2020-03-28 11:53:21 +05:30
Munendra S N
132228d450 SOLR-14344: remove deprecated HttpSolrClient's Remote*Exception
* All usages are replaced by BaseHttpSolrClient's Remote*Exception
2020-03-28 11:36:06 +05:30
Munendra S N
15330a8541 SOLR-14329: support choosing expand field from multiple collapse group
* The collapse group with low cost is given higher priority. If
  there are multiple groups  with same cost then, first such
  group is chosen
2020-03-28 11:23:45 +05:30
Munendra S N
7a83f09fbc SOLR-13842: remove redundant defaults from implictPlugins
* From 7.0, wt=json is the default and indent=true is the
  default. So, remove them from implicitPlugin defaults
2020-03-28 11:17:22 +05:30
Mike
ac866a67de
Remove CurrentCoreDescriptorProvider (#1384)
* Remove CurrentCoreDescriptorProvider

Replace `CurrentCoreDescriptorProvider` with a functional interface so
that it is easier to construct since all implementations in our code
base were anonymous classes anyway. Added Javadocs explaining the
usage instead of relying on class name to convey information.
2020-03-27 16:31:37 -05:00
David Smiley
a0b0c710b5 SOLR-14342: Improve core loading order in SolrCloud.
Makes collections available sooner and reduces leaderVoteWait timeouts in large SolrCloud clusters.
This fixes a previous attempt to do this.
Fixes #1366
2020-03-26 23:44:20 -04:00
Andy Throgmorton
d1601f6fdf SOLR-14260: SolrJ pluggable ConnectionSocketFactory in HttpClientUtil
see SocketFactoryRegistryProvider
Fixes #1261
2020-03-26 22:15:50 -04:00
Mike Drob
a31ecd2eb8 SOLR-14322 Improve AbstractFullDistribZkTestBase.waitForThingsToLevelOut 2020-03-26 17:38:05 -05:00
David Smiley
ea864b43a3
SOLR-13659: Remove unused SolrCacheHolder
accidental leftover from reverted plugin work
2020-03-26 17:35:24 -04:00
Andrzej Bialecki
b0728ceca6 SOLR-14128: Improve distributed locking around managed schema upgrade process. 2020-03-25 22:19:38 +01:00
Mike
8d937c1dc3
SOLR-14274 Do not register multiple sets of JVM metrics (#1299) 2020-03-25 13:48:17 -05:00
Uwe Schindler
2c7a710945
LUCENE-9281: Retire SPIClassIterator from master because Java 9+ uses different mechanism to load services when module system is used (#1360)
LUCENE-9281: Use java.util.ServiceLoader to load codec components and analysis factories to be compatible with Java Module System
2020-03-25 18:03:36 +01:00
mariemat
aad814ba63 SOLR-14340: Remove unnecessary configset verification checks
Improves CLUSTERSTATUS times for massive clusters.
Closes #1373
2020-03-24 15:34:20 -04:00
Andrzej Bialecki
68e4304453 SOLR-14347: Autoscaling placement wrong when concurrent replica placements are calculated. 2020-03-23 18:21:40 +01:00
Munendra S N
7f460faffb fix typos in subquery doc transformer 2020-03-23 19:57:46 +05:30
Munendra S N
06fd70fc0f SOLR-14348: split TestJsonFacets to multiple test classes
* TestJsonFacet split into 3 classes, TestsJsonFacets, TestJsonFacetErrors
  and TestJsonRangeFacet
* TestJsonFacets contains mainly terms faceting and stats
* range facet covers distributed cases too
2020-03-23 19:50:58 +05:30
Erick Erickson
5fd55d77e9 SOLR-12353: SolrDispatchFilter expensive non-conditional debug line degrades performance 2020-03-19 15:26:44 -04:00
Munendra S N
78e670f19e SOLR-14012: return long from unique and hll even for standalone 2020-03-19 19:21:57 +05:30
Munendra S N
e9d6c24fb7 SOLR-11725: use corrected sample formula to calc stdDev in JSON facets
* Both stdDev and variance uses corrected sample formula to compute
  the values. This is similar to StatsComponent
2020-03-19 19:21:57 +05:30
David Smiley
4fd96bedc2
SOLR-14256: replaced EMPTY with empty() to fix deadlock 2020-03-18 08:31:29 -04:00
Munendra S N
7f37a55a8c SOLR-13944: remove redundant checks in SpellCheckCollator
* After SOLR-14073, these checks become redundant and add
  additional tests for spellcheck with collapse
2020-03-18 10:51:50 +05:30
Munendra S N
0b063fd2b7 SOLR-10157: improve error message in case of unknown aggregations 2020-03-18 10:46:57 +05:30
Munendra S N
6a59d443bc LUCENE-8908: return def val from objectVal when exists returns false
* This behavior is similar to floatVal in QueryValueSource
2020-03-18 10:41:13 +05:30
Munendra S N
2b327e5deb SOLR-13199: Fix NPE in ChildDocTransformer when parenFilter is invalid
* Return proper error message and error code
2020-03-18 10:32:28 +05:30
ameliahenderson
fda935482b
SOLR-8306: Optimize expand.rows=0 to compute only total hits (#1334)
* When expand.rows=0, expand documents are not returned. So, computing them could be avoided and only total hits need to be computed
2020-03-18 09:23:04 +05:30
Mike Drob
adb829cf35 [logging] log actual size of transient core cache 2020-03-13 15:45:52 -05:00