Commit Graph

1264 Commits

Author SHA1 Message Date
Alessandro Benedetti 0671ef5e5f SOLR-15149: messages expected in tests fixed 2021-02-16 19:30:23 +01:00
Eric Pugh e6d9eaaf00
SOLR-15121: Move XSLT (tr param) response writer and update request handler to scripting contrib (#2306)
* relocate xslt related classes into scripting contrib
* relocating files to scripting and seperating out unit tests
* relocate files under test-files/scripting/solr, similar to how we do it in other contribs.  deals with some issues in finding files
* Reformatting using the Google Java Format...
* use actual param name, not the variable to properly test api!
* Clean up references to paths, and deal with the mish mash of Xslt and XSLT in class names.
* Move XSLT processing out of XMLLoader
* Move TransformerProvider.Dedupe getTransformer logic.


Co-authored-by: epugh@opensourceconnections.com <>
Co-authored-by: David Smiley <dsmiley@apache.org>
2021-02-15 13:16:18 -05:00
Alessandro Benedetti 227ef3b397
SOLR-15149: model creation errors fixes (#2350)
SOLR-15149: model loading errors fix + tests
2021-02-15 18:02:25 +01:00
András Salamon e8bc758144
SOLR-15115: Remove unused methods from TestRerankBase (#2261) 2021-02-01 17:31:58 +00:00
cammiemw 9cc5c9b798
LUCENE-9537: Add initial Indri search engine functionality to Lucene 2021-01-29 14:47:24 -05:00
Eric Pugh 6d71a0aced
SOLR-14067: v4 Create /contrib/scripting module with ScriptingUpdateProcessor (#2257)
* Creating Scripting contrib module to centralize the less secure code related to scripts.

* tweak the changelog and update notice to explain why the name changed and the security posture thinking

* the test script happens to be a currency.xml, which made me think we were doing something specific to currency types, but instead any xml formatted file will suffice for the test.

* Update solr/contrib/scripting/src/java/org/apache/solr/scripting/update/ScriptUpdateProcessorFactory.java

* Update solr/contrib/scripting/src/java/org/apache/solr/scripting/update/package-info.java

* drop the ing, and be more specific on the name of the ref guide page

* comment out the script update chain.

The sample techproducts configSet is used by many of the solr unit tests, and by default doesn't have access to the jar file in the contrib module.   This is commented out, similar to how the lang contrib is.

* using a Mock for the script processor in order to keep the trusted configSets tests all together.

* tweak since we are using a mock script processor

Co-authored-by: David Smiley <dsmiley@apache.org>
2021-01-29 12:27:36 -05:00
Tim Dillon a7a434dbc4
SOLR-15025: MiniSolrCloudCluster.waitForAllNodes ignores passed timeout value (#2193)
* Change timeout values to seconds
2021-01-29 11:22:06 -06:00
epugh@opensourceconnections.com ce1bba6d66 Revert "SOLR-14067: v3 Create /contrib/scripting module with ScriptingUpdateProcessor (#2215)"
This reverts commit cf5db8d651.
2021-01-25 09:53:36 -05:00
Christine Poerschke 32e95ddb3f
SOLR-15071: Fix ArrayIndexOutOfBoundsException in contrib/ltr SolrFeatureScorer (#2196) 2021-01-22 13:34:58 +00:00
Eric Pugh cf5db8d651
SOLR-14067: v3 Create /contrib/scripting module with ScriptingUpdateProcessor (#2215)
* Creating Scripting contrib module to centralize the less secure code related to scripts.

* tweak the changelog and update notice to explain why the name changed and the security posture thinking

* the test script happens to be a currency.xml, which made me think we were doing something specific to currency types, but instead any xml formatted file will suffice for the test.

* drop the ing, and be more specific on the name of the ref guide page

* use the same name everywhere

Co-authored-by: David Smiley <dsmiley@apache.org>
2021-01-21 13:32:46 -05:00
Florin Babes f285f02c89
SOLR-15071: add TestEdisMaxSolrFeature.testEdisMaxSolrFeatureCustomMM() test case (#2201)
* add test case for SOLR-15071

* add temporary @Ignore to be removed when the fix is committed

Co-authored-by: Florin Babes <florin.babes@emag.ro>
Co-authored-by: Christine Poerschke <cpoerschke@apache.org>
2021-01-14 10:44:26 +00:00
Timothy Potter 8b55fb868d
SOLR-15059: Improve query performance monitoring (#2165) 2021-01-07 09:17:38 -07:00
David Smiley 21b8890f58
SOLR: Remove CHANGES.md; use solr/CHANGES.txt
For now, any way.  See dev list discussion.
2020-12-04 17:59:07 -05:00
saatchibhalla 19ed903377
SOLR-14965: add overseer queue size metrics (#2040)
Adds two metrics to the SolrCloud Overseer: solr_metrics_overseer_stateUpdateQueueSize and solr_metrics_overseer_collectionWorkQueueSize with corresponding entries in the the Prometheus exporter's default/stock configuration.

Co-authored-by: Saatchi Bhalla <s.bhalla@salesforce.com>
2020-12-04 16:47:35 -05:00
Chris Hostetter 2e6a02394e SOLR-14934: Refactored duplicate "Solr Home" logic into a single place to eliminate risk of tests using divergent values for a single solr node. 2020-12-02 10:24:36 -07:00
David Smiley 021de9f45f
SOLR-14915: Prometheus-exporter should not depend on Solr-core (#1972)
* Reduced dependencies from Solr server down to just SolrJ.  Don't add WEB-INF/lib.
* Was missing some dependencies in lib/; now has all except SolrJ & logging.
* Can run via gradle, "gradlew run"
* Has own log4j2.xml now

Has own CHANGES.md now.
2020-11-27 15:08:33 -05:00
Alessandro Benedetti ca040402d9 SOLR-15015: added support to parametric Interleaving algorithm (#2096) 2020-11-24 10:14:38 +00:00
Alessandro Benedetti af0455ac83
SOLR-14560: Interleaving for Learning To Rank (#1571)
SOLR-14560: Add interleaving support in Learning To Rank
2020-11-18 18:15:24 +00:00
Dawid Weiss 0f871b2c56
SOLR-14926: Modernize and clean up search results clustering contrib. 2020-11-03 09:31:53 +01:00
Jan Høydahl 0c3f2f4ac8
SOLR-14972: Change default port of prometheus exporter to 8989 (#2046) 2020-11-02 14:06:34 +01:00
Houston Putman e1698bda95
SOLR-14955: Add env var options to Prometheus Export scripts. (#2038) 2020-10-30 11:15:33 -04:00
Houston Putman 4fe4f37131
SOLR-14957: Add Prometheus Exporter to docker PATH. Fix classpath issues. (#2017) 2020-10-26 14:15:30 -04:00
Jan Høydahl 3bc873e6d4
SOLR-14936: Fixed Grafana dashboard filters for collection, shard, replica and core (#1986) 2020-10-19 14:49:02 +02:00
Christine Poerschke 6e2572882f Fix 'an[d]' typo in three solrconfig.xml comments. 2020-10-19 12:54:37 +01:00
Andrzej Bialecki 2a3da99e2d SOLR-14914: Add option to disable metrics collection. 2020-10-15 10:14:16 +02:00
David Smiley ab83b3b7c3
SOLR-14917: Move DOMUtil and PropertiesUtil to SolrJ (#1953) 2020-10-10 08:52:10 -04:00
Tomoko Uchida b70eaeee5a
LUCENE-9558: Clean up package name conflicts for analyzers-icu. (#1946) 2020-10-05 17:52:23 +09:00
Timothy Potter e879a52291
SOLR-14659: Remove restlet as dependency for the ManagedResource API (#1938)
Co-authored-by: noblepaul <noble.paul@gmail.com>
2020-10-04 11:21:49 -06:00
Erick Erickson f6c4f8a755 SOLR-14910: Use in-line tags for logger declarations in Gradle ValidateLogCalls that are non-standard, change //logok to //nowarn 2020-10-03 09:47:37 -04:00
Tomoko Uchida 5e617ccc33
LUCENE-9317: Clean up split package in analyzers-common (#1836) 2020-09-28 16:49:28 +09:00
Erik Hatcher 2364a7aded SOLR-14792: Remove VelocityResponseWriter 2020-09-17 08:45:13 -04:00
Robert Muir 784ede4eda
LUCENE-9215: replace checkJavaDocs.py with doclet (#1802)
This has the same logic as the previous python, but no longer relies
upon parsing HTML output, instead using java's doclet processor.

The errors are reported like "normal" javadoc errors with source file
name and line number and happen when running "gradlew javadoc"

Although the "rules" are the same as the previous python, the python had
some bugs where the checker didn't quite do exactly what we wanted, so
some fixes were applied throughout.

Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
Co-authored-by: Uwe Schindler <uschindler@apache.org>
2020-09-02 08:29:17 -04:00
epugh aab9331c5e fix links to JavaDocs 2020-09-01 13:36:23 -04:00
Dawid Weiss 4a2a2da462 LUCENE-9435: revert Solr's packaging stuff for now. 2020-08-31 14:55:59 +02:00
Dawid Weiss def82ab556
LUCENE-9435: Clean up ant compatability remnants in Gradle build
* Removing ant-only unused tasks.
* Correct message in TestVersion.java
* Remove unused file.
* Removing forbidden API rules for ant.
* Remove 'resolve' emulation.
* Move ecj-lint to task-definition-relative folder.
* Remove 'packaging' specification. It'll have to wait until proper new packaging is implemented for Solr distribution.
* Move render-javadoc tasks's files to task-relative location.
* Moved security manager policies and default JDK logging file to gradle's task relative locations.
* Removing obsolete ant tools. Moving check source patterns under gradle's folder.
* Correct paths.
* Correct property name in task selector.
2020-08-30 14:01:04 +02:00
Alexandre Rafalovitch a57ba25400
SOLR-14783: Remove DIH from 9.0 (#1794)
* Remove DIH example directory

* Remove contrib code directories

* Remove contrib package related configurations for build tools

* Remove mention of DIH example

* remove dih as build dependencies and no-longer needed version pins

* Remove README references to DIH

* Remove dih mention from the script that probably does need to exist at all

* More build artifact references

* More removed dependencies leftovers (licenses/versions)

* No need to smoke exclude DIH anymore

* Remove Admin UI's DIH integration

* Remove DIH from shortname package list

* Remove unused DIH (related? not?) dataset
Unclear what is happening here, but there is no reference to that directory anywhere else
The other parallel directories ARE referenced in a TestConfigSetsAPI.java

* Hidden Idea files references

* No DIH to ignore anymore

* Remove last Derby DB references

* Remove DIH from documentation
Add the information in Major Changes document with the link to the external repo

* Added/updated a mention to CHANGES

* Fix leftover library mentions

* Fix Spellings
2020-08-29 10:52:04 -04:00
Erick Erickson 69fa5a00fb LUCENE-9433: Remove Ant support from trunk 2020-08-28 09:31:16 -04:00
Erick Erickson c9c75810c2 Revert "LUCENE-9433: Remove Ant support from trunk"
This reverts commit 37cd17dc
2020-08-21 16:57:58 -04:00
Erick Erickson 37cd17dcf5 LUCENE-9433: Remove Ant support from trunk 2020-08-21 15:19:52 -04:00
David Smiley 0ce2d610c2
SOLR-14722: timeAllowed should track from req creation (#1726)
* set(long) instead of set(Long).
* Fix javadocs CommonParams.TIME_ALLOWED
2020-08-15 00:41:07 -04:00
David Smiley e6a11f8c3a
SOLR prometheus: simplify concurrent collection (#1723)
No semantic difference in behavior.
2020-08-14 15:59:40 -04:00
Jason Gerlowski 216aec03a6
SOLR-14677: Always close DIH EntityProcessor/DataSource (#1741)
Prior to this commit, the wrapup logic at the end of
DocBuilder.execute() closed out a series of DIH objects, but did so
in a way that an exception closing any of them resulted in the remainder
staying open.  This is especially problematic since Writer.close()
throws exceptions that DIH uses to determine the success/failure of the
run.

In practice this caused network errors sending DIH data to other Solr
nodes to result in leaked JDBC connections.

This commit changes DocBuilder's termination logic to handle exceptions
more gracefully, ensuring that errors closing a DIHWriter (for example)
don't prevent the closure of entity-processor and DataSource objects.
2020-08-13 21:21:31 -04:00
Marcus 7110118ad4
SOLR-14702: Remove oppressive language (part1) (#1711)
Replace references to "master" and "slave" with "leader" and "follower"
2020-08-05 14:52:48 -07:00
Erick Erickson c346881ad6 SOLR-13939: https://issues.apache.org/jira/browse/SOLR-13939 2020-07-12 22:41:08 -04:00
Andrzej Bialecki cf742f4596 SOLR-12847: Remove support for maxShardsPerNode. 2020-07-08 17:57:24 +02:00
Ishan Chattopadhyaya dd6d1c90c8 SOLR-14066: Deprecate DIH 2020-07-02 16:38:31 +05:30
Erick Erickson d0864a19c7 SOLR-14523: Enhance gradle logging calls validation: eliminate getMessage() 2020-07-01 22:07:59 -04:00
Atri Sharma 529faf1241 Revert "SOLR-14588: Implement Circuit Breakers (#1606)"
This reverts commit 7b54902f68.
2020-06-27 23:44:32 +05:30
Christine Poerschke 68a9e8fc97 SOLR-14376: remove no-longer-needed 'not no filter queries' check in SolrFeatureWeight 2020-06-26 18:12:33 +01:00
Atri Sharma 7b54902f68
SOLR-14588: Implement Circuit Breakers (#1606)
* SOLR-14588: Implement Circuit Breakers

This commit consists of two parts: initial circuit breakers infrastructure and real JVM memory based
circuit breaker which monitors incoming search requests and rejects them with SERVICE_TOO_BUSY error
if the defined threshold is breached, thus giving headroom to existing indexing and search requests
to complete.
2020-06-25 21:06:22 +05:30