Commit Graph

37413 Commits

Author SHA1 Message Date
Uwe Schindler f6d0834639 fix typo in older changes entry 2024-03-28 10:39:34 +01:00
Uwe Schindler 376ec27a51 #13206: Move changes entry to 9.11 2024-03-28 10:37:45 +01:00
Jean-François BOEUF 3917d22591
Subtract deleted file size from the cache size of NRTCachingDirectory. (#13206) 2024-03-28 10:34:46 +01:00
Robert Muir ad8545151d
upgrade snowball to 34f3612e5e8c (round two) (#13227)
* upgrade snowball to 34f3612e5e8c (round two)

* disable forbidden-apis on snowball code (thanks @uschindler)
2024-03-27 17:51:48 -04:00
Adrien Grand 96c0c3082a
Clean up variable-gaps terms format. (#13216)
The variable-gaps terms format uses the legacy storage layout of storing
metadata at the end of the index file, and storing the start pointer of the
metadata as the last 8 bytes of the index files (just before the footer). This
forces an awkward access pattern at open time when we first need to seek
towards the end to check that a footer is present, then seek some more bytes
backwards to read metadata, and finally read the content of the index that sits
before metadata.

To fix this, meta data and index data are now split into different files. This
way, both files have a clean sequential and read-once access pattern, and can
take advantage of the `ChecksumIndexInput` abstraction for checksum validation.

This further helps clean up `IOContext` by removing the ability to set
`readOnce` to `true` on an existing `IOContext`.
2024-03-27 18:16:30 +01:00
Robert Muir d54663ad76
upgrade snowball to 26db1ab9adbf437f37a6facd3ee2aad1da9eba03 (#13209)
* upgrade snowball to 26db1ab9adbf437f37a6facd3ee2aad1da9eba03

* add back-compat-hack to the factory, too

* remove open of irish package now that we don't have our own stopwords file here anymore

* CHANGES / MIGRATE
2024-03-27 10:05:57 -04:00
Adrien Grand 8558934501
Replace boolean flags on `IOContext` with an enum. (#13219)
This replaces the `load`, `randomAccess` and `readOnce` flags with a
`ReadAdvice` enum, whose values are aligned with the allowed values to
(f|m)advise.

Closes #13211
2024-03-27 09:13:41 +01:00
Zhang Chao 1f909baca5
Speed up writeGroupVInts (#13203)
* Speed up writeGroupVInts
2024-03-26 22:48:30 +08:00
Uwe Schindler 26f5065e15
Add support for Github issue numbers in Markdown converter (e.g., MIGRATE.md file) (#13215) 2024-03-26 13:45:56 +01:00
gf2121 99b9636fd8
Break point estimation when threshold exceeded (#13199) 2024-03-26 19:29:34 +08:00
Uwe Schindler 8c4ec1dbef
Convert IOContext, MergeInfo, and FlushInfo to record classes (#13205) 2024-03-26 12:27:51 +01:00
Chris Hegarty 209aa05c0c
Avoid creating large buffer in TestMMapDirectory.testWithRandom (#13214)
This commit avoids creating an unnecessary large buffer in TestMMapDirectory.testWithRandom.
2024-03-26 10:35:17 +00:00
Uwe Schindler 9fffc6e54c #13196, #13213: Remove logging relic from main branch 2024-03-26 10:09:29 +01:00
Uwe Schindler 61e5da3fe4 #13196, #13213: Fix test on windows to close file so it can be deleted after test run 2024-03-25 20:37:59 +01:00
Uwe Schindler a4055dae62
Add support for posix_madvise to Java 21 MMapDirectory (#13196) 2024-03-25 18:44:33 +01:00
Nhat Nguyen f4db67fae2
Avoid modify merge state in per field mergers (#13208)
The PerFieldDocValuesFormat and PerFieldPostingsFormat mutate and reset 
the fieldInfos of the mergeState during merges. Consequently, other 
running merge sub-tasks may fail to see some fieldInfos. This was
problematic since we introduced concurrency for merge sub-tasks.

Relates #13190
2024-03-25 08:56:41 -07:00
Tim Grein d5ef6edf7f
Only check the knn specific options, if a vector dictionary source was provided. (#13163) 2024-03-25 10:25:50 -04:00
Uwe Schindler 04f335ad79 Upgrade forbiddenapis to version 3.7 and ASM for APIJAR extraction to 9.7 2024-03-24 00:09:24 +01:00
Uwe Schindler 00073c4c1a
Fix equals/hashcode of IOContext (#13204) 2024-03-23 12:03:27 +01:00
Benjamin Trent 75e1ebc450
Add new parallel merge task executor for parallel actions within a single merge action (#13190)
This commit adds a new interface to all MergeScheduler classes that allows the scheduler to provide an Executor for intra-merge parallelism. The first sub-class to satisfy this new interface is the ConcurrentMergeScheduler (CMS). In particular, the CMS will limit the amount of parallelism based on the current number of mergeThreads and the configured maxThread options. 

Parallelism is now added by default to the SegmentMerger where each merging task is executed in parallel with the others. 

Additionally, the Lucene99 HNSW codec will use the provided MergeScheduler executor if no executor is provided directly.

Relates to: https://github.com/apache/lucene/issues/12740
Relates to: https://github.com/apache/lucene/issues/9626

This is a take 2 of: https://github.com/apache/lucene/pull/13124
2024-03-21 09:11:00 -04:00
Benjamin Trent d5f8853fda
Fix NPE for when fields are missing in `searchNearestVectors` (#13195)
Related to: https://github.com/apache/lucene/pull/13162

Since this is unreleased, no changelog entry is necessary.
2024-03-20 11:49:30 -04:00
Shintaro Murakami c78533c53c
Support getMaxScore of DisjunctionSumScorer for non top level scoring clause (#13066) 2024-03-20 10:37:48 +01:00
panguixin 7a08eeab47
Make the HitQueue size more appropriate for KNN exact search (#13184)
Currently, when performing KNN exact search, we consistently set the HitQueue size to k. However, there may be instances where the number of candidates is actually lower than k.
2024-03-19 12:24:36 -04:00
Dai Sugimori d393b9d039
Add new token filters for Japanese sutegana (捨て仮名) (#12915)
### Description

Sutegana (捨て仮名) is small letter of hiragana and katakana in Japanese. In the old Japanese text, sutegana (捨て仮名) is not used unlikely to modern one. For example:

- "ストップウォッチ" is written as "ストツプウオツチ"
- "ちょっとまって" is written as "ちよつとまつて"

So it's meaningful to normalize sutegana to normal (uppercase) characters if we search against the corpus which includes old Japanese text such as patents, legal documents, contract policies, etc.

This pull request introduces 2 token filters:

- JapaneseHiraganaUppercaseFilter for hiragana
- JapaneseKatakanaUppercaseFilter for katakana

so that user can use either one separately. Each. filter make all the sutegana (small characters) into normal kana (uppercase character) to normalize the token.

### Why it is needed

This transformation must be done as token filter. There have already been [MappingCharFilter](https://lucene.apache.org/core/8_0_0/analyzers-common/org/apache/lucene/analysis/charfilter/MappingCharFilter.html), but if we apply this character filter to normalize sutegana, it will impact to tokenization and it is not expected.
2024-03-18 08:50:36 -04:00
Benjamin Trent 5b48474286
Revert "Add new parallel merge task executor for parallel actions within a si…" (#13189)
This reverts commit e3a34bfe56.
2024-03-18 08:31:42 -04:00
Zhang Chao 9fd0474251
Remove the unnecessary grow before append. (#13168) 2024-03-16 17:33:18 +08:00
Zhang Chao 6ee19c022c
Introduce IORunnable to fix test failure TestIndexWriterOnDiskFull.testAddIndexOnDiskFull (#13172) 2024-03-16 08:38:53 +08:00
Benjamin Trent e3a34bfe56
Add new parallel merge task executor for parallel actions within a single merge action (#13124)
This commit adds a new interface to all MergeScheduler classes that allows the scheduler to provide an Executor for intra-merge parallelism. The first sub-class to satisfy this new interface is the ConcurrentMergeScheduler (CMS). In particular, the CMS will limit the amount of parallelism based on the current number of mergeThreads and the configured maxThread options. 

Parallelism is now added by default to the SegmentMerger where each merging task is executed in parallel with the others. 

Additionally, the Lucene99 HNSW codec will use the provided MergeScheduler executor if no executor is provided directly.

Relates to: https://github.com/apache/lucene/issues/12740
Relates to: https://github.com/apache/lucene/issues/9626
2024-03-14 15:58:41 -04:00
Adrien Grand 3ad73336ae
Make BP work on indexes that have blocks. (#13125)
The current logic for reordering splits a slice of doc IDs into a left side and
a right side, and for each document it computes the expected gain of moving to
the other side. Then it swaps documents from both sides as long as the sum of
the gain of moving the left doc to the right and the right doc to the left is
positive.

This works well, but I would like to extend BP reordering to also work with
blocks, and the swapping logic is challenging to modify as two parent documents
may have different numbers of children.

One of the follow-up papers on BP suggested to use a different logic, where one
would compute a bias for all documents that is negative when a document is
attracted to the left and positive otherwise. Then we only have to partition doc
IDs around the mid point, e.g. with quickselect.

A benefit of this change is that it will make it easier to generalize BP
reordering to indexes that have blocks, e.g. by using a stable sort on biases.
2024-03-13 10:14:14 +01:00
Dawid Weiss d5ade0d30f
Remove halt() call in TestSimpleServer (part of TestStressNRTReplication (#13177) 2024-03-13 09:03:34 +01:00
Benjamin Trent b527e101e7
Fix potential race condition in DocumentsWriter & DocumentsWriterDeleteQueue (#13169)
* Fix potential race condition in DocumentsWriter & DocumentsWriterDeleteQueue

* add changes
2024-03-12 07:50:04 -04:00
Tim Grein 44fa35b65f
Adjust middle of sentence calculation and add test verifying correct behavior (#13170) 2024-03-11 13:21:22 +01:00
Tim Grein 3f4413567d
Fix TestFloatVectorSimilarityQuery.testBoostQuery (#13176)
### Description

The boosted doc scores were the same due to floating point precision limitations, when multiplying the original scores with tiny differences with a fairly large multiplier.

My change removes the assertion expecting the exact order to be the same (AFAIU this won't be possible for every scores/boost configurations due to precision limitations), but rather asserts that the `original doc score * boost factor` and the `boosted doc score` are equals within a certain delta.

Closes https://github.com/apache/lucene/issues/13173.
2024-03-11 08:08:29 -04:00
panguixin 5b5815a26d
Fix NPE when LeafReader return null VectorValues (#13162)
### Description
`LeafReader#getXXXVectorValues` may return null value.

**Reproduction**:
```
public class TestKnnByteVectorQuery extends BaseKnnVectorQueryTestCase {
  public void testVectorEncodingMismatch() throws IOException {
    try (Directory indexStore =
        getIndexStore("field", new float[] {0, 1}, new float[] {1, 2}, new float[] {0, 0});
        IndexReader reader = DirectoryReader.open(indexStore)) {
      AbstractKnnVectorQuery query =
          new KnnFloatVectorQuery("field", new float[] {0, 1}, 10);
      IndexSearcher searcher = newSearcher(reader);
      searcher.search(query, 10);
    }
  }
}
```
**Output**:
```
java.lang.NullPointerException: Cannot invoke "org.apache.lucene.index.FloatVectorValues.size()" because the return value of "org.apache.lucene.index.LeafReader.getFloatVectorValues(String)" is null
```
2024-03-11 08:07:04 -04:00
zhouhui 6445bc0a14
Rename TestWildcard to TestWildcardQuery. (#13159) 2024-03-08 09:26:44 -05:00
Dawid Weiss 1c77e2315c
An eye-gouging way to limit suppressAccessChecks to just the three JARs that need them. (#13164) 2024-03-08 08:10:49 +01:00
Tim Grein 49db29e59f
Check whether document exists without relying on the id (#13160) 2024-03-06 05:50:59 -05:00
Benjamin Trent 012b959b05
Add mult-leaf optimizations for diversify children collector (#13121)
This adds multi-leaf optimizations for diversified children collector. This means as children vectors are collected within a block join, we can share information between leaves to speed up vector search.

To make this happen, I refactored the multi-leaf collector slightly. Now, instead of inheriting from TopKnnCollector, we inject a inner collector.
2024-03-05 09:02:49 -05:00
Peter Gromov 51122f8b2e
Hunspell: don't proceed with other suggestions if we found good REP ones (#13156)
* Hunspell: don't proceed with other suggestions if we found good REP ones

This makes "rep" and "ph" from TestHunspellRepositoryTestCases pass on latest revisions of the original Hunspell (after b88f9ea57b)
2024-03-05 14:12:01 +01:00
Peter Gromov 44d48df4b7
hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings (#13155)
hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings
2024-03-05 09:54:20 +01:00
Peter Gromov 193cc62c73
hunspell GeneratingSuggester: ensure there are never more than 100 roots to process (#13154)
hunspell GeneratingSuggester: ensure there are never more than 100 roots to process
2024-03-05 09:53:27 +01:00
guojialiang92 47792dfcd3
Fix DV update files referenced by merge will be deleted by concurrent flush (#13017) 2024-03-04 11:18:16 +00:00
Dawid Weiss 3ce9ba9fd5 Correct typo #13148 2024-03-01 07:12:57 +01:00
Uwe Schindler 08325ac3e8 Fix successful tests counting not working in Gradle build by adding ReflectPermission back (see ##13146) 2024-03-01 01:25:02 +01:00
Uwe Schindler 6910a4358c
Do not place Panama Java 21 class files in MR-JAR section of core.jar file (#13148) 2024-02-29 23:10:16 +01:00
Uwe Schindler 8ef60b3e72 Add changes entry (#13146) 2024-02-29 19:42:32 +01:00
Uwe Schindler e446904c61
Remove ByteBufferIndexInput and update all Panama implementations (MMap and Vector) to Java 21 (#13146) 2024-02-29 19:38:37 +01:00
Uwe Schindler dfce6ee8d2 Update the Javadoc package list to Java 21 2024-02-29 15:06:47 +01:00
Uwe Schindler 5aaaeaee39 Update link to javadocs for Java 21 2024-02-29 14:37:09 +01:00
Dawid Weiss ba77cd4444 Make run-nightly-smoketester.yml run on java 21+ only 2024-02-29 13:03:42 +01:00