Commit Graph

36506 Commits

Author SHA1 Message Date
Robert Muir d3fe435be6
Invert error-prone configuration to be allow-list vs deny-list (#11970)
This does not change the semantics or performance of our setup.

Instead, it explicitly enables checks that we want vs disabling checks
that we don't want.

Also reordered checks to match the error-prone website list of checks
for easier maintenance.

It is now clear that many useless checks are enabled, we can disable
some of them and try to get the performance reasonable.
2022-11-23 14:53:27 -05:00
Karl David Wright 482f8251ff More work related to 11965: Improve performance of nearestDistance queries somewhat by removing unnecessary code. 2022-11-23 12:21:38 -05:00
Dawid Weiss 326142c485
Add a note about gradle checks being possibly a subset of all validation checks. (#11966) 2022-11-23 12:19:28 +01:00
Adrien Grand 802774641a
Enforce VectorValues.cost() is equal to size(). (#11962)
`VectorValues` have a `cost()` method that reports an approximate number of
documents that have a vector, but also a `size()` method that reports the
accurate number of vectors in the field. Since KNN vectors only support
single-valued fields we should enforce that `cost()` returns the `size()`.
2022-11-23 11:05:00 +01:00
Adrien Grand 469547e909
No longer announce releases on general@l.a.o. (#11967)
This mailing-list is deprecated.
2022-11-23 10:55:58 +01:00
Adrien Grand 20c1ba5d9a
Remove VectorValues#EMPTY. (#11961)
This instance is illegal as it reports a number of dimensions equal to zero.
2022-11-23 10:52:12 +01:00
Adrien Grand 8bdc59ce67 Add back-compat indices for 9.4.2 2022-11-23 10:35:06 +01:00
Dawid Weiss 30873cfcd9 Fix the boxing issue again. 2022-11-23 08:29:12 +01:00
Karl David Wright 5fec8efe4e More tidying to make lint happy 2022-11-22 22:05:55 -05:00
Karl David Wright 49c8a75917 Resolve merge conflicts 2022-11-22 21:29:06 -05:00
Karl David Wright 0593eca73d Fix problem in new Plane code 2022-11-22 21:18:11 -05:00
Karl David Wright fc7ce76851 Refactor and make hierarchical GeoStandardPath. Some tests fail and will need to be researched further. 2022-11-22 21:18:11 -05:00
Karl David Wright 1ded41ea20 Final bugs fixed, except remaining legacy issue with nearest distance in GeoDegeneratePath. 2022-11-22 21:12:44 -05:00
Karl David Wright c9c27c755a Make sure use of aggregation form is consistent throughout, and fix segment endpoint computations of nearestDistance. 2022-11-22 18:43:19 -05:00
Karl David Wright ae5179986c All tests fixed saved two - distance related. 2022-11-22 16:56:34 -05:00
Adrien Grand 7b7cb396e5 Tidy. 2022-11-22 18:57:21 +01:00
Adrien Grand 750e7dba32 Add bugfix version 9.4.2 2022-11-22 18:56:30 +01:00
Karl David Wright 799421abba Fix nearestDistance for real this time 2022-11-22 12:55:18 -05:00
Peter Gromov 2ae8dd632e
hunspell: support empty dictionaries, adapt to the hunspell/C++ repo changes (#11960)
hunspell: support empty dictionaries, adapt to the hunspell/C++ repo changes
2022-11-22 18:23:45 +01:00
Adrien Grand 0e0a20d88e DOAP changes for release 9.4.2 2022-11-22 15:18:29 +01:00
Mike McCandless ad04ac1bc4 tidy up 2022-11-22 08:20:30 -05:00
Mike McCandless 4bd4f8b521 remove unused imports 2022-11-22 08:18:41 -05:00
Mike McCandless acbc08fb32 expand wildcard imports 2022-11-22 08:03:54 -05:00
Mike McCandless 521c0e24f2 #10878: revert #02528c6757d10420cc7d545282b49c4322943ac7 (add some test verbosity on failure (#11935)) 2022-11-22 07:59:08 -05:00
Stefan Vodita 369a70f289
Support deletions in rearrange (#11815)
* Support deletions in rearrange 
* Store BinaryDocValues in the binary doc value selector as ByteRef
   instead of String.
2022-11-21 23:52:38 -08:00
Dawid Weiss af28352d31 Create proper relative upload path for maven artifacts, check for sanity of groupId and relative path #11329 2022-11-22 08:16:16 +01:00
Karl David Wright 5d341e9d8c Cleanup StandardGeoPath to get rid of unused member arrays 2022-11-21 20:36:25 -05:00
Karl David Wright ecf4396ef7 Remove a dated test 2022-11-21 20:01:30 -05:00
Karl David Wright d85c35e4d7 Fix problem in new Plane code 2022-11-21 19:15:10 -05:00
Karl David Wright 20fcd0b757 Refactor and make hierarchical GeoStandardPath. Some tests fail and will need to be researched further. 2022-11-21 18:39:50 -05:00
Dawid Weiss fa0031bde5
jgit shouldn't fork git to find out the config dir (#11959)
* Windows part.

* jgit shouldn't fork git to find out the config dir (posix)

Co-authored-by: Robert Muir <rmuir@apache.org>
2022-11-21 17:48:57 +01:00
Alan Woodward 332679886c
Add field as a separate input to newSynonymQuery (#11941)
QueryBuilder#newSynonymQuery takes an array of TermAndBoost objects as a
parameter and uses the field of the first term in the array as its field. However,
there are cases where this array may be empty, which will result in an
ArrayOutOfBoundsException.

This commit reworks QueryBuilder so that TermAndBoost contains plain
BytesRefs, and passes the field as a separate parameter. This guards against
accidental calls to newSynonymQuery with an empty list - in this case, an
empty synonym query is generated rather than an exception. It also
refactors SynonymQuery itself to hold BytesRefs rather than Terms, which
needlessly repeat the field for each entry.

Fixes #11864
2022-11-21 09:55:14 +00:00
Karl David Wright cd82a9bbdc Revert the change the relies on accurate bounds from path components. This caused randomized test failures, and fixing the bounds caused other (inexplicable) test failures. More research needed. 2022-11-20 10:32:14 -05:00
Robert Muir 8fdac2d88e
fixed boxed equality check to unbreak the build: has this code been tested???? 2022-11-19 23:11:30 -05:00
Karl David Wright 1e236090af Fix up formatting 2022-11-19 17:56:10 -05:00
Karl David Wright 9bca7a70e1 Fix longstanding bug in path bounds calculation, and hook up efficient isWithin() and distance logic 2022-11-19 17:56:09 -05:00
Karl David Wright fbdb655221 Add node structures and fast operations for them. 2022-11-19 17:56:08 -05:00
Robert Muir 62f2b42502
Prevent TestStressIndexing from taking minutes for normal non-NIGHTLY runs (#11953)
This test intentionally does a ton of filesystem operations: currently
about 20% of the time you can get really unlucky and get virus checker
simulated, against a real filesystem, which makes things really slow.

Instead use a ByteBuffersDirectory for local runs so that it doesn't
take minutes. The test can still be pretty slow even with this
implementation, so tone down the runtime so that it takes ~ 1.5s
locally.
2022-11-19 18:06:52 -05:00
Dawid Weiss 3f6410b738
Implement source code regeneration for test-framework perl scripts (#11952) 2022-11-19 23:40:45 +01:00
Dawid Weiss e78210b7f0
Add self-contained artifact upload script for apache nexus (#11329) (#11947) 2022-11-18 18:58:06 +01:00
Karl David Wright 718ae33e21 Merge branch 'main' of https://gitbox.apache.org/repos/asf/lucene into main 2022-11-18 02:04:54 -05:00
Dawid Weiss 82e57d1d6b Remove obsolete badapples tests switch (#468) 2022-11-18 16:57:24 +01:00
Robert Muir 99aa6dd0eb
Lower gradle heap: 3GB is unnecessary (#11936) 2022-11-18 10:55:32 -05:00
Dawid Weiss 2f21a866c1
Add star import check/validation (#11949)
* Remove some old cruft that only slows down checks. Add star import check
* Expand wildcard imports to comply with the rule.
2022-11-18 16:42:59 +01:00
Karl David Wright 492a25a2a2 Fix formatting 2022-11-18 01:41:53 -05:00
Karl David Wright f3b4b057fa Refactor, in preparation for using b-trees to enhance performance. 2022-11-18 00:32:52 -05:00
Jack Conradson a18b62ded4
Decrease test time for TestManyKnnDocs.testLargeSegment (#11945)
* Improve speed of TestManyKnnDocs
2022-11-16 23:52:32 -05:00
Karl David Wright b6ebfd1861 Prevent NPEs while still handling the polar case for horizontal planes right off the pole 2022-11-16 11:03:24 -05:00
Mao Suhan 3c5bcb383b
fix bug of incorrect cost after upgradeToBitSet in DocIdSetBuilder class (#11939) 2022-11-16 17:04:15 +01:00
Robert Muir c5da727493
fix overflows in compound assignments (#11938)
* Count points as longs.

* Simplify KnnVectorsWriter.

Co-authored-by: Adrien Grand <jpountz@gmail.com>
2022-11-16 10:53:34 -05:00