Commit Graph

34108 Commits

Author SHA1 Message Date
Simon Willnauer 5fcb859ece
Ensure we only rollback IW once (#1764)
Ensure we only rollback IW once

Today we might rollback IW more than once if we hit an exception during
the rollback code when we shutdown. This change moves the rollback code outside
the try block to ensure we always roll back but never roll back twice.
2020-08-20 08:40:25 +02:00
Noble Paul 8caf57d50b
SOLR-14750: TestBulkSchemaConcurrent fails often(#1760) 2020-08-19 10:52:12 +10:00
Christine Poerschke 16ab243759 Fix Zo[o]keeper typo in 'solr zk' usage description. 2020-08-18 16:41:35 +01:00
Ishan Chattopadhyaya 77a4d495cc SOLR-14731: Rename @SolrSingleThreaded to @SolrThreadUnsafe, mark DistribPackageStore with the annotation
Co-authored-by: Marcus <marcuseagan@gmail.com>
2020-08-18 16:21:38 +05:30
Atri Sharma 4fed9ff8d3 Move TestRequestRateLimiter to Nightly 2020-08-18 13:43:49 +05:30
Dawid Weiss 83ed210fd0
LUCENE-9465: 'beast' task from within gradle (#1757) 2020-08-18 09:28:50 +02:00
Simon Willnauer 70c72ff4b9 LUCENE-9467: Fix NRTCachingDirectory to use Directory#fileLength
to check if a file already exists instead of opening an IndexInput
on the file which might throw a AccessDeniedException in some Directory implementations.
2020-08-17 18:32:47 +02:00
Andrzej Bialecki d9fb14dec1 SOLR-13858: Remove no longer used field and getter. 2020-08-17 14:47:38 +02:00
David Smiley 0ce2d610c2
SOLR-14722: timeAllowed should track from req creation (#1726)
* set(long) instead of set(Long).
* Fix javadocs CommonParams.TIME_ALLOWED
2020-08-15 00:41:07 -04:00
Jason Gerlowski 9de454d414 SOLR-14680: Add missing package-info to fix precommit 2020-08-15 09:53:26 +10:00
Houston Putman 6fced2e1e1 Add back-compat indices for 8.6.1 2020-08-14 16:58:43 -04:00
Houston Putman c7b70267b8 Sync CHANGES for 8.6.1 2020-08-14 16:44:56 -04:00
Houston Putman 58a6f956d0 Add bugfix version 8.6.1 2020-08-14 16:35:46 -04:00
David Smiley e6a11f8c3a
SOLR prometheus: simplify concurrent collection (#1723)
No semantic difference in behavior.
2020-08-14 15:59:40 -04:00
Houston Putman ec1c5cfffe DOAP changes for release 8.6.1 2020-08-14 14:44:00 -04:00
Yuriy Koval 44c4e6ef31
SOLR-14703 Edismax parser replaces whitespace characters with spaces (#1713) 2020-08-14 14:12:53 -04:00
Simon Willnauer 4267734e80
Ensure DWPTPool never release any new DWPT after it's closed (#1751)
The DWPTPool should not release new DPWTs after it's closed. Yet, if the pool
is in a state where it's preventing new writers from being created in order to swap
the delete queue it might get closed and in that case we miss to throw an AlreadyClosedException
and release a new writer which violates the condition that the pool is empty after it's closed
and all remaining DWPTs have been aborted.
2020-08-14 16:04:58 +02:00
Dawid Weiss 150a8dacb5
LUCENE-9463: Query match region retrieval component, passage scoring and formatting (#1750)
Reviewed as part of previous issue by @romseygeek
2020-08-14 14:21:12 +02:00
Simon Willnauer a003f64649 Fix TestForTooMuchCloning to ensure it's MP is not reconfigured randomly 2020-08-14 12:14:31 +02:00
Dawid Weiss 6244383e0d
LUCENE-9462: Fields without positions should still return MatchIterator. (#1749) 2020-08-14 11:45:32 +02:00
Jason Gerlowski 216aec03a6
SOLR-14677: Always close DIH EntityProcessor/DataSource (#1741)
Prior to this commit, the wrapup logic at the end of
DocBuilder.execute() closed out a series of DIH objects, but did so
in a way that an exception closing any of them resulted in the remainder
staying open.  This is especially problematic since Writer.close()
throws exceptions that DIH uses to determine the success/failure of the
run.

In practice this caused network errors sending DIH data to other Solr
nodes to result in leaked JDBC connections.

This commit changes DocBuilder's termination logic to handle exceptions
more gracefully, ensuring that errors closing a DIHWriter (for example)
don't prevent the closure of entity-processor and DataSource objects.
2020-08-13 21:21:31 -04:00
Jan Høydahl bed3b8fbfb
SOLR-14751: Zookeeper Admin screen not working for old ZK versions 2020-08-14 01:32:28 +02:00
S N Munendra d2cc022fcf
Fix syntax warning in smokeTestRelease.py (#1746)
while verifying the 8.6.1 release with latest python(3.8.5), observed
one SyntaxWarning.
https://adamj.eu/tech/2020/01/21/why-does-python-3-8-syntaxwarning-for-is-literal/
2020-08-13 21:15:28 +05:30
noblepaul 0b55c94ad6 SOLR-14680: make jdk 8 compatible 2020-08-13 13:53:05 +10:00
Noble Paul d517361bb1
SOLR-14680: Provide an implementation for the new SolrCluster API (#1730) 2020-08-13 13:34:24 +10:00
Jason Gerlowski a6515ca38f SOLR-14748: Correct condition on startup auth/ssl logging 2020-08-12 18:44:02 -04:00
andywebb1975 e72a0d66c6
SOLR-13751: add BooleanSimilarityFactory (#867) 2020-08-12 15:35:50 +01:00
Dawid Weiss 3579056249
Standalone distribution assembly and 'run' task for Luke (#1742)
Co-authored-by: Tomoko Uchida <tomoko.uchida.1111@gmail.com>
2020-08-12 16:28:48 +02:00
Andrzej Bialecki a5543dfb51 SOLR-14470: Fix test failures by reducing the randomness of test data. 2020-08-12 13:45:25 +02:00
Atri Sharma 1d2749295b
Harden RequestRateLimiter Tests (#1736)
* Harden RequestRateLimiter Tests

This commit adds higher data size and load in the test path. Also improves
the asserts that are performed.
2020-08-11 22:42:53 +05:30
David Smiley 97c9bb732a
LUCENE spell: Implement SuggestWord.toString (#1735) 2020-08-11 12:45:49 -04:00
Mike Drob 092076ec39
LUCENE-9453 Assert lock held before volatile write (#1734)
Found via IntelliJ warnings.
2020-08-11 10:41:57 -05:00
Jason Gerlowski 5887032e95
SOLR-14692: Allow 'method' specification on JSON Facet join domain transforms (#1707) 2020-08-11 08:21:07 -04:00
Dawid Weiss 5375a2d2ad
LUCENE-9454: upgrade hamcrest to version 2.2. (#1738) 2020-08-11 11:55:52 +02:00
Noble Paul 15ae014c59
SOLR-14680: Provide simple interfaces to our cloud classes (only API) (#1694) 2020-08-11 15:05:14 +10:00
Cassandra Targett 424a9a6cfc SOLR-13528: fix heading levels 2020-08-10 16:36:40 -05:00
Cassandra Targett a747051c6a LUCENE-9452: remove jenkins.build.ref.guide.sh as it's no longer needed 2020-08-10 15:48:13 -05:00
Cao Manh Dat 9b1aeb3c62 SOLR-14641: Update CHANGES.txt 2020-08-10 15:35:55 +07:00
Cao Manh Dat 57b0160659
SOLR-14641: PeerSync, remove canHandleVersionRanges check (#1663) 2020-08-10 15:04:34 +07:00
Eric Pugh 35771c3cfe
SOLR-14581 Document the way auto commits work in SolrCloud (#1692)
* provide some detail on eventually consistent code

* small tweak to language

* respond to comments and word smithing
2020-08-09 08:35:00 -04:00
Tomas Fernandez Lobbe bd1dd6bdfb SOLR-14582: Fix TestConfig 2020-08-07 16:01:11 -07:00
Gus Heck f827286a2c
SOLR-14582 - Broken test needs fix (#1727)
AwaitsFix for ConfigTest#testDefaults()
2020-08-07 18:49:04 -04:00
Atri Sharma a074418da0
SOLR-13528: Implement Request Rate Limiters (#1686)
This commit introduces two functionalities: request rate limiting and ability to identify requests based on type (indexing, search, admin). The default rate limiter rate limits query requests based on configurable parameters which can be set in web.xml. Note that this rate limiting works at a JVM level, not a core/collection level.
2020-08-08 01:36:06 +05:30
Cassandra Targett 10baa50519 Add paths for gems on new CI machines 2020-08-07 13:58:07 -05:00
Cassandra Targett 5dd4cd1ed3 Comment out RVM_PATH and RUBY_VERSION 2020-08-07 13:40:36 -05:00
Cassandra Targett fb9110ad18 This time comment out ALL the RVM commands to fix the build 2020-08-07 13:35:37 -05:00
Cassandra Targett abf637fc88 INFRA-20656: remove more RVM stuff for Ref Guide build on new CI machines 2020-08-07 13:22:15 -05:00
Cassandra Targett a03e323a9f INFRA-20656: comment out RVM install to fix the Ref Guide build on new Jenkins 2020-08-07 13:03:22 -05:00
Tomas Fernandez Lobbe e6275d9970
SOLR-14582: Expose IWC.setMaxCommitMergeWaitMillis in Solr's index config (#1602) 2020-08-07 10:54:36 -07:00
Tomas Fernandez Lobbe 2bf092b8dd
SOLR-14702: Add Upgrade Notes and CHANGES entry (#1718) 2020-08-07 10:09:40 -07:00