Commit Graph

34977 Commits

Author SHA1 Message Date
Dawid Weiss 224843a2ba Clean up stale comments a bit. 2021-02-20 20:18:02 +01:00
Robert Muir c51fee9c1a
LUCENE-9480: Make DataInput.skipBytes(long) abstract
skipBytes() is a "relative" version of seek(), but DataInput previously
implemented it via read() calls, because DataInput's API does not
include absolute positioning methods (seek, getFilePointer).

This resulted in inefficiencies: calls to skipBytes() would cause
buffers to be allocated, bytes copied, etc.

Instead, make the subclass implement skipBytes() explicitly. The old
DataInput implementation is marked deprecated and renamed to skipBytesSlowly().

Some subclasses still implement skipBytes() via skipBytesSlowly(), to be
fixed in future improvements.
2021-02-20 12:11:32 -05:00
Eric Pugh 2f0d191452
SOLR-15162: Add some parameters to make MODIFYCOLLECTION v1 and v2 more similar. (#2402)
* expose readOnly parameter to v2 of modifycollection.


Co-authored-by: epugh@opensourceconnections.com <>
2021-02-20 10:49:09 -05:00
Jason Gerlowski 582a9f2e14 SOLR-15087: CHANGES.txt entry 2021-02-19 15:54:26 -05:00
Dawid Weiss 515a41dee9
LUCENE-9792: add testRegressions task that downloads and runs hunspell regression tests. (#2407) 2021-02-19 21:13:40 +01:00
Peter Gromov 31a64927a4
LUCENE-9785: Hunspell: don't check case in compound middle and end (#2398) 2021-02-19 20:16:39 +01:00
Peter Gromov 5325d2e6f4
LUCENE-9786: Hunspell suggestions: try moving the last character into the middle (#2399) 2021-02-19 20:15:57 +01:00
Peter Gromov 3ddc3c04a5
LUCENE-9787: Hunspell: speed up suggesting a bit by not creating a huge TreeSet (#2400) 2021-02-19 20:13:19 +01:00
Peter Gromov 58e3b7a854
LUCENE-9790: Hunspell: avoid slow dictionary lookup if the word's hash isn't there (#2405) 2021-02-19 20:10:06 +01:00
Peter Gromov 4b3fb1e065
LUCENE-9776: Hunspell: allow to inflect the last part of COMPOUNDRULE compound (#2397) 2021-02-19 20:03:34 +01:00
Ilan Ginzburg e7c80f6445
SOLR-15157: refactor Collection API to separate from Overseer and message handling abstractions (#2390)
No functional changes. In preparation of distributing the Collection API command execution.
2021-02-19 14:40:23 +01:00
Robert Muir 6deee14382
LUCENE-9774: Fix TestDirectIODirectory to probe for supported filesystem (#2396)
TestDirectIODirectory will currently fail if run on an unsupported
filesystem (e.g. tmpfs). Add an "assume" that probes if the filesystem
supports Direct I/O.

Also tweak javadocs to indicate correct @throws clauses for the
IndexInput and IndexOutput. You'll get an IOException (translated from
EINVAL) if the filesystem doesn't support it, not a UOE.
2021-02-18 20:36:18 -05:00
epugh@opensourceconnections.com f920b9b14e I do not want to backport build tool changes from gradle to ant, so will leave this feature for Solr 9 2021-02-18 17:26:01 -05:00
Eric Pugh f70a518f1b
SOLR-8138: Simple UI for issuing SQL queries (#2381)
* Updated SOLR-8138 files for Solr 9.

This code was mostly written by Michael Suzuki,  i just tweaked it to load, and updated the version of ui-grid to the 4.10 version.

* unused file, we use the .min version.

* add an entry for the ui-grid project to license file.

Co-authored-by: epugh@opensourceconnections.com <>
2021-02-18 17:21:21 -05:00
Peter Gromov 5e834b39eb
LUCENE-9769: Hunspell: KEEPCASE should take precedence over affixed forms (#2374)
and disregard KEEPCASE in Stemmer to make it more consistent with "hunspell -s"
2021-02-18 09:30:09 +01:00
Peter Gromov 589eefc32b
LUCENE-9782: Hunspell suggestions: split by space (but not dash) also before last char (#2387) 2021-02-18 09:28:29 +01:00
Peter Gromov f879c6ad84
LUCENE-9783: Hunspell: don't suggest more than 4 ngram corrections by default (#2388) 2021-02-18 09:27:06 +01:00
Peter Gromov f83c9862e8
LUCENE-9784: Hunspell suggestions: use US keyboard in absence of KEY option (#2389) 2021-02-18 09:26:22 +01:00
Houston Putman 4bd4f7063b
LUCENE-9780: Only validate JARs for tasks that are enabled (#2382) 2021-02-17 18:12:27 -05:00
Jason Gerlowski c3f6e12876 Resolve AbstractCloudBackupRestoreTestCase flakiness
The 'testBackupAndRestore' method in this class was asserting that the
collection created by restore had the expected number of cores-per-node,
but the logic to compute that expected cores-per-node value failed to
account for a rarely-triggered branch that adds a 'createNodeSet' param
to the restore.

This commit updates the test logic to compute the expected
cores-per-node value when createNodeSet is passed.
2021-02-17 16:02:50 -05:00
Gus Heck 1484c74ba7 LUCENE-9659 fix unit test. 2021-02-17 15:19:33 -05:00
Kevin Watters 890f570bf5
LUCENE-9659 inequality support in payload check query (#2185)
Changes from SOLR-14787 supporting inequalities in SpanPayloadCheckQuery
2021-02-17 09:48:50 -05:00
noblepaul 3b6ba9e3e8 Add back-compat indices for 8.8.0 2021-02-17 22:46:58 +11:00
Peter Gromov effca165df
LUCENE-9781: Speed up BytesStore reader setPosition (#2386) 2021-02-17 11:28:44 +01:00
Tobias Kaessmann f142bf9c54
SOLR-15038: Add elevateOnlyDocsMatchingQuery and collectElevatedDocsWhenCollapsing parameters to query elevation.
Closes #2134
2021-02-17 10:54:17 +01:00
Peter Gromov 2ae45cc985
LUCENE-9778: Hunspell: speed up input conversion (#2376) 2021-02-17 09:10:40 +01:00
Peter Gromov 2d53c6073b
LUCENE-9779: Hunspell: add an API to interrupt long computations (#2378) 2021-02-17 09:09:44 +01:00
Ignacio Vera cfd0ccefe1
LUCENE-9777: Fix out of date versions on releases 8.7.0 and 8.8.0 (#2377) 2021-02-17 08:29:05 +01:00
Peter Gromov 902cb93db2
LUCENE-9775: Hunspell: make FORCEUCASE work when the first compound word is inherently title-case (#2375) 2021-02-17 07:54:12 +01:00
David Smiley 2555418048
LUCENE-9762: DoubleValuesSource.fromQuery bug (#2365)
Also used by FunctionScoreQuery.boostByQuery. 
Could throw an exception when the query implements TwoPhaseIterator 
and when the score is requested repeatedly.

Co-authored-by: Chris Hostetter <hossman@apache.org>
2021-02-16 22:51:17 -05:00
David Smiley 253b20c3c6
SOLR-15156: [child childFilter='...:...'] no longer escapes (#2367)
The query escaping it did was inconsistent with all other places in Solr where a Lucene query may be provided.
2021-02-16 22:37:34 -05:00
Jason Gerlowski 15bd858d34
SOLR-15087: Allow restoration to existing collections (#2380)
The recent addition of support for a "readonly" mode for collections
opens the door to restoring to already-existing collections.

This commit adds a codepath to allow this.  Any compatible existing
collection may be used for restoration, including the collection that
was the original source of the backup.
2021-02-16 21:59:24 -05:00
Jason Gerlowski 58acfed0d2 SOLR-15101: CHANGES.txt entry 2021-02-16 19:59:11 -05:00
Chris Hostetter 1c7dac8307 SOLR-15150: New update.partial.requireInPlace=true option to prevent any partial document updates that can't be done In-Place 2021-02-16 15:05:17 -07:00
Timothy Potter 75fd9ef785
SOLR-15135: Use DocCollection to generate state.json format expected by UI to work with perReplicaState collections. (#2383) 2021-02-16 14:40:50 -07:00
Alessandro Benedetti 0671ef5e5f SOLR-15149: messages expected in tests fixed 2021-02-16 19:30:23 +01:00
Ignacio Vera 4cdfbbb95b
LUCENE-9322: Lucene90VectorReader can leak open files (#2371) 2021-02-16 15:08:50 +01:00
Noble Paul 4d7fc57818 added CHANGES.txt section from 7.7.3 release 2021-02-16 17:31:34 +11:00
Robert Muir dd91f5ca82
LUCENE-9773: upgrade icu to 68.2 (#2372)
Upgrade from icu 62.2 to 68.2, with Unicode 13 support.

Modify GenerateUTR30DataFiles to take the release tag as a program
argument. Gradle populates this automatically, removing a manual step
from regeneration process.
2021-02-15 14:56:13 -05:00
Peter Gromov ef920388e6
LUCENE-9771: Hunspell: don't lookup word roots unnecessarily to check flags (#2369) 2021-02-15 20:21:44 +01:00
Peter Gromov 1ff11dd02c
LUCENE-9772: Hunspell: CHECKCOMPOUNDCASE shouldn't prohibit dash-separated uppercase compounds (#2370) 2021-02-15 20:20:58 +01:00
Peter Gromov b20e277569
LUCENE-9770: Hunspell: don't perform compound check recursively when looking for space-separated word pairs (#2368) 2021-02-15 20:20:19 +01:00
Peter Gromov f1a1165ac8
LUCENE-9766: Hunspell: add API for retrieving dictionary morphologica… (#2363) 2021-02-15 20:17:43 +01:00
epugh@opensourceconnections.com ee447d1516 document xslt functionality moving to scripting contrib module 2021-02-15 13:19:56 -05:00
Eric Pugh e6d9eaaf00
SOLR-15121: Move XSLT (tr param) response writer and update request handler to scripting contrib (#2306)
* relocate xslt related classes into scripting contrib
* relocating files to scripting and seperating out unit tests
* relocate files under test-files/scripting/solr, similar to how we do it in other contribs.  deals with some issues in finding files
* Reformatting using the Google Java Format...
* use actual param name, not the variable to properly test api!
* Clean up references to paths, and deal with the mish mash of Xslt and XSLT in class names.
* Move XSLT processing out of XMLLoader
* Move TransformerProvider.Dedupe getTransformer logic.


Co-authored-by: epugh@opensourceconnections.com <>
Co-authored-by: David Smiley <dsmiley@apache.org>
2021-02-15 13:16:18 -05:00
jaison 5856c0f176
LUCENE-9663: Add compression to terms dict from SortedSet/Sorted DocValues.
Closes #2302
2021-02-15 18:12:04 +01:00
Alessandro Benedetti 227ef3b397
SOLR-15149: model creation errors fixes (#2350)
SOLR-15149: model loading errors fix + tests
2021-02-15 18:02:25 +01:00
Jason Gerlowski f993c392f1
SOLR-15101: Add list/delete APIs for incremental backups (#2336)
SOLR-13608 introduces a new "incremental" backup format, which allows
storage of multiple backup "points" in the same location. This
development introduces a need for APIs to manage these potentially
plural backups.

This commit introduces /admin/collections?action=LISTBACKUPS and
/admin/collections?action=DELETEBACKUP to handle these backups.
2021-02-15 07:04:05 -05:00
Ishan Chattopadhyaya 83ccf23fa2 SOLR-15138: Send an intra-process message after ZkClient#create() call 2021-02-15 12:22:22 +05:30
Dawid Weiss 8f56ae0a4b
LUCENE-9767: infrastructure for icu regeneration in place. (#2362) 2021-02-14 21:07:39 +01:00