Commit Graph

31676 Commits

Author SHA1 Message Date
Adrien Grand 577bef53dd LUCENE-8166: Require merge instances to be consumed in the thread that created them. 2019-03-19 10:51:54 +01:00
Kevin Risden cf828163bd
SOLR-13330: Improve HDFS tests
Related JIRAs:
* SOLR-11010
* SOLR-11381
* SOLR-12040
* SOLR-13297

Changes:
* Consolidate hdfs configuration into HdfsTestUtil
* Ensure socketTimeout long enough for HDFS tests
* Ensure HdfsTestUtil.getClientConfiguration used in tests
* Replace deprecated HDFS calls
* Use try-with-resources to ensure closing of HDFS resources

Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-18 15:25:36 -04:00
erick 3ac07b8dfb SOLR-13268: Patch that flushes when shutting down 2019-03-18 11:52:39 -07:00
Alan Woodward 5ca2524927 LUCENE-8694: Payload-filtered term intervals 2019-03-18 09:41:00 +00:00
Chris Hostetter 5c143022e7 SOLR-12923: Mea culpa: Remove useless import of java.lang... that breaks precommit 2019-03-15 14:39:19 -07:00
Simon Willnauer af5c2b22da Fix more tests to not use concurrent flushing in RIW#commit() 2019-03-15 22:18:20 +01:00
Chris Hostetter 1a54c6b19d SOLR-12923: fix SimClusterStateProvider to use lock.lockInterruptibly() exclusively, and make SimCloudManager's Callable checks tollerant of Callables that may have failed related to interrupts w/o explicitly throwing InterruptedException 2019-03-15 12:06:53 -07:00
Chris Hostetter c79aeee5f9 SOLR-12923: tweak the randomization in testCreateLargeSimCollections to reduce the max possible totalCores
also decrease the number of iters while increase the cluster shape wait time to reduce the risk of spurious failures on machines under heavy contention w/o making the the test any slower on average
2019-03-15 10:43:28 -07:00
Jan Høydahl 8f29d1eaad
SOLR-13244: Nodes view fails when a node is temporarily down 2019-03-15 13:30:02 +01:00
Andrzej Bialecki 571b307266 SOLR-13292: Fix a logic bug when point types are present, add more details to the unit test. 2019-03-15 11:52:37 +01:00
Simon Willnauer ad457d188e Improve RIW exception handling and opt out of concurrent flushing if exception is expected 2019-03-15 11:00:16 +01:00
Adrien Grand 425f207f40 LUCENE-8688: Forced merges merge more than necessary. 2019-03-15 10:27:27 +01:00
Chris Hostetter 76babf876a SOLR-12923: Fix some issues w/concurrency and exception swallowing in SimClusterStateProvider/SimCloudManager
There are 3 tightly related bug fixes in these changes:

1) ConcurrentModificationExceptions were being thrown by some SimClusterStateProvider methods when
   creating collections/replicas due to the use of ArrayLists nodeReplicaMap. These ArrayLists were changed
   to use synchronizedList wrappers.
2) The Exceptions from #1 were being swallowed/hidden by code using SimCloudManager.submit() w/o checking
   the result of the resulting Future object. (As a result, tests waiting for a particular ClusterShape
   would timeout regardless of how long they waited.)   To protect against "silent" failures like this,
   this SimCloudManager.submit() has been updated to wrap all input Callables such that any uncaught errors
   will be logged and "counted."  SimSolrCloudTestCase will ensure a suite level failure if any such failures
   are counted.
3) The changes in #2 exposed additional concurrency problems with the Callables involved in leader election:
   These would frequently throw IllegalStateExceptions due to assumptions about the state/existence of
   replicas when the Callables were created vs when they were later run -- notably a Callable may have been
   created that held a reference to a Slice, but by the time that Callable was run the collection (or a
   node, etc...) refered to by that Slice may have been deleted.  While fixing this, the leader election
   logic was also cleaned up such that adding a replica only triggers leader election for that shard, not
   every shard in the collection.

While auditing this code, cleanup was also done to ensure all usage of SimClusterStateProvider.lock was
also cleaned up to remove all risky points where an exception may have been possible after aquiring the
lock but before the try/finally that ensured it would be unlocked.
2019-03-14 22:27:48 -07:00
Alan Woodward fbd05167f4
LUCENE-3041: QueryVisitor (#581)
This commit adds an introspection API to Query, allowing users to traverse
the nested structure of a query and examine its leaves.  It replaces the existing
`extractTerms` method on Weight, and alters some highlighting code to use
the new API
2019-03-14 15:04:33 +00:00
Simon Willnauer ffb1fc83de
Concurrently flush next buffer during commit in RandomIndexWriter (#607)
This is a spinn-off from `LUCENE-8700` that is satisfied by IndexWriter#flushNextBuffer.
The idea here is to additionally call flushNextBuffer in RandomIndexWriter for better
test coverage. This is a test-only change.
2019-03-14 15:43:35 +01:00
Moshe c2a6772f1e SOLR-13129: nested docs: add more/better documentation in Solr ref-guide 2019-03-14 09:11:24 -04:00
jimczi 2afa6cb00a Add 8.0.0 back compat test indexes and reenable backward compatibility tests for 9 2019-03-14 14:00:13 +01:00
jimczi 132a188602 update doap files with the new release 8.0.0 2019-03-14 13:03:34 +01:00
Alan Woodward 9096b846af LUCENE-8719: Traverse all paths at the end of a TokenStream in FixedShingleFilter 2019-03-14 11:10:02 +00:00
Alan Woodward 84785e8e45 LUCENE-8726: Changes entry 2019-03-14 10:57:34 +00:00
Alan Woodward d19dcb4ff0 LUCENE-8726: ValueSource.asDoubleValuesSource() could leak a reference to IndexSearcher 2019-03-14 10:17:12 +00:00
Jan Høydahl a18aa2118b SOLR-12121: Remove a System.out.println in JWTAuthPlugin 2019-03-14 10:48:09 +01:00
Shalin Shekhar Mangar 6d0386c901 SOLR-13234: Fix for turkish locales
WhenSolrExporterIntegrationTest.jvmMetrics ran on a JVM with the Turkish locale, (test seed: 62880F3B9F140C89). The JVM metric for terminated thread-count has a dotless-i e.g. termınated.
This causes the check for matching metrics to fail.

We could normalize the text in this case, however I think it's better to ensure we have the correct total number of JVM thread metrics rather than looking at Prometheus labels which maybe localized.

This closes #605.
2019-03-14 11:10:49 +05:30
Gus Heck d8f2a02fdb SOLR-13131 Category Routed Aliases 2019-03-13 01:32:23 -04:00
Gus Heck cf88f54a29 Remove inadvertently included println 2019-03-12 16:09:04 -04:00
Mike McCandless c1bea96cf9 LUCENE-8720: fix int overflow in NameIntCacheLRU 2019-03-12 12:19:33 -04:00
Gus Heck 9edc557f45 SOLR-12891 MacroExpander will no longer will expand URL parameters by
default inside of the 'expr' parameter, add InjectionDefense class
for safer handling of untrusted data in streaming expressions and add
-DStreamingExpressionMacros system property to revert to legacy behavior
2019-03-12 10:46:30 -04:00
jimczi b2c83de361 LUCENE-8652: remove unused import 2019-03-12 09:56:14 +01:00
Yeongsu Kim b1f870a416 LUCENE-8631: The Korean user dictionary now picks the longest-matching word and discards the other matches. 2019-03-12 09:49:16 +01:00
jimczi c87e7614f1 LUCENE-8652: ensure that the norm doesn't influence the score in TestSynonymQuery#testBoosts 2019-03-12 09:33:40 +01:00
iverase fd8d9d5199 LUCENE-8713: Add Line2D tests 2019-03-12 09:18:54 +01:00
Ignacio Vera 458205396e
LUCENE-8712: Polygon2D does not detect crossings in some cases (#598)
LUCENE-8712: revert crossing logic to use boolean logic and skip lines
over the dateline to support dateline crossing logic
2019-03-12 08:40:54 +01:00
Erick Erickson b893548d97 SOLR-13268: Clean up any test failures resulting from defaulting to async logging. Put TestXmlQParser back 2019-03-11 21:40:23 -07:00
Erick Erickson 28c8171fe6 SOLR-12732: TestLogWatcher failure on Jenkins. Deal with superclass logging bleeding into first watcher in the test 2019-03-11 12:55:08 -07:00
Erick Erickson 3a1603dab3 SOLR-13268: Clean up any test failures resulting from defaulting to async logging. Fix precommit test to not include the baseDir 2019-03-11 11:03:31 -07:00
Chris Hostetter 7eb728a611 SOLR-13300: DistributedFacetExistsSmallTest should not attempt to compare results of a query that is known to differ in behavior in distributed mode 2019-03-11 10:02:46 -07:00
Kevin Risden 6777af074f
SOLR-13307: Ensure HDFS tests clear System properties they set (Kevin Risden)
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-11 11:13:37 -04:00
jimczi d8cfeba912 LUCENE-8652: SynonymQuery can now deboost the document frequency of each term when blending the score of the synonym 2019-03-11 10:20:11 +01:00
Mikhail Khludnev e353dcfe7d SOLR-13284: fallback to json instead of NPE and 500 code, when wt is omitted or wrong. 2019-03-10 23:10:38 +03:00
erick 9272c29539 SOLR-13268: Clean up any test failures resulting from defaulting to async logging 2019-03-10 11:05:00 -07:00
Andrzej Bialecki 27df824a4b SOLR-13292: Provide extended per-segment status of a collection. 2019-03-09 14:08:01 +01:00
Erick Erickson 8c6e305365 SOLR-12732: TestLogWatcher failure on Jenkins. Added more logging 2019-03-08 21:40:06 -08:00
Chris Hostetter 3b2d836142 Merge remote-tracking branch 'refs/remotes/origin/master' 2019-03-08 14:54:54 -07:00
Chris Hostetter 4335ad97af Delete OpenCloseCoreStressTest
This is a fairly old test that isn't particularlay valuable, all it really does is stress test indexing, but w/o actually validating the results.

In it's current state, it can suffer from exceeding file handle limits depending on merge settings, and isn't reliably reproducible due to it's
approach of "do (a variable) amount of work until a fixed amount of wall clock time has elapsed"
2019-03-08 14:52:33 -07:00
Jan Høydahl 9eabaf46a2 SOLR-12121: Move CHANGES entry from Improvements to New Features section 2019-03-08 22:08:31 +01:00
Chris Hostetter 20de3d2ee0 SOLR-12923: harden TestSimLargeCluster
- added logging
- ensure start/finish trigger action counters are incremented before latches are released
- replace arbitrary sleep calls with a trigger listener countdown latch
- increase all await() times: This means that 'real' failures (which should be rare and hopefully
  reproducible) will be 'slow', but the trade off will be less hard to reproduce 'false failures'
  due to thread contention on slow or heavily loaded (ie: jenkins) machines
2019-03-07 15:40:57 -07:00
Christine Poerschke 683aa3d3e9 SOLR-13254: Correct message that is logged in solrj's ConnectionManager when an exception occurred while reconnecting to ZooKeeper. (hu xiaodong via Christine Poerschke) 2019-03-07 20:17:31 +00:00
Erick Erickson 1e09268e78 SOLR-13261: Make SortableTextField work with export/streaming, now requires useDocValuesAsStored='true' 2019-03-07 10:59:20 -08:00
Uwe Schindler db5f1af59b Fix Windows startup script to disable HTTP/2 if TLS is enabled on Java 8. 2019-03-07 14:16:36 +01:00
Gus Heck d2d3942721 SOLR-13296 fix doc example so that it can be accepted by Solr
(previously caused error due to decreasing offsets)
2019-03-07 08:01:01 -05:00