32706 Commits

Author SHA1 Message Date
Christine Poerschke
540f617cbb LUCENE-8996: maxScore was sometimes missing from distributed grouped responses.
(Julien Massenet, Diego Ceccarelli, Munendra S N, Christine Poerschke)

Resolved Conflicts:
	lucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroups.java
2019-12-09 14:34:36 +00:00
Andrzej Bialecki
349fe428c4 SOLR-13979: Expose separate metrics for distributed and non-distributed requests. 2019-12-09 13:51:35 +01:00
Jan Høydahl
9dd1b4accc SOLR-13977: Move changes entry to 8.4
(cherry picked from commit 0d78535dcfeab88edfd97b8d892b2e783aaf5504)
2019-12-09 10:28:38 +01:00
Daiki Tsuzuku
d0f433632f LUCENE-9085: Fix assertion in CharacterUtils (#1067) 2019-12-09 08:32:50 +01:00
Munendra S N
42a6fcbdd9 SOLR-11706: fix for multivalued trie date in min/max and more tests
* selecting single value for multivalued trie date field is not
  supported.
* add additional tests for variance, unique, hll aggregations
2019-12-08 11:04:52 +05:30
Michael Gibney
65a1804aeb SOLR-7798: robust support for expand when used w/o collapsing (#325)
There are applications of ExpandComponent that intentionally do not
involve prior collapsing of results on the expand field, which can lead
to an NPE in expand component when expand.field (for matched docs) has
fewer unique values than the number of matched docs.

This commit refines the approach taken in SOLR-13877, which addressed
the same underlying issue.
2019-12-08 10:11:18 +05:30
Kevin Risden
7ad7bbe05c
SOLR-13987: Admin UI should not rely on javascript eval()
* Removes `'unsafe-eval'` from CSP `script-src`
* Enables Angular CSP mode
* Removes `eval()` JSON parsing in `cloud.js`
* Removes `jstree` themes error

Signed-off-by: Kevin Risden <krisden@apache.org>
2019-12-07 16:52:19 -05:00
Kevin Risden
970264c6d2
SOLR-14028: Fix test permissions for TestSolrCLIRunExample
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-12-07 16:33:58 -05:00
Munendra S N
0a26e38fbe SOLR-11706: minor refactors
* rename stdDev, variance methods to reflect the functionality
* add util functions to compute corrected stdDev and variance
* use DocValuesIterator#advanceExact to check if values exists for the doc
2019-12-07 11:39:00 +05:30
Erick Erickson
b0ffacab00 SOLR-13988: Harden CreateCollectionCleanupTest. Incorporate Dawid Weiss' suggestion for windows
(cherry picked from commit 7d5d44a3c42797b312310df8a7f4af910e052124)
2019-12-06 19:11:43 -05:00
Jason Gerlowski
e44bcc05c4 SOLR-13087: Remove 'whoami' usage in bin/solr
whoami displays a warning if the effective-uid is not in /etc/password.
This can happen in certain situations when running in a docker
container.  This replaces the 'whoami' usage with a safer check.
2019-12-06 15:32:38 -05:00
Erick Erickson
230ab97acb SOLR-13988: Harden CreateCollectionCleanupTest
(cherry picked from commit 106b9d686602b05f02139e296ea3a388a5fac406)
2019-12-06 12:00:18 -05:00
Kevin Risden
81e99697d7
SOLR-14001: fix HdfsBackupRepositoryTest on windows
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-12-06 09:50:36 -05:00
Jan Høydahl
912789bb93 SOLR-13954: Embedded ZooKeeper in Solr now does not try to load JettyAdminServer (#1059)
(cherry picked from commit 7417fa1cf3a7875b76419793a38080059f52b1fc)
2019-12-06 11:05:11 +01:00
Robert Muir
0cd302d7b7 SOLR-14020: move hadoop hacks out of lucene TestSecurityManager into a solr one 2019-12-05 14:56:21 -05:00
Andrzej Bialecki
5865893e64 SOLR-13831: Context property _loop_iter_ should be a string in order to support
variable expansion.
2019-12-05 18:27:43 +01:00
Robert Muir
e6728cdf64 SOLR-13993: sandbox velocity template render (if security manager is enabled)
The solr permissions are weak sauce due to the huge number of features, third-party dependencies, etc.

Hence they have access to do many things. For "scripting" such as velocity we have to look at a more aggressive stance:

Step 1: Can we wrap a sandbox around the whole goddamn thing and call it a day?
Step 2: Let's separate the "engine" from "untrusted code" and only be an asshole to the latter.
Step 3: Java's security is shit, Lets contain that classloader and whitelist access.
2019-12-05 01:36:58 -05:00
Munendra S N
2d2f4b9521 SOLR-11706: add support for aggregation on multivalued fields
* min, max, sum, sumsq, avg, stddev, variance, percentile aggregations
  in JSON facets now supports multivalued fields
2019-12-05 11:01:50 +05:30
Robert Muir
5325c29cf9 SOLR-14015: remove blanket filesystem read access from solr-tests.policy
Restrict this to only minimal paths like lucene. It is the defense for directory traversal attacks.
It will also help find bad bugs where things are reading filesystem in the wrong locations.
2019-12-05 00:06:57 -05:00
Andrzej Bialecki
6ebe4d16d2 SOLR-13981: Remove unused DistributedQueue interface. (Andras Salamon) 2019-12-04 11:14:07 +01:00
Anshum Gupta
b4375cc235
SOLR-13998: Add thread safety annotations to classes (#1053) (#1057) 2019-12-04 12:09:22 +05:30
Ishan Chattopadhyaya
8a7d875912 Add back-compat indices for 8.3.1 2019-12-04 10:15:51 +05:30
Ishan Chattopadhyaya
fcf4d400c6 Add bugfix version 8.3.1 2019-12-04 10:08:54 +05:30
Robert Muir
57cce89397 SOLR-14001: fix HDFS jaas on 32bit, unix, old jdk, etc 2019-12-03 23:13:10 -05:00
Robert Muir
11f1c958eb SOLR-14002: fix another static leak in test 2019-12-03 22:44:07 -05:00
Robert Muir
08720cf5c0 SOLR-14000: clean up more static field leaks in tests
On windows, these objects can't be inspected due to security restrictions. So the test runner fails the tests since it does not know how big the leak is.
2019-12-03 18:53:43 -05:00
Jeff
dc15f2e563 SOLR-13926: javadocs on CompositeIdRouter
Closes #1009

(cherry picked from commit 16f793915ec6dfceecf0267c66ac0c051da2d0c4)
2019-12-03 17:45:09 -05:00
Robert Muir
72b86bc222 fix static leaks, null stuff out in afterclass 2019-12-03 06:28:52 -05:00
Robert Muir
55b77358cf SOLR-13982: set security-related http response headers by default
Unfortunately, as a first start this is very weak protection against
e.g. XSS.  This is because some 'unsafe-xxx' rules must be present due
to the insecurity of angular JS: Until SOLR-13987 is fixed, XSS & co are
still easy.
2019-12-03 06:18:11 -05:00
Adrien Grand
d09a963e4a Fix CHANGES formatting. 2019-12-03 11:30:19 +01:00
noble
664d93591f SOLR-13995: Move ZkShardTerms.Terms to SolrJ 2019-12-03 15:37:22 +11:00
Robert Muir
17f4cc3688 SOLR-13991: clean up permissions in solr-tests.policy AKA break all the tests to hell, please ping the issue for repeated test failures 2019-12-02 21:23:46 -05:00
Noble Paul
80abab2935 SOLR-13992: Refactor code to have collection, shard name in Replica,Slice (#1051)
* SOLR-13992: Refactor code to have collection name shard name in Replica,Slice
2019-12-03 13:12:23 +11:00
Cassandra Targett
0ebb62a9f2 SOLR-13885: various Ref Guide typos. This closes #990 2019-12-02 13:38:06 -06:00
Mikhail Khludnev
f0d7aa4bc0 LUCENE-9073: IntervalQuery expose field on toString and explain 2019-12-02 19:25:15 +03:00
Bruno Roustant
bb600e3638
LUCENE-9045: Do not use TreeMap/TreeSet in BlockTree and PerFieldPostingsFormat.
Closes #1007
2019-12-02 14:36:44 +01:00
Robert Muir
58473a04b9 LUCENE-9076: give replicator its own policy rather than reusing solr policy 2019-12-02 06:55:53 -05:00
Robert Muir
3de517b286 SOLR-13986: remove execute permission from solr-tests.policy 2019-12-02 05:39:28 -05:00
Shalin Shekhar Mangar
ba95111d71 SOLR-13805: NPE when calling /solr/admin/info/health on standalone solr
(cherry picked from commit 5a697344ed1be537ef2acdd18aab653283593370)
2019-11-30 10:04:44 +05:30
Jan Høydahl
325e72c45f SOLR-13977: solr create -c not working under Windows 10
(cherry picked from commit 936f4b6ee9cd8c7f9a17800aadc8c5a91bdf74f6)
2019-11-29 13:07:50 +01:00
Bruno Roustant
1927e850c8
SOLR-13968: Support postingsFormat and docValuesFormat in schema fields.
Closes #1039
2019-11-28 17:17:23 +01:00
David Smiley
8b2d8d0947 SOLR-13971: Revert changes to the default configset. * clarified these are Java system properties * trivial dead code change; Boolean.getBoolean returns a primitive 2019-11-28 11:07:51 -05:00
Ishan Chattopadhyaya
26b5506290 8.3.1 release: CHANGES got misaligned 2019-11-28 19:41:07 +05:30
Bruno Roustant
e35de97991
LUCENE-8983: TestPhraseWildcardQuery more robust wrt randomization. 2019-11-28 12:58:05 +01:00
Ishan Chattopadhyaya
bf2899fb00 SOLR-13971: Renamed the velocity template parameter names 2019-11-28 15:44:19 +05:30
Jan Høydahl
ee39b15b86 SOLR-13969: Clean up and document AuditEvent API (#1041)
(cherry picked from commit 9f78482295819ba10a383d3027c1d6313c6e2e7d)
2019-11-28 09:57:01 +01:00
Ishan Chattopadhyaya
05c5bcc8b3 SOLR-13971: Removing velocity from _default and disabling custom template support by default 2019-11-28 07:54:37 +05:30
Alan Woodward
e681f9dca4 LUCENE-9062: QueryVisitor.consumeTermsMatching (#1037)
This commit adds a consumeTermsMatching() method to QueryVisitor, allowing
queries that match against a class of terms to report this back to the visitor. It also
changes highlighting code to use this new method, replacing the current implementation
via instanceof checks.
2019-11-27 16:30:38 +00:00
Andrzej Bialecki
2144bc9b4e Fix the list of common handler metrics. 2019-11-27 16:01:27 +01:00
iverase
01469fc046 Fix failing test due to a typo 2019-11-27 12:20:53 +01:00