group.query after execution forms QueryCommandResult. In case of
group.main=true or group.format=simple, QueryCommandResult was not
consumed in EndResultTransformer. Also, MainEndResultTransformer assumed
that always group.field would be specified. When group.field not specified
it failed with AIOOBE. After adding suppport for QueryCommandResult in
EndResultTransformers and handling AIOOBE, group.query started giving results
Working on tests exposed few other issues. Results differed b/w standalone
& distributed mode.
* One of the reason is that TopGroupShardResponseProcessor doesn't consider correct
limit and offset when group format is simple. In case of simple, start and rows should be used
as limit and offset instead of group.limit and group.offset.
* Secondly, In distributed second phase grouping, computing docsToCollect didn't consider
group response format. This issue is again similar to above issue
* offset(group.offset or start) not being considered during TopDocs#merge caused
different results. The fix was to use to offset in merge process
* group.offset doesn't support negative values but there is no checks on the value.
In case of negative values AIOOBE. Now, checks are added for negative values and
returns proper error message(this change is for both standalone and distrbuted).
Validation is done only in case of group.format=grouped as that is only case when
group.offset is consumed.
Fixing above issues resolved the differences b/w standalone and distributed mode.
* When ramPerThreadHardLimitMB is not specified, then Lucene's
default value 1945 is used. The specified value should be
greater than 0 and less than 2048MB
This commit introduces custom tiebreakers which allows users to
specify custom tiebreakers when ordering hits to return. A
default tiebreaker is introduced for tie breaking on shard index
first and then docID.
This commit introduces a mechanism to track the dynamic memory
utilization of Collectors and allow setting collector level limits
for memory usage. A new bitset collecting Collector is introduced
which supports the memory tracker functionality
* Improve error message when collapsing is not supported on given
fieldtype
* Return 400 error code when unsupported value are passed for max,min
or in case of syntax error
These build badges can be used by novice developers to tell at a glance whether the master branch build (compilation-only) is broken.
Authored-by: Marcus Eagan
The class `BooleanWeight` takes a `BooleanQuery` (a list of `BooleanClause`s) as input and maintains a list of weights corresponding to the clauses. The clauses and the weights are iterated in parallel in various places throughout the class. At these code locations, it is not obvious that these two lists always have the same length, i.e., that the parallel iteration is safe. Moreover, the parallel iteration is not well supported by the Java language, which is why this operation is implemented differently throughout the code.
This patch joins the two lists to enable parallel iteration without managing two separate lists. This makes the code’s intent more obvious and prevents bugs due to the lists getting out of sync by a future change.
Munendra S N
Joel Bernstein
Cassandra Targett
Adrien Grand
Atri Sharma
Jason Gerlowski
Alan Woodward
Ignacio Vera
Mikhail Khludnev
Tomoko Uchida
Gert Morten Paimla
Marcus
Chris Hostetter
Christine Poerschke
Andrzej Bialecki
Sven Amann
Michael Sokolov
Jan Høydahl
jimczi
Ignacio Vera
Julie Tibshirani