Commit Graph

8550 Commits

Author SHA1 Message Date
Mike Drob c902837bb2
SOLR-14846 Clean up Optional use (#1843)
* Remove Optional.ofNullable.orElse pattern
* Remove use of Optional as method parameter
2020-09-09 09:19:48 -05:00
Christine Poerschke f46515ee6b
Rename TestDirectoryFactory to DirectoryFactoriesTest (which is different from DirectoryFactoryTest). (#1790) 2020-09-09 13:08:20 +01:00
Mike Drob 984466f31b
SOLR-14770 Avoid reregistering JVM Guage as well (#1469) 2020-09-08 10:18:24 -05:00
Noble Paul 95ab98c920
SOLR-14151: Bug fixes (#1815) 2020-09-08 09:58:42 +10:00
Jason Gerlowski ecb8ca2fef SOLR-14821: {!terms} dVTFTL supports single-valued strings
Prior to this commit the docValuesTermsFilterTopLevel method of the
{!terms} query parser would return zero results when run against a
single-valued String.  This commit fixes this by wrapping the
single-valued 'SortedDocValues' in a 'SortedSetDocValues' object.
2020-09-05 13:54:27 -04:00
Erick Erickson f71ba62d4a SOLR-14579: Comment SolrJ 'Utils' generic map functions 2020-09-05 09:19:45 -04:00
Andy Vuong 2544df8f6d
SOLR-14658: SolrJ collectionStatus(col) should only fetch one status (#1687)
An optimization or a perf-bug depending on point of view
2020-09-03 14:25:36 -04:00
Chris Hostetter a70a47d053 SOLR-14383: Fix nested indexing ref-guide documentation and corrisponding search examples
Squashed commit of branch jira/SOLR-14383 as of...

commit 34da84c238
Merge: 5d293276a3 8bd79ec301
Author: Chris Hostetter <hossman@apache.org>
Date:   Tue Sep 1 16:39:03 2020 -0700

    Merge branch 'master' into jira/SOLR-14383
2020-09-02 14:16:23 -07:00
Robert Muir 784ede4eda
LUCENE-9215: replace checkJavaDocs.py with doclet (#1802)
This has the same logic as the previous python, but no longer relies
upon parsing HTML output, instead using java's doclet processor.

The errors are reported like "normal" javadoc errors with source file
name and line number and happen when running "gradlew javadoc"

Although the "rules" are the same as the previous python, the python had
some bugs where the checker didn't quite do exactly what we wanted, so
some fixes were applied throughout.

Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
Co-authored-by: Uwe Schindler <uschindler@apache.org>
2020-09-02 08:29:17 -04:00
Ilan Ginzburg 825c18c59b
SOLR-14794: revert commit passing CloudConfig everywhere (a3b3ba10e3) and remove tab in solr/bin/solr.cmd 2020-09-01 17:21:12 +02:00
noblepaul 4a68cf18b6 SOLR-14151: move the SolrClassLoader interface to SolrJ 2020-09-01 10:23:15 +10:00
David Smiley 06903a40ee
LUCENE-9456: fix DirectUpdateHandlerTest#testPrepareCommit (#1803)
Check for specific files being present or not or changing.  Don't make assumptions about file count.
2020-08-30 11:32:56 -04:00
Ilan Ginzburg a3b3ba10e3
SOLR-14794: pass configuration to Collection API commands (#1801)
Pass CloudConfig instance representing the solrcloud section of solr.xml configuration from Overseer to the Collection and Config Set API commands it executes.
2020-08-30 11:36:28 +02:00
Alexandre Rafalovitch a57ba25400
SOLR-14783: Remove DIH from 9.0 (#1794)
* Remove DIH example directory

* Remove contrib code directories

* Remove contrib package related configurations for build tools

* Remove mention of DIH example

* remove dih as build dependencies and no-longer needed version pins

* Remove README references to DIH

* Remove dih mention from the script that probably does need to exist at all

* More build artifact references

* More removed dependencies leftovers (licenses/versions)

* No need to smoke exclude DIH anymore

* Remove Admin UI's DIH integration

* Remove DIH from shortname package list

* Remove unused DIH (related? not?) dataset
Unclear what is happening here, but there is no reference to that directory anywhere else
The other parallel directories ARE referenced in a TestConfigSetsAPI.java

* Hidden Idea files references

* No DIH to ignore anymore

* Remove last Derby DB references

* Remove DIH from documentation
Add the information in Major Changes document with the link to the external repo

* Added/updated a mention to CHANGES

* Fix leftover library mentions

* Fix Spellings
2020-08-29 10:52:04 -04:00
noblepaul ec27b75232 use proper version String 2020-08-29 18:18:41 +10:00
Tomas Fernandez Lobbe 59d087f0b3
SOLR-14774: Create HealthCheckHandler in CoreContainer (#1774)
This commit does two things:
* Allow users to plug-in different implementations of the handler (they must extend HealthCheckHandler)
* Remove the HealthCheckHandler from the implicit SolrCore plugins
2020-08-28 15:59:56 -07:00
Ishan Chattopadhyaya d84977eb5c SOLR-14616: Remove CDCR 2020-08-29 02:13:13 +05:30
Erick Erickson 69fa5a00fb LUCENE-9433: Remove Ant support from trunk 2020-08-28 09:31:16 -04:00
Atri Sharma b381595f55 Fix NPE in CB Config Resolution 2020-08-27 20:52:12 +05:30
Atri Sharma 6a7da3cd50
Update Circuit Breaker configured as a standard plugin (#1785) 2020-08-27 14:06:22 +05:30
Adrien Grand 741251b1c3 LUCENE-9447: Fix test failure. 2020-08-26 12:55:46 +02:00
Adrien Grand 913976dbf7
LUCENE-9447: Make BEST_COMPRESSION better with highly compressible data. (#1762)
This makes BEST_COMPRESSION split blocks into sub blocks and use preset
dictionaries to improve compression ratios.
2020-08-26 11:04:34 +02:00
Philipp Trulson f4c4fbcafc SOLR-14752: Fix error in Zookeeper status when Prometheus plugin is enabled in ZK
Signed-off-by: Jan Høydahl <janhoy@apache.org>
2020-08-26 10:03:42 +02:00
Simon Willnauer 8294e1ae20
LUCENE-8962: Merge segments on getReader (#1623)
Add IndexWriter merge-on-refresh feature to selectively merge 
small segments on getReader, subject to a configurable timeout, 
to improve search performance by reducing the number of small 
segments for searching.

Co-authored-by: Mike McCandless <mikemccand@apache.org>
2020-08-24 20:19:08 +02:00
Atri Sharma 96a853b200
SOLR-14772: Fix TestConfigOverlay (#1778) 2020-08-24 22:34:23 +05:30
noblepaul 1c8f4c988a SOLR-14750: use core id to avoid duplicate core reloads 2020-08-22 17:53:55 +10:00
Erick Erickson c9c75810c2 Revert "LUCENE-9433: Remove Ant support from trunk"
This reverts commit 37cd17dc
2020-08-21 16:57:58 -04:00
Anderson Dorow 66b6ce2cd0
SOLR-13438: on collection delete, also delete .AUTOCREATED config set (#1759)
Co-authored-by: Anderson Dorow <Anderson.Dorow@zooplus.com>
2020-08-21 14:43:16 -05:00
Erick Erickson 37cd17dcf5 LUCENE-9433: Remove Ant support from trunk 2020-08-21 15:19:52 -04:00
Atri Sharma 2f37f40171
SOLR-14615: Implement CPU Utilization Based Circuit Breaker (#1737)
This commit introduces CPU based circuit breaker. This circuit breaker
tracks the average CPU load per minute and triggers if the value exceeds
a configurable value.

This commit also adds a specific control flag for Memory Circuit Breaker
to allow enabling/disabling the same.
2020-08-20 13:21:26 +05:30
Noble Paul 8caf57d50b
SOLR-14750: TestBulkSchemaConcurrent fails often(#1760) 2020-08-19 10:52:12 +10:00
Ishan Chattopadhyaya 77a4d495cc SOLR-14731: Rename @SolrSingleThreaded to @SolrThreadUnsafe, mark DistribPackageStore with the annotation
Co-authored-by: Marcus <marcuseagan@gmail.com>
2020-08-18 16:21:38 +05:30
Atri Sharma 4fed9ff8d3 Move TestRequestRateLimiter to Nightly 2020-08-18 13:43:49 +05:30
Andrzej Bialecki d9fb14dec1 SOLR-13858: Remove no longer used field and getter. 2020-08-17 14:47:38 +02:00
David Smiley 0ce2d610c2
SOLR-14722: timeAllowed should track from req creation (#1726)
* set(long) instead of set(Long).
* Fix javadocs CommonParams.TIME_ALLOWED
2020-08-15 00:41:07 -04:00
Yuriy Koval 44c4e6ef31
SOLR-14703 Edismax parser replaces whitespace characters with spaces (#1713) 2020-08-14 14:12:53 -04:00
Noble Paul d517361bb1
SOLR-14680: Provide an implementation for the new SolrCluster API (#1730) 2020-08-13 13:34:24 +10:00
Jason Gerlowski a6515ca38f SOLR-14748: Correct condition on startup auth/ssl logging 2020-08-12 18:44:02 -04:00
andywebb1975 e72a0d66c6
SOLR-13751: add BooleanSimilarityFactory (#867) 2020-08-12 15:35:50 +01:00
Andrzej Bialecki a5543dfb51 SOLR-14470: Fix test failures by reducing the randomness of test data. 2020-08-12 13:45:25 +02:00
Atri Sharma 1d2749295b
Harden RequestRateLimiter Tests (#1736)
* Harden RequestRateLimiter Tests

This commit adds higher data size and load in the test path. Also improves
the asserts that are performed.
2020-08-11 22:42:53 +05:30
Jason Gerlowski 5887032e95
SOLR-14692: Allow 'method' specification on JSON Facet join domain transforms (#1707) 2020-08-11 08:21:07 -04:00
Cao Manh Dat 57b0160659
SOLR-14641: PeerSync, remove canHandleVersionRanges check (#1663) 2020-08-10 15:04:34 +07:00
Tomas Fernandez Lobbe bd1dd6bdfb SOLR-14582: Fix TestConfig 2020-08-07 16:01:11 -07:00
Gus Heck f827286a2c
SOLR-14582 - Broken test needs fix (#1727)
AwaitsFix for ConfigTest#testDefaults()
2020-08-07 18:49:04 -04:00
Atri Sharma a074418da0
SOLR-13528: Implement Request Rate Limiters (#1686)
This commit introduces two functionalities: request rate limiting and ability to identify requests based on type (indexing, search, admin). The default rate limiter rate limits query requests based on configurable parameters which can be set in web.xml. Note that this rate limiting works at a JVM level, not a core/collection level.
2020-08-08 01:36:06 +05:30
Tomas Fernandez Lobbe e6275d9970
SOLR-14582: Expose IWC.setMaxCommitMergeWaitMillis in Solr's index config (#1602) 2020-08-07 10:54:36 -07:00
noblepaul 321c4bbe1f SOLR-14654: clean up ref guide, CHANGES.txt 2020-08-06 16:46:12 +10:00
Noble Paul 6f2f1c3de2
SOLR-14654 Remove plugin loading from .system collection (for 9.0) (#1677) 2020-08-06 16:32:32 +10:00
Tomas Fernandez Lobbe 6752111be8 SOLR-14702: doFetch reads legacy parameters too 2020-08-05 14:53:50 -07:00
Marcus 7110118ad4
SOLR-14702: Remove oppressive language (part1) (#1711)
Replace references to "master" and "slave" with "leader" and "follower"
2020-08-05 14:52:48 -07:00
Ishan Chattopadhyaya bd21da6eca SOLR-14604: Add the ability to uninstall a package from with the Package CLI (#1710)
Co-authored-by: Marcus <marcuseagan@gmail.com>
2020-08-04 14:53:25 +05:30
Chris Hostetter a6c058a260 SOLR-14657: Improve error handling in IndexReader realted metrics that were causing scary ERROR logging if metrics were requested while Solr was in the process of closing/re-opening a new IndexReader 2020-08-03 09:58:16 -07:00
Munendra S N 07a89e7bf6 SOLR-14516: fix NPE is resp writer while writing docvalue only field
This issue occurs only while fetching uncommitted doc through /get.
Instead of directly calling stringValue() on IndexableField use
FieldType's toExtern() or toObject() to get the writable value for the field.
2020-07-31 20:05:41 +05:30
Marcus f443edebd2
SOLR-14681: Introduce ability to delete .jar stored in the Package Store (#1702) 2020-07-31 18:23:18 +10:00
Christine Poerschke 2f155aa0c3 SOLR-14489: remove ReplicationHandler's deprecated "master.commitReserveDuration" use (in favour of "commitReserveDuration") 2020-07-29 10:23:17 +01:00
Jan Høydahl ebb5219b1b
SOLR-14671: Parsing dynamic ZK config sometimes cause NuberFormatException (#1701) 2020-07-29 10:33:02 +02:00
David Smiley a3624029ad
SOLR-14651: Metrics History could disable better (#1672)
* SolrRrdBackendFactory should not be created if history is disabled
* Disable MetricsHistoryHandler by default in tests
* Await shutdown of all executors
2020-07-28 16:46:27 -04:00
Erick Erickson 6bf5f4a87f SOLR-11868: CloudSolrClient.setIdField is confusing, it's really the routing field. Should be deprecated. 2020-07-26 18:18:05 -04:00
David Smiley 5295007022
SOLR-14652: SolrCore should hold its own CoreDescriptor (#1675)
(minor refactoring)
Also:
* SolrCore's constructors don't need a "name" since it's guaranteed to always be the name in the coreDescriptor.  I checked.
* SolrCore's constructor shouldn't call coreContainer.solrCores.addCoreDescriptor(cd); because it's the container's responsibility to manage such things.  I made SolrCores.putCore ensure the descriptor is added, and this is called by CoreContainer.registerCore which is called after new SolrCore instances are created.
* solrCore.setName should only be called when we expect the name to change.  Furthermore that shouldn't ever happen in SolrCloud so I added checks.
* solrCore.setName calls coreMetricManager.afterCoreSetName() which is something that is really only related to a rename, not name initialization (from the constructor).  I renamed that method and further only call it if the name did change from non-null.
2020-07-25 01:08:23 -04:00
Erick Erickson 4b2e90b3aa SOLR-11656: TLOG replication doesn't work properly after rebalancing leaders. 2020-07-24 13:10:35 -04:00
Atri Sharma ec007c4bf2
Use FileSystem.newInstance instead of FileSystem.get in HDFSBackupRepository (#1682)
FileSystem.get can cause FileSystem closed exceptions, especially with S3.
2020-07-24 09:57:58 +05:30
Erick Erickson 67da34ac3b SOLR-14676: Update commons-collections to 4.4 and use it in Solr 2020-07-23 17:09:15 -04:00
Jason Gerlowski 48e92ba9c7 SOLR-13205: Improve empty-string handling in SolrQueryParserBase
Contributed-By: pramodkumar9
2020-07-20 09:51:28 -04:00
Ishan Chattopadhyaya cc0c111949 SOLR-14656: Removing Autoscaling Framework
The following were removed:
 *  Autoscaling policy, triggers etc.
 *  withCollection handling
 *  UTILIZENODE command
 *  Sim framework
 *  Suggestions tab in UI
 *  Reference guide pages for autoscaling
 *  autoAddReplicas feature
 *  UTILIZENODE
2020-07-20 17:47:01 +05:30
Erick Erickson 1a7db1c9f5 SOLR-14653: Replace usages of org.apache.hadoop.fs.Path that are used to construct Zookeeper paths 2020-07-17 16:18:21 -04:00
Noble Paul 03d658a7bc
SOLR-14151 Make schema components load from packages (#1669) 2020-07-16 16:05:24 +10:00
Erick Erickson 9c2e7819ee SOLR-13939: Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort. Attmept to fix Windows disk full issues 2020-07-15 21:03:01 -04:00
Erick Erickson f3de646560 SOLR-13939: Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort (thread leaks) 2020-07-15 09:23:27 -04:00
Andrzej Bialecki a0488c1cf1 SOLR-14244: Remove ReplicaInfo. 2020-07-14 15:01:23 +02:00
Chris Hostetter e3c2a93edb SOLR-14635: re-enable test with better gatekeeping of expected 'ownership threads' and (nightly only) polling of 'locked/waiting threads' before making asserts 2020-07-13 12:29:04 -07:00
Atri Sharma a73dbdd877
Harden TestBuildingUpMemoryPressure (#1662)
Add better error message checking and finer mocks along with temporary logging which will be removed.
2020-07-13 15:02:59 +05:30
Erick Erickson c346881ad6 SOLR-13939: https://issues.apache.org/jira/browse/SOLR-13939 2020-07-12 22:41:08 -04:00
S N Munendra 8c9c0640cf
SOLR-11262: XML writer implements writeMap and writeIterator (#1665) 2020-07-13 11:21:14 +10:00
Chris Hostetter c20501a504 SOLR-13132: fix some small package visibility and javadoc glitches that were caught on backport by the java8/branch_8x precommit but slipped past the java11/master precommit 2020-07-09 21:05:13 -07:00
Michael Gibney 40e2122b5a SOLR-13132: JSON Facet perf improvements to support "sweeping" collection of "relatedness()"
This adds a lot of "under the covers" improvements to how JSON Faceting FacetField processors work, to enable
"sweeping" support when the SlotAcc used for sorting support it (currently just "relatedness()")

This is a squash commit of all changes on https://github.com/magibney/lucene-solr/tree/SOLR-13132
Up to and including ca7a8e0b39840d00af9022c048346a7d84bf280d.

Co-authored-by: Chris Hostetter <hossman@apache.org>
Co-authored-by: Michael Gibney <michael@michaelgibney.net>
2020-07-09 18:42:37 -07:00
Chris Hostetter 5a422db60e SOLR-14635: disable test that has silly concurrency assumptions 2020-07-09 18:23:22 -07:00
Chris Hostetter 5c6314a970 SOLR-14635: ThreadDumpHandler has been enhanced to show lock ownership 2020-07-09 12:13:02 -07:00
Mike Drob 2341c220ce
SOLR-11390 Trie* field javadocs to @see *Point (#1612)
Co-authored-by: Christine Poerschke <cpoerschke@apache.org>
2020-07-09 12:20:56 -05:00
Andrzej Bialecki cf742f4596 SOLR-12847: Remove support for maxShardsPerNode. 2020-07-08 17:57:24 +02:00
Jason Gerlowski 80f8ab717c
SOLR-14566: Add request-ID to all distrib-search requests (#1574) 2020-07-08 08:38:23 -04:00
Mike Drob d3f4b21deb
SOLR-10814 Add short-name feature to RuleBasedAuthz plugin
Additional-Author: Hrishikesh Gadre <hgadre@cloudera.com>
2020-07-07 11:37:50 -05:00
Andrzej Bialecki f19057f5e5 SOLR-14537: Fix inner class visibility, reduce diffs with branch_8x. 2020-07-07 16:46:39 +02:00
Cao Manh Dat a80eb84d56
SOLR-14354: HttpShardHandler send requests in async (#1470) 2020-07-07 09:17:26 +07:00
Ishan Chattopadhyaya 5fc12745ca SOLR-14599: Ref guide updates and some error handling fixes
* Ref guide section for types of plugins (that now includes a cluster level plugins section)
* Ref guide updates for deploying, undeploying, updating cluster level plugins
* Better error handling for cluster level plugin deployments
2020-07-07 07:39:45 +05:30
David Smiley 31e7ad9ee2
SOLR-14628: hl.fragsizeIsMinimum now defaults to true (#1651)
Fragments size like <= Solr 8.4 and addresses a significant performance regression
2020-07-06 09:31:37 -04:00
Chris Hostetter fea6c1b9da SOLR-14595: add AwaitsFix test to TestJsonFacetRefinement demonstrating problem, and work around to randomized testing in TestCloudJSONFacetSKGEquiv 2020-07-05 13:28:08 -07:00
noble 3642aa3d4e SOLR-14404: update was not working 2020-07-05 16:28:35 +10:00
Ishan Chattopadhyaya c3d6a8bf7a SOLR-14021: Deprecate HDFS support 2020-07-04 18:29:45 +05:30
Ishan Chattopadhyaya 35b5eea147 SOLR-14537: Fix gradle precommit failures 2020-07-04 14:31:23 +05:30
Erick Erickson e9568c3473 SOLR-10742: SolrCores.getNamesForCore is quite inefficient and blocks other core operations 2020-07-02 23:56:17 -04:00
Eric Pugh b50dd0c9c7
SOLR-14358 respond to feedback on URLClassifyProcessorFactory (#1632)
* Add an example explaining how to use

* fix up JavaDoc formatting

* Respond to feedback from @janhoy

Co-authored-by: ohtwadi <harinder.hanjan@gmail.com>
2020-07-02 15:16:24 -04:00
Andrzej Bialecki 1b8fb70216 SOLR-14537: Improve performance of ExportWriter. 2020-07-02 17:34:50 +02:00
Ishan Chattopadhyaya 7c593b1940 SOLR-14022: Deprecate CDCR 2020-07-02 16:29:29 +05:30
Atri Sharma 3f9cc227f1
SOLR-14588: Implement Circuit Breakers (#1626)
* SOLR-14588: Implement Circuit Breakers

This commit consists of two parts: add circuit breakers infrastructure and a "real" JVM heap memory based
circuit breaker which monitors incoming search requests and rejects them with SERVICE_TOO_BUSY error
if the defined threshold is breached, thus giving headroom to existing indexing and search requests
to complete.
2020-07-02 12:43:48 +05:30
Atri Sharma ccdfee2cf0 Remove Redundant Import in TestContainerPlugin 2020-07-02 12:24:05 +05:30
noblepaul 2e60e1fbbd SOLR-14404: Unregister was not working for plugins with $path-prefix 2020-07-02 15:44:16 +10:00
Erick Erickson d0864a19c7 SOLR-14523: Enhance gradle logging calls validation: eliminate getMessage() 2020-07-01 22:07:59 -04:00
Erick Erickson 76e1d901cb SOLR-14592: Upgrade Zookeeper to 3.6.1 2020-07-01 19:47:16 -04:00
Tomas Fernandez Lobbe 6eb7bc3b7b
SOLR-14590 : Add support for Lucene's FeatureField in Solr (#1620)
Add a new RankField type that internally creates a FeatureField
Add a new RankQParser that can create queries on the FeatureField
2020-06-30 11:15:36 -07:00