Commit Graph

34778 Commits

Author SHA1 Message Date
Ignacio Vera 14009f4424
LUCENE-9641: Support for spatial relationships in LatLonPoint (#2155)
Equivalent to LatLonShape, LatLonPoint can be queried now using spatial relationships.
2021-01-08 08:16:58 +01:00
David Smiley 4cb3ad4a1c
* SOLR-14923: Nested docs indexing perf & robustness (#2159)
* When the schema defines _root_, and you want to do atomic/partial updates...
** _root_ needn't be stored or have docValues any more
** _nest_path_ field isn't needed for this any more
** Simplified internal logic
* Allow (and recommend, eventually insist) that the _root_ field be passed for atomic/partial updates to child docs.
** In the absence of _root_, assume the _route_ param is equivalent to ameliorate back-compat scope.  This is a temporary hack; remove in SOLR-15064.
** One of the two is required; you'll get an exception if the assumption is false.  THIS IS A BACK-COMPAT CHANGE
* Ensure that the update log contains the _root_ field if it's defined in the schema; in some cases it wasn't.  It's important for robustness of atomic/partial updates to child docs.  Caveat: the buffer replay scenario is not tested with child docs.
* Limited the cases when a realtime searcher is re-opened.  It was being applied to any update that included child docs but now only some narrow subset: only for atomic/partial updates, and when the update log contains an in-place update for the same nest because it's complicated to resolve those log entries.
* Internal improvements to RealTimeGetComponent to aid clarity & robustness & probably performance...
** Use SolrDocumentFetcher.solrDoc(docID, ReturnFields) instead of more manual loading.  Will do more with this in another PR.
** Clarify when only root doc IDs are expected.
** Use Resolution enum more, add PARTIAL, remove DOC_WITH_CHILDREN; enhance docs.
** When have ReturnFields, a Set of "onlyTheseFields" becomes redundant.  Add a child doc resolution via a transformer when needed.
** Clarified where copy-field targets are removed
* NestPathField should default to single valued, instead of inheriting the schema default, which for ancient schemas was multi-valued.
* AddUpdateCommand.getLuceneDocument(s) methods are very internal; made package visible and refactored a bit for clarity
* DocumentBuilder: when in-place update, skip id and _root_ here, thus also simplifying further logic
* NestedShardedAtomicUpdateTest no longer extends AbstractFullDistribZkTestBase because it wasn't really leveraging the "control client" checking, and it added too much complexity to debug failures.
2021-01-07 23:23:20 -05:00
Michael Sokolov 8b4b1910c9 LUCENE-9658: add spotless formatting check to github precommit action 2021-01-07 14:42:36 -05:00
Christine Poerschke 60f2417aca
SOLR-15057: avoid unnecessary object retention in FacetRangeProcessor (#2160) 2021-01-07 18:45:46 +00:00
Munendra S N 6ff4a9b395 SOLR-14514: add extra checks for picking 'stream' method in JSON facet
missing, allBuckets, and numBuckets is not supported with stream method.
So, avoiding picking stream method when any one of them is enabled even if
facet sort is 'index asc'
2021-01-07 22:01:27 +05:30
Munendra S N d7fd3d8c20 SOLR-12539: handle extra spaces in JSON facet shorthand syntax 2021-01-07 22:01:27 +05:30
Munendra S N 0846da5c22 SOLR-14950: fix regenerating of copyfield with explicit src/dest matching dyn rule
CopyFields are regenerated in case of replace-field or replace-field-type.
While regenerating, source and destionation are checked against fields but source/dest
could match dynamic rule too.
For example,
<copyField source="something_s" dest="spellcheck"/>
<dynamicField name="*_s" type="string"/>
here, something_s is not present in schema but matches the dynamic rule.

To handle the above case, need to check dynamicFieldCache too while regenerating the
copyFields
2021-01-07 22:01:27 +05:30
Joel Bernstein 4ab5d31832 SOLR-15040: Update CHANGES.txt 2021-01-07 11:30:18 -05:00
Timothy Potter 8b55fb868d
SOLR-15059: Improve query performance monitoring (#2165) 2021-01-07 09:17:38 -07:00
S N Munendra d4fa1aae21
SOLR-10860: Return proper error code for bad input incase of inplace updates (#2121)
Return proper error code on invalid value with in-place update.
Handle invalid value for inc op with the in-place update, uses toNativeType to convert increment value instead of direct parsing. Also, return an error when inc operation is specified for the non-numeric field
2021-01-07 20:44:48 +05:30
Dawid Weiss 96aaf543af LUCENE-9652: follow-up code reformatting (tidy). 2021-01-07 10:59:21 +01:00
Dawid Weiss 0ab9cb8079 LUCENE-9658: temporarily hook up spotlessCheck to precommit. 2021-01-07 10:57:57 +01:00
David Smiley 3147625890
SOLR-15069: [child parentFilter=...] is now optional (#2181) 2021-01-06 17:43:15 -05:00
Michael Sokolov 7b9f875145
LUCENE-9652: DataInput.readLEFloats for use by Lucene90VectorReader (#2175) 2021-01-06 16:16:56 -05:00
Chris Hostetter 07071ca8e1 SOLR-15047: Fix collapse parser behavior when collapsing on numeric fields to differentiate '0' group from null group 2021-01-06 10:07:32 -07:00
Timothy Potter 2fcaba1ce2
SOLR-15058: Enforce node_name contains colon and port and find first underscore after colon to parse context (#2178) 2021-01-05 12:00:14 -07:00
Chris Hostetter a48e937f59 SOLR-15048: Fixed collapse parser behavior when dealing with docs boosted by QueryElevationComponent that are in the null group to treat them consistently regardless of collapse field type or group head selector 2021-01-05 10:00:56 -07:00
Florin Babes a677d2247a SOLR-14571: Download speed was hard-coded in the Replication screen of the Solr Admin UI.
(Florin Babes via Christine Poerschke)
2021-01-05 15:53:15 +00:00
Bruno Roustant 5e21e3f380
SOLR-15061: Fix NPE in SearchHandler when shards.info and no QueryComponent configured 2021-01-05 15:15:48 +01:00
Dawid Weiss 1bb9755e4a LUCENE-9570: code reformatting [record rev]. 2021-01-05 13:44:42 +01:00
Dawid Weiss 2cbf261032 LUCENE-9570: code reformatting [final]. 2021-01-05 13:44:05 +01:00
Andrzej Bialecki 2695624a9f SOLR-15019: Replica placement API needs a way to fetch existing replica metrics. 2021-01-04 15:24:25 +01:00
Christine Poerschke dc99e39d21 Update copyright year(s) in lucene/NOTICE.txt and solr/NOTICE.txt files. 2021-01-04 09:19:05 +00:00
Ignacio Vera ce667fdd2f
LUCENE-9642: Rotate triangle points before checking triangle orientation (#2154)
When encoding triangles in ShapeField, make sure generated triangles are CCW by rotating triangle points before checking triangle orientation.
2021-01-04 09:42:44 +01:00
noblepaul 3e852b00dd SOLR-15062: /api/cluster/zk/ls should give the stat of the current node 2021-01-04 14:10:28 +11:00
Noble Paul 3056296fa2
SOLR-15062: /api/cluster/zk/ls should give the stat of the current node (#2172) 2021-01-04 14:08:14 +11:00
Dawid Weiss 23e206d085 LUCENE-9570: code reformatting [record rev]. 2021-01-03 21:46:35 +01:00
Dawid Weiss 7f8b7ffbca LUCENE-9570: code reformatting [partial]. 2021-01-03 21:46:01 +01:00
Julie Tibshirani beb163c916
In ContextQuery, use a more comprehensive check for an empty prefix automaton. (#383)
Context queries check if the wrapped automaton is empty, and if so return an
empty automaton. This commit improves the check for empty automata, which
allows for handling an empty PrefixCompletionQuery as well.
2021-01-01 20:39:57 -08:00
Tim Dillon 17adcc7aa4
SOLR-14034: remove deprecated min_rf references (#2152) 2020-12-31 15:59:48 +00:00
Dawid Weiss 38c9d2ab76
LUCENE-9650: disable errorprone on jdk16+ (#2171) 2020-12-28 23:20:52 +01:00
Dawid Weiss 4160ceda2e LUCENE-9570: code reformatting [record rev]. 2020-12-28 12:26:41 +01:00
Dawid Weiss 8ef6a0da56 LUCENE-9570: code reformatting [partial]. 2020-12-28 12:26:13 +01:00
Dawid Weiss 9af588e71e Correct extra * in javadoc. 2020-12-28 12:25:25 +01:00
Dawid Weiss 409a0ac125
LUCENE-9643: git revisions for .git-blame-ignore-revs need to be full sha1, not abbreviated. (#2167) 2020-12-23 23:31:50 +01:00
Mike Drob ba8221098e
LUCENE-9647 Add back github action for Ant (#2163) 2020-12-23 14:22:57 -06:00
John Gallagher 70f461ee45
SOLR-14413 allow timeAllowed and cursorMark parameters
closes #1436
2020-12-23 13:01:44 -06:00
Dawid Weiss 8c234b2879 LUCENE-9570: code reformatting [record rev]. 2020-12-23 12:41:50 +01:00
Dawid Weiss 2d6ad2fee6 LUCENE-9570: code reformatting [partial]. 2020-12-23 12:41:23 +01:00
Pieter van Boxtel 98f12f4aeb
SOLR-15031 Prevent null being wrapped in a QueryValueSource
closes #2118
2020-12-22 15:34:18 -06:00
epugh@opensourceconnections.com 1b67ed9516 fix typos 2020-12-22 15:23:42 -05:00
Kevin Risden f0b73fdc6d
SOLR-14951: Upgrade Angular JS 1.7.9 to 1.8.0
Closes PR #2008
2020-12-22 11:18:44 -06:00
Dawid Weiss 39a39d7bce Remove accidentally checked-in local files. 2020-12-22 15:59:18 +01:00
Michael Sokolov e1cd426bce
LUCENE-9644: diversity heuristic for HNSW graph neighbor selection (#2157)
* Additional options to KnnGraphTester to support benchmarking with ann-benchmarks
 * switch to parallel array-based storage in HnswGraph (was using LongHeap)
2020-12-22 09:48:24 -05:00
Jason Gerlowski 8b272a0960
SOLR-15049: Add TopLevelJoinQuery optimization for 'self-joins' (#2146) 2020-12-22 08:32:52 -05:00
Mike McCandless d905a7ba8e LUCENE-9617: move CHANGES.txt entry to right place (9.0 -> 8.8.0) 2020-12-18 16:45:11 -05:00
msfroh 8e162e2670
LUCENE-9617: Reset lowestUnassignedFieldNumber in FieldNumbers.clear() (#2088)
* LUCENE-9617: Reset lowestUnassignedFieldNumber in FieldNumbers.clear()

FieldNumbers.clear() is called from IndexWriter.deleteAll(), which is
supposed to completely reset the state of the index. This includes
clearing all known fields.

Prior to this change, it would allocate progressively higher field
numbers, which results in larger and  larger arrays for
FieldInfos.byNumber, effectively "leaking" field numbers every time
deleteAll() is called.

Co-authored-by: Michael Froh <froh@amazon.com>
2020-12-18 16:30:33 -05:00
Adrien Grand 734c533cca LUCENE-9635: Move changes to the right section. 2020-12-18 16:07:29 +01:00
gf2121 00a5637457
LUCENE-9629: Use computed masks (#2113)
Co-authored-by: 郭峰 <guofeng.my@bytedance.com>
2020-12-18 15:59:40 +01:00
yiluncui 894b6b5c88
LUCENE-9635: BM25FQuery - Mask encoded norm long value in array lookup to avoid negative norms in long documents (#2138) 2020-12-18 15:56:31 +01:00