Commit Graph

34691 Commits

Author SHA1 Message Date
Mayya Sharipova 69de1a490f
LUCENE-9599 Disable sort optim on index sort (#2075)
Disable sort optimization in comparators on index sort.

Currently, if search sort is equal or a part of the index sort, we have
an early termination in TopFieldCollector.
But comparators are not aware of the index sort, and may run
sort optimization even if the search sort is congruent with
the index sort.

This patch:
- adds `disableSkipping` method to `FieldComparator`,
 This method is called by `TopFieldCollector`, and currently called 
  when  the search sort is congruent with the index sort,
  but more conditions can be added. 
- disables sort optimization in comparators in this case.
- removes a private  `MultiComparatorLeafCollector` class, because the only
  class that extends `MultiComparatorLeafCollector` was `TopFieldLeafCollector`.
  The logic of the deleted `TopFieldLeafCollector` is added to `TopFieldLeafCollector`.

Relates to #1351
2020-12-03 12:08:46 -05:00
Patrick Zhai f24b497c72
LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_DOCS returned (#2095)
* LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_DOCS is returned
2020-12-03 10:17:30 -05:00
Dawid Weiss a9e180b20a LUCENE-9631: Properly override slice() on subclasses of OffsetRange. 2020-12-03 10:55:33 +01:00
Timothy Potter 4c100a0175
SOLR-12182: Fix Changes.txt in master (#2116) 2020-12-02 17:28:19 -07:00
Chris Hostetter 5208d47e1a SOLR-14934: Remove redundent deprecated "solr.solr.home" logic 2020-12-02 17:18:58 -07:00
Jan Høydahl e3572d0c4d
Reconcile upgrade notes in master (#2103)
inspired by And fixes #2102
2020-12-02 23:28:02 +01:00
David Smiley d50bdbae83
Remove obsolete dev-tools scripts (#2105) 2020-12-02 16:04:40 -05:00
Chris Hostetter 05a8477a36 SOLR-14934: Fix some additional test helper methods that aren't used on master but triggered problems when when backporting to branch_8x 2020-12-02 13:35:33 -07:00
Chris Hostetter 8732df8c50 SOLR-14934: test workaround for SOLR-15026 2020-12-02 12:13:55 -07:00
Chris Hostetter 2e6a02394e SOLR-14934: Refactored duplicate "Solr Home" logic into a single place to eliminate risk of tests using divergent values for a single solr node. 2020-12-02 10:24:36 -07:00
Shalin Shekhar Mangar d99c1667a5
SOLR-14942: Move request registration to ContentStreamHandlerBase (#2112)
This addresses review feedback from David Smiley on Jira. It moves the request registration to the ContentStreamHandlerBase class instead of doing a hack-ish instanceof check inside HttpSolrCall.
2020-12-02 10:11:23 +05:30
Thomas Mortagne feb897a962
SOLR-15017: Core's lib/ dir was ignored sometimes (#2107)
A core's lib/ folder was ignored when the core's configuration did not define any <lib> element.  This is a regression introduced in 8.6 by SOLR-14197.
2020-12-01 15:40:21 -05:00
Ilan Ginzburg 3df72502cc
SOLR-15004: tests for the replica placement API + placement plugin fixes and light refactoring (#2110)
Co-authored-by: Andrzej Bialecki <ab@apache.org>
2020-12-01 20:07:08 +01:00
Simon Willnauer 663655d659 SOLR-15013: Prevent merges since test asserts doc order 2020-12-01 10:23:12 +01:00
Cassandra Targett 689e56fbe0 Ref Guide: fix wrong class name in CSS to toggle the icon shown in sidebar nav when a section is open 2020-11-30 15:50:13 -06:00
Timothy Potter a0492840ee
SOLR-12182: Don't persist base_url in ZK as the scheme is variable, compute from node_name instead (#2010) 2020-11-30 12:05:48 -07:00
Mike Drob cb5ba42bd7
SOLR-15009 Propogate IOException from DF.exists 2020-11-30 10:27:23 -08:00
Chris Hostetter 37a61635e1 SOLR-14958: Refactor zkHost config logic to make testing easier and reduce risk of incorrect value being used 2020-11-30 10:43:08 -07:00
gf2121 2da3d1fef4
fix duplicate compute on maxUnpatchedValue (#2106)
Co-authored-by: 郭峰 <guofeng.my@bytedance.com>
2020-11-30 13:35:15 +01:00
David Smiley 021de9f45f
SOLR-14915: Prometheus-exporter should not depend on Solr-core (#1972)
* Reduced dependencies from Solr server down to just SolrJ.  Don't add WEB-INF/lib.
* Was missing some dependencies in lib/; now has all except SolrJ & logging.
* Can run via gradle, "gradlew run"
* Has own log4j2.xml now

Has own CHANGES.md now.
2020-11-27 15:08:33 -05:00
David Smiley 1e0ae2fb74
SOLR-15001 Docker: require init_var_solr.sh (#2083)
The Dockerfile should not initialize /var/solr's contents because this is confusing and redundant with init_var_solr.sh.
No need for init_var_solr.sh to echo what it does; VERBOSE can be used to accomplish that.

Separate CHANGES.md for Docker and contrib modules.
2020-11-27 14:59:54 -05:00
Jan Høydahl 99c38eee49
SOLR-14851 Http2SolrClient doesn't handle keystore type (#2098)
Signed-off-by: Jan Høydahl <janhoy@apache.org>
Co-authored-by: Andras Salamon <andras.salamon@melda.info>
2020-11-27 16:11:29 +01:00
Ignacio Vera b63c37d1e8
LUCENE-9606: Wrap boolean queries generated by shape fields with a Constant score query (#2093) 2020-11-25 08:40:38 +01:00
Simon Willnauer c71f119e9a
LUCENE-9508: Fix DocumentsWriter to block threads until unstalled (#2085)
DWStallControl expects the caller to loop on top of the wait call to make
progress with flushing if the DW is stalled. This logic wasn't applied such that
DW only stalled for one second and then released the indexing thread. This can cause
OOM if for instance during a full flush one DWPT gets stuck and onther threads keep on
indexing.
2020-11-24 13:05:21 +01:00
Alessandro Benedetti 7d54c28958 Merge remote-tracking branch 'origin/master' 2020-11-24 10:16:05 +00:00
Alessandro Benedetti ca040402d9 SOLR-15015: added support to parametric Interleaving algorithm (#2096) 2020-11-24 10:14:38 +00:00
Alessandro Benedetti 4d05e72eba
[SOLR-15015] added support to parametric Interleaving algorithm + tests (#2096) 2020-11-24 10:11:08 +00:00
Ignacio Vera 44be9f903d
LUCENE-9595: Make Component2D#withinPoint implementations consistent with ShapeQuery logic (#2059) 2020-11-23 09:36:35 +01:00
jimczi a5d0654a24 LUCENE-9581: Japanese tokenizer should discard the compound token instead of disabling the decomposition of long tokens when discardCompoundToken is activated. 2020-11-23 08:55:36 +01:00
Erick Erickson 77a205387f SOLR-14993: Unable to download zookeeper files of 1byte in size 2020-11-22 09:23:44 -05:00
Julie Tibshirani 8c7b709c08
LUCENE-9592: Loosen equality checks in TestVectorUtil. (#2084)
TestVectorUtil occasionally fails because of floating point errors. This
change slightly increases the epsilon in equality checks -- testing shows that
this will greatly decrease the chance of failure.
2020-11-19 19:05:04 -08:00
Christine Poerschke c4d4767bca SOLR-14035: Remove deprecated preferLocalShards=true support in favour of the shards.preference=replica.location:local alternative.
(Alex Bulygin via Christine Poerschke)
2020-11-19 17:57:47 +00:00
Alessandro Benedetti af0455ac83
SOLR-14560: Interleaving for Learning To Rank (#1571)
SOLR-14560: Add interleaving support in Learning To Rank
2020-11-18 18:15:24 +00:00
Cassandra Targett ea4dd0580f SOLR-14792: remove leftover /browse UI screenshot from ref guide docs 2020-11-17 15:00:38 -06:00
Michael Sokolov cb0d0cf0d1 Use h2 for top-level headers in HnswGraph javadoc, following jdk14 rule 2020-11-17 15:00:29 -05:00
Cassandra Targett 2b5b0f999c SOLR-14683: move "Missing Metrics" section down to config section; add short blurb to intro text 2020-11-17 11:58:09 -06:00
Michael Sokolov 02514e5bd6 Remove h3 from HnswGraph javadoc; doclet doesn't seem to like it 2020-11-17 09:37:25 -05:00
Marcus b9a93cf695
LUCENE-8626: Standardize Lucene test file naming Part 2 (#2053) 2020-11-17 08:13:13 -05:00
Adrien Grand 4735b4c12f LUCENE-9378: Fix test failure. 2020-11-17 09:41:51 +01:00
Tomoko Uchida 8503efdcff
LUCENE-9413: Add CJKWidthCharFilter and its factory. (#2081) 2020-11-17 17:32:10 +09:00
Nazerke Seidan 2d583eaba7
SOLR-14998: logging: info->debug in CollectionsHandler (#2079)
Because it's almost always redundant with HttpSolrCall's admin request log.
Co-authored-by: Nazerke Seidan <nseidan@salesforce.com>
2020-11-16 16:59:31 -05:00
Dawid Weiss fd3ffd0d38 LUCENE-8982: make native builds disabled by default (CI complains). 2020-11-16 17:23:21 +01:00
Noble Paul 73d5e7ae77
SOLR-14977 : ContainerPlugins should be configurable (#2065) 2020-11-17 00:19:50 +11:00
zacharymorn ebc87a8a27
LUCENE-8982: Separate out native code to another module to allow cpp build with gradle (#2068)
* LUCENE-8982: Separate out native code to another module to allow cpp build with gradle
2020-11-16 09:40:03 +01:00
Michael Sokolov 3ae0ca23d9 LUCENE-9610: fix bug in previous test fix 2020-11-15 12:46:16 +00:00
Michael Sokolov 09f78e2927 LUCENE-9610: fix TestKnnGraph.testMerge 2020-11-14 10:47:17 -05:00
Robert Muir 52f581e351
LUCENE-9605: update snowball to d8cf01ddf37a, adds Yiddish (#2077) 2020-11-14 09:27:08 -05:00
Erick Erickson 93ecd0fa0a SOLR-14986: Add warning to ref guide that using 'properties.name' is an expert option 2020-11-14 09:04:59 -05:00
Michael Sokolov 03c1910bff LUCENE-9004: CHANGES.txt entry 2020-11-13 09:05:17 -05:00
Michael Sokolov b36b4af22b
LUCENE-9004: KNN vector search using NSW graphs (#2022) 2020-11-13 08:53:51 -05:00