Commit Graph

8661 Commits

Author SHA1 Message Date
Thomas Mortagne feb897a962
SOLR-15017: Core's lib/ dir was ignored sometimes (#2107)
A core's lib/ folder was ignored when the core's configuration did not define any <lib> element.  This is a regression introduced in 8.6 by SOLR-14197.
2020-12-01 15:40:21 -05:00
Ilan Ginzburg 3df72502cc
SOLR-15004: tests for the replica placement API + placement plugin fixes and light refactoring (#2110)
Co-authored-by: Andrzej Bialecki <ab@apache.org>
2020-12-01 20:07:08 +01:00
Simon Willnauer 663655d659 SOLR-15013: Prevent merges since test asserts doc order 2020-12-01 10:23:12 +01:00
Timothy Potter a0492840ee
SOLR-12182: Don't persist base_url in ZK as the scheme is variable, compute from node_name instead (#2010) 2020-11-30 12:05:48 -07:00
Mike Drob cb5ba42bd7
SOLR-15009 Propogate IOException from DF.exists 2020-11-30 10:27:23 -08:00
Chris Hostetter 37a61635e1 SOLR-14958: Refactor zkHost config logic to make testing easier and reduce risk of incorrect value being used 2020-11-30 10:43:08 -07:00
Marcus b9a93cf695
LUCENE-8626: Standardize Lucene test file naming Part 2 (#2053) 2020-11-17 08:13:13 -05:00
Nazerke Seidan 2d583eaba7
SOLR-14998: logging: info->debug in CollectionsHandler (#2079)
Because it's almost always redundant with HttpSolrCall's admin request log.
Co-authored-by: Nazerke Seidan <nseidan@salesforce.com>
2020-11-16 16:59:31 -05:00
Noble Paul 73d5e7ae77
SOLR-14977 : ContainerPlugins should be configurable (#2065) 2020-11-17 00:19:50 +11:00
Adrien Grand 06877b2c6e
LUCENE-9378: Make it possible to configure how to trade speed for compression on doc values. (#2069)
This adds a switch to `Lucene80DocValuesFormat` which allows to
configure whether to prioritize retrieval speed over compression ratio
or the other way around. When prioritizing retrieval speed, binary doc
values are written using the exact same format as before more aggressive
compression got introduced.
2020-11-12 16:10:00 +01:00
Christine Poerschke 2f02040a4c SOLR-14983: Fix response returning original score instead of reranked score due to query and filter combining.
(Krishan Goyal, Jason Baik, Christine Poerschke)
2020-11-12 12:51:21 +00:00
Jason Gerlowski a7197ac0ce
SOLR-14971: Handle atomic-removes on uncommitted docs (#2056)
Docs fetched from the update log via RTG look different than docs
fetched from commits in the index: the types of
field-values may be different between the two, etc.

This is a problem for atomic add/remove of field values, where matching
existing values has historically been done by object equals() calls (via
Collection operations).  This relies on equality checks which don't have
flexible enough semantics to match values across these different types.
(For example, `new Long(1).equals(new Integer(1))` returns `false`).
This was causing some add-distinct and remove operations on
uncommitted values to silently fail to remove field values.

This commit patches over this by converting between types in the more
common cases before using the fallback behavior.
2020-11-11 12:28:11 -05:00
Bruno Roustant 67f9245ce3
SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.
Also optimize getCoreDescriptors.
2020-11-11 11:37:45 +01:00
Andrzej Bialecki 863a388fe7 SOLR-14683: Move the CHANGES.txt entry to the right place. Fix wrong type of null value. 2020-11-10 17:58:45 +01:00
Tomoko Uchida d1110394e9
LUCENE-9600: Clean up package name conflicts between misc and core modules (#2064) 2020-11-10 22:24:48 +09:00
Andrzej Bialecki 7ec17376be SOLR-14683: Metrics API should ensure consistent placeholders for missing values. 2020-11-10 11:48:59 +01:00
Adrien Grand bac4309326 SOLR-14749: Use h2 instead of h3 so that the javadoc tool doesn't complain about out-or-sequence headers. 2020-11-10 09:22:34 +01:00
Adrien Grand 514c363f1d LUCENE-9322: Move Solr to Lucene90Codec.
And drop configurability of Lucene87Codec since it shouldn't be used for writing anymore.
2020-11-10 09:22:34 +01:00
Erick Erickson be19432b75 SOLR-14969: Prevent creating multiple cores with the same name which leads to instabilities (race condition) changed error code 2020-11-09 08:16:43 -05:00
Andrzej Bialecki bdc6e8247f SOLR-14749: Provide a clean API for cluster-level event processing. 2020-11-05 12:18:05 +01:00
Tomoko Uchida 6a7131ee24
LUCENE-9319: Clean up package name conflicts for sandbox module (#2023) 2020-11-03 12:01:02 +09:00
Houston Putman 5091e75c9d
SOLR-14907: Adding V2 API for ConfigSet Upload. (#1996) 2020-11-02 14:06:45 -05:00
Christine Poerschke 0729746d77
Rename TestSolrTestCaseJ4 to SolrTestCaseJ4DeleteCoreTest. (#2032) 2020-11-02 16:13:01 +00:00
Erick Erickson 2c49c4a27d SOLR-14969: Prevent creating multiple cores with the same name which leads to instabilities (race condition) 2020-10-31 19:34:09 -04:00
S N Munendra f3fdd9b90b
SOLR-14946: fix responseHeader returned in resp with omitHeader=true (#2029)
* This occurs when BinaryResponseWriter#getParsedResponse is called as
  it doesn't check for omitHeader.
2020-10-30 18:50:18 +05:30
Eric Pugh d0ba0f38a9
Enhance Javadocs for ExternalFileField on how to return values as part of document fields. SOLR-14968
* add helpful documentation on returning the field value

* wordsmith
2020-10-29 12:38:41 -04:00
Anver Sotnikov 6d00843d97 SOLR-14940: Fix ReplicationHandler memory leak through SolrCore.closeHooks
* Added ability to remove SolrCore.closeHooks
* Keep references to CloseHooks in ReplicationHandler and remove them on ReplicationHandler.shutdown()

closes #1997
2020-10-27 16:03:43 -05:00
Ilan Ginzburg b649f3f40d
SOLR-14964: remove Autoscaling related withCollection and COLOCATED_WITH (#2034)
Part of SOLR-14656 (remove Autoscalin)
2020-10-26 19:10:49 +01:00
Christine Poerschke 4bf254158a
Rename ConfigSetsAPITest to TestConfigSetsAPIShareSchema (#1890) 2020-10-26 09:45:13 +00:00
Christine Poerschke 7a09cc1d49
SOLR-14937: Correct client.queryDefaults().set(...) calls in some JSON facet tests. (#1987) 2020-10-26 09:43:56 +00:00
Shalin Shekhar Mangar 706f284c46
SOLR-14942: Reduce leader election time on node shutdown (#2004)
The shutdown process waits for all replicas/cores to be closed before removing the election node of the leader. This can take some time due to index flush or merge activities on the leader cores and delays new leaders from being elected. Moreover, jetty stops accepting new requests on receiving SIGTERM which means that even though a leader technically exists, no new indexing requests can be processed by the node. This commit waits for all in-flight indexing requests to complete, removes election nodes (thus triggering leader election) and then closes all replicas.

Co-authored-by: Cao Manh Dat <datcm@apache.org>
2020-10-24 17:39:00 +05:30
Michael Sokolov 840a353bc7
LUCENE-9582: rename VectorValues.ScoreFunction to SearchStrategy (#2018)
Co-authored-by: Julie Tibshirani
2020-10-23 17:39:34 -04:00
Noble Paul 052efd62ae Revert "refactor method names"
This reverts commit e826b1f344.

accidental commite reverted
2020-10-22 15:25:31 +11:00
Noble Paul e826b1f344 refactor method names 2020-10-22 12:35:47 +11:00
Andrzej Bialecki 67ecd8ff9a SOLR-14749: Improve support for arbitrary container-level plugins. Add ClusterSingleton
support for plugins that require only one active instance in the cluster.
2020-10-21 17:22:44 +02:00
Tomoko Uchida 44c1bd42c5
LUCENE-9318: Clean up package name conflicts for backward-codecs (#2000) 2020-10-19 21:32:06 +09:00
Andrzej Bialecki 9ab9d208c7 SOLR-14944: Remove the "spins" metrics. 2020-10-19 11:50:08 +02:00
Michael Sokolov c02f07f2d5 LUCENE-9322: Add Lucene90 codec, including VectorFormat
This commit adds support for dense floating point VectorFields.
The new VectorValues class provides access to the indexed vectors.
2020-10-18 07:49:36 -04:00
Robert Muir 85b58c262a
LUCENE-9576: nuke SSD detection, modernize CMS defaults 2020-10-17 10:55:35 -04:00
Munendra S N 0bd2f314b7 SOLR-14930: fix precommit 2020-10-15 18:19:14 +05:30
Andrzej Bialecki 737cf9854a SOLR-14924: Some ReplicationHandler metrics are reported using incorrect types. 2020-10-15 14:27:51 +02:00
Noble Paul 321b4fa0de
SOLR-14930: Deprecate rulebased replica placement strategy (remove in 9.0) (#1980) 2020-10-15 19:53:43 +11:00
Andrzej Bialecki 2a3da99e2d SOLR-14914: Add option to disable metrics collection. 2020-10-15 10:14:16 +02:00
S N Munendra b43c389386
Include missing commands in package tool help section (#1975)
* feat(package/tool): include uninstall command usage in help

* feat(package/tool): include add-key usage in help

* feat(package/tool): display options for package tool
2020-10-14 22:11:54 +05:30
Bar Rotstein fa3e1ad71f SOLR-14869: ChildDocTransformer should have omitted deleted child documents.
Closes #1970
2020-10-14 08:25:52 -04:00
Noble Paul 2f651b156c SOLR-14654: remove all references of runtime lib 2020-10-14 11:13:38 +11:00
Houston Putman bcd9cbec95
SOLR-14907: Support single file upload/overwrite in configSet API (#1977) 2020-10-13 16:51:21 -04:00
Cao Manh Dat 9594ab3ac0
SOLR-14776: Precompute the fingerprint during PeerSync (#1814)
After heavy indexing, the call to compute fingerprint takes awhile and slows the leader election. This commit computes the fingerprint in parallel with fetching the fingerprint from the other replicas.

Co-authored-by: Shalin Shekhar Mangar <shalin@apache.org>
2020-10-13 16:35:33 +05:30
David Smiley ab83b3b7c3
SOLR-14917: Move DOMUtil and PropertiesUtil to SolrJ (#1953) 2020-10-10 08:52:10 -04:00
Noble Paul 8c41418c0f
SOLR-14576 : Do not use SolrCore as keys in a WeakHashMap (#1586) 2020-10-08 22:08:48 +11:00
Andrzej Bialecki 43b1a2fdc7 SOLR-14691: Metrics reporting should avoid creating objects. 2020-10-07 17:52:55 +02:00
Cao Manh Dat 2d4a51b23d SOLR-10370: ReplicationHandler should fetch index at fixed delay instead of fixed rate 2020-10-07 20:22:17 +07:00
noblepaul 2a8136b3fd SOLR-14151: refactor to avoid code duplicate 2020-10-07 16:04:35 +11:00
Timothy Potter e879a52291
SOLR-14659: Remove restlet as dependency for the ManagedResource API (#1938)
Co-authored-by: noblepaul <noble.paul@gmail.com>
2020-10-04 11:21:49 -06:00
noblepaul 4728a710e9 LUCENE-9559: "gradle eclipse" do not work if .java files are not in proper package 2020-10-04 21:44:01 +11:00
Erick Erickson f6c4f8a755 SOLR-14910: Use in-line tags for logger declarations in Gradle ValidateLogCalls that are non-standard, change //logok to //nowarn 2020-10-03 09:47:37 -04:00
Tomas Fernandez Lobbe 8f2f80bbb3 SOLR-14663: Copy ConfigSet root data from base ConfigSet when using CREATE command 2020-10-01 14:13:40 -07:00
David Smiley 6c3b1aa5ca
SOLR-12987: Fix precommit 2020-10-01 17:02:38 -04:00
David Smiley 9cadbf04b6
SOLR-12987: Deprecated plugins are logged once and with log category org.apache.solr.DEPRECATED (#1927) 2020-10-01 08:31:39 -04:00
Bruno Roustant 167c3050df
SOLR-14905: Upgrade commons-io version to 2.8.0.
Closes #1934
2020-10-01 10:07:42 +02:00
Munendra S N 274a3d69d2 Revert "SOLR-14767 : Fix NumberFormatException when int/long field value is floating num"
This reverts commit 63f0b6b706.
2020-09-29 23:53:13 +05:30
Chris Hostetter 8c7502dfeb SOLR-14898: Stop returning duplicate HTTP response headers when requests are forward to another node 2020-09-29 09:19:03 -07:00
Munendra S N 3dcb19f886 SOLR-14897: limit no of forwarding for given request
* Irrespective of active or down replicas, restrict no of forwarding of request.
  Previously, this restriction was applied only if active is not found
2020-09-29 19:48:12 +05:30
Apoorv Bhawsar 63f0b6b706
SOLR-14767 : Fix NumberFormatException when int/long field value is floating num (#1775) 2020-09-29 19:23:33 +05:30
Guna Sekhar Dora Kovvuru 1dba76c0d3
SOLR-14333: Implement toString in Collapse filter (#1371) 2020-09-29 19:19:49 +05:30
noble a65e9dd311 SOLR-14151: cleanup 2020-09-29 15:37:47 +10:00
noble 01da67c728 SOLR-14901: TestPackages uses binary precompiled classes to refer to analysis factory FQCNs 2020-09-29 15:25:22 +10:00
Andrzej Bialecki 32041c8d9b SOLR-14850: Fix ExactStatsCache NullPointerException when shards.tolerant=true. 2020-09-28 14:04:48 +02:00
Atri Sharma 4105414c90
SOLR-13528: Implement API Based Config For Rate Limiters (#1906)
This commit moves Rate Limiter configurations from web.xml to a new command based approach using clusterprops.json
2020-09-28 14:57:06 +05:30
Tomoko Uchida 5e617ccc33
LUCENE-9317: Clean up split package in analyzers-common (#1836) 2020-09-28 16:49:28 +09:00
Munendra S N ddd10725b0 SOLR-14503: use specified waitForZk val as conn timeout for zk
* Also, consume SOLR_WAIT_FOR_ZK in bin/solr.cmd
2020-09-24 22:28:04 +05:30
S N Munendra ac58472310
SOLR-14036: Remove explicit distrib=false from /terms handler (#1900)
* Remove distrib=false from /terms handler so that terms are returned from across all shards instead of a single local shard.
* cleanup shards parameter handling in TermsComponent. This is handled in HttpShardHandler
* Remove redundant tests for shard whitelist
* remove redundant terms params from ScoreNodeStream
2020-09-24 22:12:24 +05:30
noblepaul cafa449769 SOLR-14613: Avoid multiple ZK write 2020-09-24 17:26:41 +10:00
noblepaul 26bb6415d1 SOLR-14894: ASL header 2020-09-24 12:40:05 +10:00
noblepaul 565c5b1ac4 SOLR-14894: Use annotations to implement V2 collection APIs 2020-09-24 12:37:12 +10:00
noblepaul 1c9c1509fa SOLR-14890: syncing with 8x 2020-09-24 10:58:40 +10:00
Noble Paul fd0c08615d
SOLR-14890: Refactor code to use annotations for configset API (#1911) 2020-09-23 21:55:51 +10:00
David Smiley 7b53671920
SOLR-14768: Fix multipart POST to Solr. (#1838)
Regression from 8.6
Multipart POST would fail due to a NoClassDefFoundError of Jetty MultiPart.  Solr cannot access many Jetty classes, which is not noticeable in our tests.
2020-09-22 17:42:18 -04:00
David Smiley 2197776be6
SOLR-13181: param macro expansion could throw (#1877)
...StringIndexOutOfBoundsException on bad syntax
* failOnMissingParams: should have been returning null (failing) on bad syntax cases

Co-authored-by: Christine Poerschke <cpoerschke@apache.org>
2020-09-22 15:46:59 -04:00
Tomas Fernandez Lobbe 7b7a5a16ce
SOLR-10391: Add overwrite option to UPLOAD ConfigSet action (#1861)
When set to true, Solr will overwrite an existing configset in ZooKeeper in an UPLOAD.
A new cleanup parameter can also be passed to let Solr know what to do with the files that existed in the old configset, but no longer exist in the new configset (remove or keep)
2020-09-22 10:36:59 -07:00
Alexandre Rafalovitch 1611586417
SOLR-14880: Support coreRootDirectory setting when create new cores from command line, in standalone mode
Update to match latest code with shorter name
2020-09-22 09:02:14 -04:00
Alexandre Rafalovitch 91b6223f38
SOLR-14878: Expose coreRootDirectory via API (Correction to make name shorter and always return value) 2020-09-21 22:56:08 -04:00
noblepaul 4087958d31 SOLR-14884: TestContainerPlugin.testApiFromPackage jenkins failures 2020-09-22 11:20:49 +10:00
Tomas Fernandez Lobbe f1921b99b4
Improve TestConfigSetsAPI (#1892)
* Replace Auth plugin with mocks

* Remove unused password param

* Start cluster only once

* Use SolrCloudTestCase

* Use MiniSolrCloudCluster's methods to remove collections and configsets
2020-09-21 10:03:47 -07:00
Jason Gerlowski 9a6ca2dcd0 SOLR-14859: Set fieldType defaults for DateRangeField
AbstractSpatialPrefixTreeFieldType (and its children) create index
fields based on a prototype with options frozen in PrefixTreeStrategy,
regardless of options specified in the schema.  This works fine most of
the time, but causes problems when QParsers or other query optimization
logic makes decisions based on these options (which are potentially out
of sync with the underlying index data).  Most commonly this causes
issues with "exists" (e.g. [* TO *]) queries.

This commit enforces fieldType defaults that line up with the 'hardcoded'
FieldType used by PrefixTreeStrategy.  Options on either the fieldType
or the field itself which contradict these defaults will result in
exceptions at schema load/modification time.
2020-09-21 12:57:08 -04:00
Alexandre Rafalovitch da2714cb86
SOLR-9607: Finalize move of Terms component and request handler into the implicit definitions (#1897)
* Updated implicit definition with terms=true, distrib=false
* Commented out terms handler with notice, as this is the config used in tests
* Remove spurious mentions cluttering other test configs
* Remove implicit terms=true param
* Remove definitions from shipped configsets
* Improve documentation
* Add CHANGES record
2020-09-21 09:05:37 -04:00
noblepaul 73c06e35e8 SOLR-14881: ManagedSchemaRoundRobinCloudTest test failures 2020-09-21 15:08:23 +10:00
noblepaul 64ca559042 SOLR-14879: address TestPackages test failures 2020-09-21 14:55:54 +10:00
Tom Edge fa756b1c31
SOLR-14802: geodist: Support most spatial field types as an arg
FunctionQParser: overload parseValueSourceList with flags
2020-09-20 23:19:48 -04:00
Noble Paul 3664182d24
SOLR-14879: address TestPackages test failures (#1895) 2020-09-20 13:01:47 +10:00
Alexandre Rafalovitch f6e8bc8c31
SOLR-14878: Expose solr.xml's coreRootDirectory property via the System Settings API (#1894) 2020-09-19 22:07:03 -04:00
Dawid Weiss 5ec2bac91c
LUCENE-9531: Consolidate duplicated generated classes CharStream and FastCharStream (#1886) 2020-09-18 08:53:30 +02:00
Noble Paul ee0a374bb8
SOLR-14875: Make SolrEventListeners load from packages (#1887) 2020-09-18 12:07:29 +10:00
Ilan Ginzburg dbba48b3e5
SOLR-14613: use set-placement-plugin for both setting and unsetting plugin config 2020-09-17 15:01:19 +02:00
Dawid Weiss 6c9d7adf79
LUCENE-9527: upgrade javacc to 7.0.4 (#1884) 2020-09-17 13:29:18 +02:00
noblepaul 515608a087 SOLR-14151: fixed the classloading issue 2020-09-17 19:10:04 +10:00
Dawid Weiss 4f344cb0d4
LUCENE-9530: cleaned up javacc gradle generation scripts. (#1883)
* LUCENE-9530: cleaned up gradle javacc generation/ tweaks script so that it's consistent across runs. Removed ant remnants.
2020-09-17 10:53:02 +02:00
noblepaul cbb1659640 Revert "Revert "SOLR-14151: Bug fixes (#1815)""
This reverts commit 27a14fe481.

Undoing accidental commit
2020-09-17 11:19:21 +10:00
noblepaul e5d3e4d567 Merge branch 'master' of github.com:apache/lucene-solr 2020-09-17 09:06:48 +10:00
Ilan Ginzburg c7d234cafd
SOLR-14613: Autoscaling replacement using placement plugins
Allow using placement plugins to compute replica placement on the cluster for Collection API calls.
This is the first code drop for the replacement of the Autoscaling feature.
Javadoc of sample plugin org.apache.solr.cluster.placement.plugins.SamplePluginAffinityReplicaPlacement details how to enable this replica placement strategy.
PR's #1684 then #1845
2020-09-17 00:10:31 +02:00