Commit Graph

12029 Commits

Author SHA1 Message Date
Simon Willnauer 4d46caa05d
LUCENE-9515: Detach DWPT from DefaultIndexingChain (#1848)
This change removes the DWPT dependency from DefaultIndexingChain
and rather passes on the primitives needed for creating the chain.
2020-09-14 09:46:56 +02:00
Dawid Weiss 41c5c030aa LUCENE-9521: temporarily disable the offending test. 2020-09-14 09:39:19 +02:00
Julie Tibshirani 37e4dbef6d
LUCENE-9501: Fix invariant violation in IndexSortSortedNumericDocValuesRangeQuery. (#1833)
Previously the DocIdSetIterator returned an old value for docID advance
returned NO_MORE_DOCS. This violates the DocIdSetIterator contract and made it
possiblefor the iterator's advance method to be called even after it was
already exhausted.
2020-09-10 15:02:18 -04:00
Dawid Weiss 59d83428bc
LUCENE-9519: Correct behavior for highlights that cross multi-value boundaries (#1853) 2020-09-10 16:15:51 +02:00
Dawid Weiss e2f3f626ee
LUCENE-9464: Add high(er)-level hit highlighter example that demonstrates and uses low-level components (#1820) 2020-09-10 13:17:13 +02:00
Uwe Schindler 8debc9d0c2
LUCENE-9517: Don't subclass Deflater and instead create a patch for setDictionary() using a functional interface (#1850) 2020-09-10 11:12:59 +02:00
Uwe Schindler 8b9f7cac3a Remove extra line after merge 2020-09-09 19:05:56 +02:00
Uwe Schindler f0d3bab321
LUCENE-9512: Move LockFactory stress test to be a unit/integration test (#1842)
Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
2020-09-09 18:42:30 +02:00
Frank Zhu 2e4fc14e62 use seconds instead of millisecs
It's a minor mistake and it doesn't affect the output due to the scale change (It will just make PAST_HOUR, PAST_SIX_HOURS not as intended). Still it's better to be correct.
2020-09-09 10:24:02 -04:00
Ignacio Vera 7da15706da
LUCENE-9470: make TestXYMultiPolygonShapeQueries more resilient for CONTAINS queries (#1776) 2020-09-09 16:06:25 +02:00
Uwe Schindler dbf06dedfc fix imports 2020-09-09 01:01:05 +02:00
Uwe Schindler 3b47871c22 Assume no longer needed as bug no longer affects Java 11 2020-09-09 00:44:58 +02:00
Mayya Sharipova 99220677fe
LUCENE-9449 Skip docs with _doc sort and "after" (#1725)
- Enhance DocComparator to provide an iterator over competitive
documents when searching with "after". This iterator can quickly position
on the desired "after" document skipping all documents and segments before
"after".

- Redesign numeric comparators to provide skipping functionality
by default.

Relates to LUCENE-9280
2020-09-08 14:16:27 -04:00
Simon Willnauer 98e55f0ea8
LUCENE-9511: Include StoredFieldsWriter in DWPT accounting (#1839)
StoredFieldsWriter might consume some heap space memory that
can have a significant impact on decisions made in the IW if
writers should be stalled or DWPTs should be flushed if memory
settings are small in IWC and flushes are frequent. This change adds
RAM accounting to the StoredFieldsWriter since it's part of the
DWPT lifecycle and not just present during flush.
2020-09-08 18:18:13 +02:00
Mike Drob a46316e156
Clean up many small fixes (#1732)
* Abstract classes don't need public constructors since they can only be
  called by subclasses
* Don't escape html characters in @code tags in javadoc
* Fixed a few int/long arithmetic
* Use explicit Term.toString instead of implicit byte[].toString
* Javadoc typos
* Consistent capitalization for field and parameter names
2020-09-08 10:27:53 -05:00
Mike Drob 4c5c8c4ead
LUCENE-9504 Remove extra lock in DocumentsWriterDeleteQueue (#1826) 2020-09-08 10:13:18 -05:00
Ignacio Vera 59b17366ff
LUCENE-9292: Refactor BKD point configuration into its own class (#1697) 2020-09-08 09:03:41 +02:00
Varun Thacker f7cbde2ad8
Update CHANGES.txt
LUCENE-9497 is only for master ( since it's a gradle plugin )
2020-09-07 20:21:57 -07:00
Varun Thacker 121b262389
LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation (#1816)
LUCENE-9497:  Integrate Error Prone, a static analysis tool during compilation
2020-09-07 14:42:48 -07:00
Tomoko Uchida 51484e138b
LUCENE-9509: Refine lucene/BUILD.md and top-level README (for newdevs) (#1835) 2020-09-07 19:08:38 +09:00
LWY 1606a76187
LUCENE-9482: Fix deletion count error message 2020-09-06 11:10:51 -04:00
Mike Drob 6c94ca9cb3
LUCENE-9451 Sort.rewrite does not always return this when unchanged (#1731) 2020-09-04 09:46:03 -05:00
Uwe Schindler 99df3814ab
LUCENE-9500: Separate the Deflater hack from the Lucene code to a subclass of java.util.zip.Deflater (#1824) 2020-09-03 17:00:26 +02:00
Simon Willnauer 430a43520a
LUCENE-9484: Allow sorting an index after the fact (#1789)
Today we need to decide on an index sorting before we create the index.
In some situations it might make a lot of sense to sort an index afterwards
when the index doesn't change anymore or to compress older indices.
This change adds the ability to wrap readers from an unsorted index and merge it
into a sorted index by using IW#addIndices.
2020-09-03 12:54:40 +02:00
Adrien Grand 73371cb4b6 LUCENE-9486: Fix TestTieredMergePolicy failure. 2020-09-03 12:48:26 +02:00
Adrien Grand 27aa5c5f59
LUCENE-9486: Use preset dictionaries with LZ4 for BEST_SPEED. (#1793) 2020-09-03 12:17:04 +02:00
Julie Tibshirani 4fa4329287
Improve how Asserting* classes handle singleton doc values. (#1817)
Some queries use DocValues.unwrapSingleton to execute different logic for
single-valued doc values. When tests use an AssertingLeafReader, unwrapSingleton
will never unwrap the doc values, as they don't have the expected class. So some
queries have code paths that are never exercised with an AssertingLeafReader.

This change makes sure to preserve the expected classes when creating asserting
doc values.
2020-09-03 11:41:11 +02:00
Adrien Grand 0d37e4dc76
LUCENE-9483: Disable per-thread caching of buffers for decompression of stored fields. (#1787)
These buffers can use lots of memory when the number of segments,
threads or both is high.
2020-09-03 11:37:34 +02:00
Adrien Grand 0a9b660648 LUCENE-8500: Make sure to use a 0 offset when setting the dictionary. 2020-09-03 11:34:23 +02:00
Uwe Schindler aabd36332f LUCENE-9215: add changes, tune the build.gradle of the doclet project to have correct settings 2020-09-02 19:54:55 +02:00
Uwe Schindler 236455296c SOLR-14783: Remove ivy-versions.properties suddenly reappearing after merge 2020-09-02 19:51:19 +02:00
Bruno Roustant 56dbb66503
SOLR-14782: Document how to unescape for the QueryElevationComponent. 2020-09-02 17:40:00 +02:00
David Smiley 20af6dbd3d
LUCENE ExitableReaderException public ctor (#1797)
And cross-link javadocs with TimeLimitingCollector
2020-09-02 11:30:26 -04:00
Robert Muir 784ede4eda
LUCENE-9215: replace checkJavaDocs.py with doclet (#1802)
This has the same logic as the previous python, but no longer relies
upon parsing HTML output, instead using java's doclet processor.

The errors are reported like "normal" javadoc errors with source file
name and line number and happen when running "gradlew javadoc"

Although the "rules" are the same as the previous python, the python had
some bugs where the checker didn't quite do exactly what we wanted, so
some fixes were applied throughout.

Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
Co-authored-by: Uwe Schindler <uschindler@apache.org>
2020-09-02 08:29:17 -04:00
iverase c077185943 Add version constant for 8.6.2 2020-09-01 15:27:20 +02:00
iverase 03814fc070 Add back-compat indices for 8.6.2 2020-09-01 11:22:00 +02:00
Dawid Weiss def82ab556
LUCENE-9435: Clean up ant compatability remnants in Gradle build
* Removing ant-only unused tasks.
* Correct message in TestVersion.java
* Remove unused file.
* Removing forbidden API rules for ant.
* Remove 'resolve' emulation.
* Move ecj-lint to task-definition-relative folder.
* Remove 'packaging' specification. It'll have to wait until proper new packaging is implemented for Solr distribution.
* Move render-javadoc tasks's files to task-relative location.
* Moved security manager policies and default JDK logging file to gradle's task relative locations.
* Removing obsolete ant tools. Moving check source patterns under gradle's folder.
* Correct paths.
* Correct property name in task selector.
2020-08-30 14:01:04 +02:00
Alexandre Rafalovitch a57ba25400
SOLR-14783: Remove DIH from 9.0 (#1794)
* Remove DIH example directory

* Remove contrib code directories

* Remove contrib package related configurations for build tools

* Remove mention of DIH example

* remove dih as build dependencies and no-longer needed version pins

* Remove README references to DIH

* Remove dih mention from the script that probably does need to exist at all

* More build artifact references

* More removed dependencies leftovers (licenses/versions)

* No need to smoke exclude DIH anymore

* Remove Admin UI's DIH integration

* Remove DIH from shortname package list

* Remove unused DIH (related? not?) dataset
Unclear what is happening here, but there is no reference to that directory anywhere else
The other parallel directories ARE referenced in a TestConfigSetsAPI.java

* Hidden Idea files references

* No DIH to ignore anymore

* Remove last Derby DB references

* Remove DIH from documentation
Add the information in Major Changes document with the link to the external repo

* Added/updated a mention to CHANGES

* Fix leftover library mentions

* Fix Spellings
2020-08-29 10:52:04 -04:00
Tomoko Uchida c11d32faed LUCENE-9441: Fix ant-specific Javadoc links in accordance with Gradle build 2020-08-29 22:28:03 +09:00
Erick Erickson da8ea70682 LUCENE-9475: Enhance the Gradle build as necessary after removing Ant support 2020-08-28 10:13:13 -04:00
Erick Erickson 69fa5a00fb LUCENE-9433: Remove Ant support from trunk 2020-08-28 09:31:16 -04:00
Simon Willnauer 4787042f3e LUCENE-9447: suppress DeflateWithPresetCompressingStoredFieldsData since it doesn't add any attributes 2020-08-28 10:52:01 +02:00
Robert Muir 54a5dc2e6e
LUCENE-9313: move change to 9.0, the prerequisite snowball support is only present there 2020-08-26 07:54:24 -04:00
Robert Muir c7029b1254
LUCENE-9313: Analyzer for Serbian language based on Snowball stemmer 2020-08-26 07:50:29 -04:00
Adrien Grand 913976dbf7
LUCENE-9447: Make BEST_COMPRESSION better with highly compressible data. (#1762)
This makes BEST_COMPRESSION split blocks into sub blocks and use preset
dictionaries to improve compression ratios.
2020-08-26 11:04:34 +02:00
Adrien Grand e6fa5a5fc4
LUCENE-9456: Move metadata about stored fields to the meta file. (#1752)
Stored fields have a metadata file, but it currently only records
metadata about the index, not the actual data. This commit moves all
metadata to the metadata file.
2020-08-26 10:27:03 +02:00
Simon Willnauer 098f0dc8b4
LUCENE-9478: Prevent DWPTDeleteQueue from referencing itself and leaking memory (#1779)
In LUCENE-9304 we introduced some fixes that unfortunately hold on to the previous
DWPTDeleteQueue which is essentially leaking IW memory and cause applications to fail.
This fixes the memory leak and adds a test to ensure its not leaking memory.
2020-08-24 21:29:27 +02:00
Simon Willnauer da095bc7da
LUCENE-9477: Don't leave potentially broken segments file behind (#1777)
If we fail to rollback an already renamed pending segments file during
commit due to a failure in directory syncing we might not fully roll back
to a proper state if we hit a failure during rollback which leaves the index
in a broken state. This is a best effort approach to remove the renamed file
in the case of a failure during sync.
2020-08-24 20:19:44 +02:00
Simon Willnauer 8294e1ae20
LUCENE-8962: Merge segments on getReader (#1623)
Add IndexWriter merge-on-refresh feature to selectively merge 
small segments on getReader, subject to a configurable timeout, 
to improve search performance by reducing the number of small 
segments for searching.

Co-authored-by: Mike McCandless <mikemccand@apache.org>
2020-08-24 20:19:08 +02:00
Christine Poerschke f924225282
Append MultiCollectorTest to TestMultiCollector. (#1745) 2020-08-24 12:27:56 +01:00