Commit Graph

2565 Commits

Author SHA1 Message Date
Ilan Ginzburg 3e42286e9e
SOLR-14546: OverseerTaskProcessor can process messages out of order (#1561)
SOLR-14546: OverseerTaskProcessor can process messages out of order
2020-06-23 16:16:46 +02:00
Jan Høydahl 936b9d770e
SOLR-14561 CoreAdminAPI's parameters instanceDir and dataDir are now validated (#1572) 2020-06-18 16:13:52 +02:00
Erick Erickson 6357b3bdaa SOLR-14573: Fix or suppress warnings in solrj/src/test 2020-06-16 13:27:53 -04:00
noble fabc704748 SOLR-14516: NPE in JsonTextWriter 2020-06-15 19:17:23 +10:00
Erick Erickson 8426dc7a6a SOLR-14556: Fix or suppress warnings in solrj/cloud/autoscaling 2020-06-14 15:43:30 -04:00
Erick Erickson 4e90e48ac2 SOLR-14567: Fix or suppress remaining warnings in solrj 2020-06-14 08:11:23 -04:00
Gus Heck 396490b65c SOLR-13169 Improve docs for MOVEREPLICA - better parity with ref guide for v2 api descriptions 2020-06-13 16:24:45 -04:00
Gus Heck b00d747eb6 SOLR-13169 Improve docs for MOVEREPLICA - document additional existing parameters, second pass fixing spelling and other details. 2020-06-13 15:55:32 -04:00
Erick Erickson 6801d4c139 SOLR-14565: Fix or suppress warnings in solrj/impl and solrj/io/graph 2020-06-12 20:06:16 -04:00
Mike Drob fb98f30a61
SOLR-8392 type safety on SolrParam (#1556) 2020-06-11 14:21:54 -05:00
murblanc b4dcbfa3de
SOLR-12823: fix failures in CloudHttp2SolrClientTest CloudSolrClientTest TestCloudSolrClientConnections (#1565)
Co-authored-by: Ilan Ginzburg <iginzburg@salesforce.com>
2020-06-11 10:50:16 -05:00
Munendra S N 53040984f6 SOLR-14345: return correct err msg when non-binary resp parser is used
* This adds support to parse error properly in case of non-binary
  resp parser but the problem still exists for noopResponseParser
2020-06-10 19:11:52 +05:30
murblanc d4f7c90bab
SOLR-14347: fix cached session update to not depend on Zookeeper state (#1542)
SOLR-14347: fix cached session update to not depend on Zookeeper state
2020-06-10 21:13:55 +10:00
Mike Drob 2660139aa3 few more awaitsfix 2020-06-09 22:00:44 -05:00
Erick Erickson c8f48d4701 SOLR-14547: Fix or suppress warnings in solr/client/solrj/io/stream 2020-06-09 19:21:36 -04:00
Mike Drob 8ee6e6797b
SOLR-14548 Address warning: static member should be qualified by type… (#1555) 2020-06-09 15:33:37 -05:00
murblanc 1ab9b811c6
SOLR-12823: remove /clusterstate.json (#1528)
* SOLR-12823: remove /clusterstate.json

Remove all code dealing with Zookeeper's /clusterstate.json, remove Collection API's MIGRATESTATEVERSION, remove legacyCloud option.

Also fixes SOLR-11877 DocCollection.getStateFormat is buggy

Co-authored-by: Ilan Ginzburg <iginzburg@salesforce.com>
2020-06-09 13:59:17 -05:00
Adrien Grand 684c2e6afe SOLR-14470: Fix precommit 2020-06-09 09:37:51 +02:00
Andrzej Bialecki 30924f23d6 SOLR-14470: Add streaming expressions to /export handler. 2020-06-08 16:03:07 +02:00
Erick Erickson 7bf59a16bd SOLR-14544: Fix or suppress warnings in solr/client/solrj/io/eval 2020-06-07 21:31:51 -04:00
Jan Høydahl f404a38fa6
SOLR-9679: Exception when removing zk node /security.json (#1403) 2020-06-08 01:11:56 +02:00
Erick Erickson 6d5b1ae7f4 SOLR-14536: Fix or suppress warnings in apache/solr/common 2020-06-06 09:30:17 -04:00
Gus Heck 4b496b364f SOLR-13169 Improve docs for MOVEREPLICA - correct existing parameter docs. 2020-06-05 17:47:11 -04:00
Erick Erickson 07a9b5d1b0 SOLR-14474: Fix remaining auxilliary class warnings in Solr 2020-05-27 12:06:29 -04:00
Tomas Fernandez Lobbe 3ca7628c43
SOLR-13289: Rename minExactHits to minExactCount (#1511) 2020-05-21 16:42:37 -07:00
David Smiley 2ac640f9d0
SOLR-14484: avoid putting null into MDC
Co-authored-by: Andras Salamon
2020-05-20 09:46:15 -04:00
Joel Bernstein a795047c6c SOLR-14476: Fix precommit 2020-05-19 09:10:23 -04:00
Joel Bernstein 16aad55369 SOLR-14476: Add percentiles and standard deviation aggregations to stats, facet and timeseries Streaming Expressions 2020-05-19 09:10:23 -04:00
David Smiley d3d0df9da1
SOLR-14472: Autoscale "cores": use metrics to count
Also counts all cores (lazy, transient), although currently impossible to use these in SolrCloud.
2020-05-18 17:41:29 -04:00
murblanc d2825282c9
SOLR-14473: Improve Overseer Javadoc (#1510)
Co-authored-by: Ilan Ginzburg <iginzburg@salesforce.com>
2020-05-18 15:21:16 -05:00
Uwe Schindler 06df50e759
LUCENE-9321: Port markdown task to Gradle (#1477) 2020-05-17 14:46:26 +02:00
Michael Gibney 54dca800a9
SOLR-14471: Fix last-place replica after shards.preference rules (#1507)
Properly apply base replica ordering to last-place shards.preference matches
2020-05-14 21:31:35 -07:00
Joel Bernstein f1db56afaf SOLR-14478: Allow the diff Stream Evaluator to operate on the rows of a matrix 2020-05-14 09:52:05 -04:00
Andrzej Bialecki dd4fa8f2f8 SOLR-14423: Additional fixes for object caching and incorrect test assumptions. 2020-05-13 19:37:12 +02:00
Samuel García Martínez adddab9d14
SOLR-14456: Fix Content-Type header forwarding on compressed requests (#1480)
Co-authored-by: Samuel García Martínez <samuelgma@inditex.com>
2020-05-12 17:50:07 -04:00
Andrzej Bialecki 4680e9245f SOLR-14423: Move static SolrClientCache from StreamHandler to CoreContainer for wider reuse and better life-cycle management. 2020-05-12 21:44:00 +02:00
Tomas Fernandez Lobbe d9f9d6dd47
SOLR-13289: Add Support for BlockMax WAND (#1456)
Add support for BlockMax WAND via a minExactHits parameter. Hits will be counted accurately at least until this value, and above that, the count will be an approximation. In distributed search requests, the count will be per shard, so potentially the count will be accurately counted until numShards * minExactHits. The response will include the value numFoundExact which can be true (The value in numFound is exact) or false (the value in numFound is an approximation).
2020-05-08 14:25:47 -07:00
Erick Erickson 9ae05e9b4f LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects 2020-04-30 19:50:31 -04:00
Erick Erickson 6e96d01efc LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects 2020-04-29 10:56:54 -04:00
Erick Erickson 960610a615 LUCENE-7788: fail precommit on unparameterised log messages and examine for wasted work/objects 2020-04-27 20:45:57 -04:00
Mike Drob 950a34ce13 SOLR-14412 use parameterized logging 2020-04-22 12:11:53 -05:00
Andrzej Bialecki 5d60ff4613 SOLR-12845: Add a default autoscaling cluster policy. 2020-04-22 17:46:39 +02:00
Mike Drob 58f9c79c6d
SOLR-14412 zkRun+https (#1437)
SOLR-14412

Check for results after retries failed in SolrClientNodeStateProvider
Set urlScheme=https with zkRun
2020-04-20 12:55:43 -05:00
Jan Høydahl 03363f413f
SOLR-14371 Zk StatusHandler should know about dynamic zk config (#1392) 2020-04-17 16:30:27 +02:00
Markus Schuch 74ecc13816 SOLR-14387 add testcase for ids with separators to GetByIdTest and fix SolrClient to escape ids properly 2020-04-16 11:52:03 -05:00
Shalin Shekhar Mangar 3e0f7b1971 SOLR-9909: Actually delete SolrjNamedThreadFactory.java 2020-04-13 13:47:20 +05:30
Shalin Shekhar Mangar 13f19f6555 SOLR-9906: SolrjNamedThreadFactory is deprecated in favor of SolrNamedThreadFactory. DefaultSolrThreadFactory is removed from solr-core in favor of SolrNamedThreadFactory in solrj package and all solr-core classes now use SolrNamedThreadFactory 2020-04-13 08:16:35 +05:30
Erick Erickson 1ca7067a81 SOLR-12028: BadApple and AwaitsFix annotations usage, Unannotated tests that haven't failed in a while 2020-03-30 20:37:55 -04:00
Ishan Chattopadhyaya 782ded2d7a SOLR-14317: HttpClusterStateProvider throws exception when only one node down (Closes #1342) 2020-03-29 07:20:32 +05:30
Munendra S N 132228d450 SOLR-14344: remove deprecated HttpSolrClient's Remote*Exception
* All usages are replaced by BaseHttpSolrClient's Remote*Exception
2020-03-28 11:36:06 +05:30
Andy Throgmorton d1601f6fdf SOLR-14260: SolrJ pluggable ConnectionSocketFactory in HttpClientUtil
see SocketFactoryRegistryProvider
Fixes #1261
2020-03-26 22:15:50 -04:00
mariemat aad814ba63 SOLR-14340: Remove unnecessary configset verification checks
Improves CLUSTERSTATUS times for massive clusters.
Closes #1373
2020-03-24 15:34:20 -04:00
Andrzej Bialecki 68e4304453 SOLR-14347: Autoscaling placement wrong when concurrent replica placements are calculated. 2020-03-23 18:21:40 +01:00
Munendra S N 5630619dfd SOLR-14343: set initcapacity properly in NamedList
* This is when map or map.entry array is passed in constructor
2020-03-23 19:54:54 +05:30
Munendra S N e36733d01d SOLR-14350: fix test failure due to SOLR-14012 2020-03-19 22:43:29 +05:30
Aroop 9a8602c96e
SOLR-14316: Fix unchecked type warning in JavaBinCodec (#1344)
Fix an unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() method
Add test

Co-authored-by: Aroop Ganguly <aroop_ganguly@apple.com>
2020-03-12 09:55:01 -07:00
David Smiley 732348ec7f SOLR-14197: SolrResourceLoader refactorings to reduce API
* Remove SRL.listConfigDir (unused)
* Remove SRL.getDataDir
* Remove SRL.getCoreName
* Remove SRL.getCoreProperties
 XmlConfigFile needs to be passed in the substitutableProperties
 IndexSchema needs to be passed in the substitutableProperties
 Remove redundant Properties from CoreContainer constructors
* Remove SRL.newAdminHandlerInstance (unused)
* Remove SRL.openSchema and openConfig
* Avoid SRL.getConfigDir
 Also harmonized similar initialization logic between DIH Tika processor & ExtractingRequestHandler.
* Ensure SRL.addToClassLoader and reloadLuceneSPI are called at most once
 Don't auto-load "lib" in constructor; wrong place for this logic.
* Avoid SRL.getInstancePath
 Added SolrCore.getInstancePath instead
 Use CoreContainer.getSolrHome instead
 NodeConfig should track solrHome separate from SolrResourceLoader
* Simplify some SolrCore constructors
* Move locateSolrHome to new SolrPaths
* Move "User Files" stuff to SolrPaths
2020-03-11 09:20:28 -04:00
Marc A. Morissette 051133c13f
SOLR-12550: ConcurrentUpdateSolrClient doesn't respect timeouts for commits and optimize (#417)
ConcurrentUpdateSolrClient now propagates its connection and read timeouts to the private HttpSolrClient used to commit and optimize.
2020-02-20 04:29:20 -08:00
Christine Poerschke 003303a9cc SOLR-13041: Add hashCode for autoscaling.Condition to accompany the already present equals.
(Zsolt Gyulavari via Christine Poerschke)
2020-02-18 14:47:44 +00:00
Chris Hostetter 49e20dbee4 SOLR-14245: Fix ReplicaListTransformerTest
Previous changes to this issue 'fixed' the way the test was creating mock Replica instances,
to ensure all properties were specified -- but these changes tickled a bug in the existing test
scaffolding that caused it's "expecations" to be based on a regex check against only the base "url"
even though the test logic itself looked at the entire "core url"

The result is that there were reproducible failures if/when the randomly generated regex matched
".*1.*" because the existing test logic did not expect that to match the url or a Replica with
a core name of "core1" because it only considered the base url
2020-02-12 11:10:26 -07:00
Andrzej Bialecki 9a19093586 SOLR-14245: Validate Replica / ReplicaInfo on creation. 2020-02-07 17:56:39 +01:00
Robert Muir 0d339043e3
LUCENE-9209: fix javadocs to be html5, enable doclint html checks, remove jtidy
Current javadocs declare an HTML5 doctype: !DOCTYPE HTML. Some HTML5
features are used, but unfortunately also some constructs that do not
exist in HTML5 are used as well.

Because of this, we have no checking of any html syntax. jtidy is
disabled because it works with html4. doclint is disabled because it
works with html5. our docs are neither.

javadoc "doclint" feature can efficiently check that the html isn't
crazy. we just have to fix really ancient removed/deprecated stuff
(such as use of tt tag).

This enables the html checking in both ant and gradle. The docs are
fixed via straightforward transformations.

One exception is table cellpadding, for this some helper CSS classes
were added to make the transition easier (since it must apply padding
to inner th/td, not possible inline). I added TODOs, we should clean
this up. Most problems look like they may have been generated from a
GUI or similar and not a human.
2020-02-06 22:30:52 -05:00
Houston Putman 80ed8c281b
SOLR-13887: Use the default idleTimeout instead of 0 for HTTP2 (#991) 2020-02-05 11:15:37 -08:00
Chris Hostetter c5d0391df9 SOLR-14241: New delete() Stream Decorator 2020-02-05 10:49:24 -07:00
Joel Bernstein db78f6cd00 SOLR-14139: Support backtick phrase queries in Streaming Expressions 2020-01-31 11:54:14 -05:00
Chris Hostetter 517438e356 New /stream test cases showing authn+authz edge cases in cloud mode
This triggers various places in the Streaming Expressions code that use background threads
to confirm that the expected credentails (or lack of) are propogarded along.

Test currently has comments + workarounds for 2 known client issues:
 - SOLR-14226: SolrStream reports AuthN/AuthZ failures (401|403) as IOException w/o details
 - SOLR-14222: CloudSolrClient converts (update) 403 error to 500 error
2020-01-30 10:01:03 -07:00
Robert Muir 975df9ddd3
LUCENE-9182: add apache license headers to all .gradle files and enforce in rat task 2020-01-27 12:05:34 -05:00
Nick Vercammen 60a2926546
SOLR-14205 Do not fail when given timeout to connectionImpl.isValid() = 0
Closes #1204

Signed-off-by: Kevin Risden <krisden@apache.org>
2020-01-23 10:12:43 -05:00
Mike 338d386ae0
LUCENE-9145 First pass addressing static analysis (#1181)
Fixed a bunch of the smaller warnings found by error-prone compiler
plugin, while ignoring a lot of the bigger ones.
2020-01-17 13:30:39 -06:00
Dawid Weiss d7726495c5 Merge remote-tracking branch 'origin/master' into gradle-master 2020-01-09 19:22:09 +01:00
Kevin Risden 22155bf7a7
SOLR-14163: SOLR_SSL_CLIENT_HOSTNAME_VERIFICATION needs to work with Jetty server/client SSL contexts
Closes #1147

Signed-off-by: Kevin Risden <krisden@apache.org>
2020-01-09 10:28:35 -05:00
andywebb1975 ffe75fb441 SOLR-14165: set SolrResponse's serialVersionUID explicitly 2020-01-10 01:04:10 +11:00
Dawid Weiss 0674fada65 Merge remote-tracking branch 'origin/master' into gradle-master 2020-01-09 11:56:02 +01:00
Tomas Fernandez Lobbe a9beeb1d1e SOLR-14169: Fix 20 Resource Leak warnings in SolrJ's apache/solr/common 2020-01-08 11:16:32 -08:00
Dawid Weiss 405d227c55 Merge remote-tracking branch 'origin/master' into gradle-master 2020-01-07 08:45:12 +01:00
Nick Vercammen 1e0471a247
SOLR-14153: Return correct isolation level when retrieving it from the SQL Connection
As transactions are not supported a request to getTransactionIsolation() should return TRANSACTION_NONE (https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#TRANSACTION_NONE)

Signed-off-by: Kevin Risden <krisden@apache.org>
2020-01-03 14:24:55 -05:00
Dawid Weiss d2409fe499 Follow-up unused import removal. 2020-01-03 14:20:52 +01:00
Dawid Weiss 6d1e34d0cc Follow-up unused import removal. 2020-01-03 14:20:21 +01:00
Dawid Weiss 985af95732 SOLR-13778: Solrj client will retry requests on SSLException with a suppressed SocketException (very likely a hard-closed socket connection) 2020-01-03 14:12:23 +01:00
Dawid Weiss f789e053d2 Solrj client will retry requests on SSLException with a suppressed SocketException (very likely a hard-closed socket connection) 2020-01-03 14:09:37 +01:00
Dawid Weiss 1a690d95ad Merge remote-tracking branch 'origin/master' into gradle-master 2020-01-02 10:49:19 +01:00
Nándor Mátravölgyi 4c9cc2cefd LUCENE-9093: UnifiedHighlighter LengthGoalBreakIterator frag align
Matches in passages should be centered better on average.
 Closes #1123
2020-01-01 00:57:00 -05:00
Dawid Weiss 23f3fd2d48 Merge remote-tracking branch 'origin/master' into gradle-master 2019-12-25 13:14:57 +01:00
Noble Paul ef15ae9805
SOLR-14125 : Streaming expressions to be loadable from packages (#1108)
SOLR-14125: Make <expressible> plugins work with packages
2019-12-23 15:20:26 +11:00
Tomas Fernandez Lobbe c4f68bdab9
SOLR-14095: Let the overseer use javabin to store responses in ZooKeeper (#1095)
The Overseer used java serialization to store command responses in ZooKeeper. This commit changes the code to use Javabin instead, while allowing Java serialization with a System property in case it's needed for compatibility
2019-12-20 14:55:01 -08:00
Dawid Weiss 5897b78572 Merge remote-tracking branch 'origin/master' into gradle-master 2019-12-20 17:35:40 +01:00
Kevin Risden aab3c5faa3
SOLR-14106: Cleanup Jetty SslContextFactory usage
Jetty 9.4.16.v20190411 and up introduced separate
client and server SslContextFactory implementations.
This split requires the proper use of of
SslContextFactory in clients and server configs.

This fixes the following
* SSL with SOLR_SSL_NEED_CLIENT_AUTH not working since v8.2.0
* Http2SolrClient SSL not working in branch_8x

Signed-off-by: Kevin Risden <krisden@apache.org>
2019-12-19 23:05:47 -05:00
Jason Gerlowski 7cfa31b103 SOLR-14042: Fix varargs precommit warnings 2019-12-19 10:03:04 -05:00
Matthias Krueger 1e5100d5a5
SOLR-14091: Removing deprecated configuration of Jetty's soLingerTime option
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-12-18 17:24:43 -05:00
Dawid Weiss 4c94a13e69 Merge remote-tracking branch 'origin/master' into gradle-master 2019-12-17 13:38:14 +01:00
Robert Muir dc35e5752b LUCENE-9094: Ban ObjectInputStream and ObjectOutputStream in forbidden-apis 2019-12-16 13:31:11 -05:00
Dawid Weiss 4500f0e327 Consolidating versions between gradle and ant. 2019-12-13 13:31:23 +01:00
Dawid Weiss 035cede6b8 Merge remote-tracking branch 'origin/master' into gradle-master 2019-12-13 10:51:14 +01:00
Andrzej Bialecki e155649026 SOLR-13975: Make sure the stall time is adjusted up when an unusually long
poll time is configured.
2019-12-12 19:58:03 +01:00
Dawid Weiss 6094d4dd13 Merge remote-tracking branch 'origin/master' into gradle-master 2019-12-12 14:16:48 +01:00
noble b35f1debe3 SOLR-14013: javabin performance regressions 2019-12-12 23:26:37 +11:00
Joel Bernstein ee0a6b45ca SOLR-14060: Allow the random Streaming Expression to create the x-axis 2019-12-11 20:37:20 -05:00
Robert Muir dc031ea382 SOLR-14050: clean up tests use of network addresses
Solr tests now have a similar policy to Lucene, loopback use only. If a
test tries to resolve or connect to the internet, it will get SecurityException.

Some solr tests explicitly try to talk to dead nodes with real
networking. This is not good and asking for trouble, but use low loopback port numbers instead of
multicast addresses. The idea is that it fails faster. Move these to
constants so that stuff isn't copy-pasted everywhere, in case we have to
do something different later.
2019-12-11 12:51:45 -05:00
Dawid Weiss 27d5509644 Merge remote-tracking branch 'origin/master' into gradle-master 2019-12-11 08:57:18 +01:00
Andrzej Bialecki c4f0c33638 SOLR-13975, SOLR-13896: ConcurrentUpdateSolrClient connection stall prevention. 2019-12-10 21:45:43 +01:00