Commit Graph

31615 Commits

Author SHA1 Message Date
Chris Hostetter 1071d09336 SOLR-13352: Remove risk of deadlock/threadleak when shutting down an Overseer(TriggerThread) 2019-04-01 10:34:51 -07:00
Erick Erickson e04a28e140 SOLR-12028: BadApple and AwaitsFix annotations usage 2019-04-01 09:27:33 -07:00
Cassandra Targett cc23cd9d55 SOLR-13259: clarify language around *must* reindex vs *should* reindex 2019-04-01 10:06:01 -05:00
Kevin Risden a99cec0402
SOLR-13359: Make UpdateHandler support other prefixes (besides hdfs:/)
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-31 10:45:57 -04:00
Jason Gerlowski 1204d212d1 Improve docs on using basic-auth in SolrJ 2019-03-31 10:36:50 -04:00
Kevin Risden 42f8203fc3
SOLR-11473: Make HDFSDirectoryFactory support other prefixes (besides hdfs:/)
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-30 14:26:00 -04:00
Jason Gerlowski 07b37ff26b SOLR-13355: Obey 'ALL' for handlers with other predefined perms
Prior to this commit, RuleBasedAuthorizationPlugin would check for the
predefined 'ALL' permission only when the endpoint being hit wasn't
associated with another predefined-permission.

This resulted in some very unintuitive behavior. For example, the
permission {name:all, role:admin} would correctly prevent a
role:foo user from accessing /admin/info/properties, but would allow
write access to /admin/authorization because of the SECURITY_EDIT
predefined perm associated with that endpoint.

This commit fixes this bug so that the 'all' permission is always
consulted whether or not the endpoint is associated with other predefined
permissions.
2019-03-29 22:33:12 -04:00
Jason Gerlowski 5fe03bcd01 SOLR-13355: Small refactors to RuleBasedAuthorizationPlugin 2019-03-29 22:33:00 -04:00
erick b2941ff0da SOLR-13349:High CPU usage in Solr due to Java 8 bug 2019-03-28 15:49:54 -07:00
Kevin Risden 8d658a8cfb
SOLR-13353: Add SolrCli AuthTool test
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-28 14:08:07 -04:00
Kevin Risden 90d983cf7c
SOLR-13351: Workaround for VELOCITY-908
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-27 17:42:55 -04:00
Joel Bernstein 98cadcf9f6 SOLR-13294: Change test file name 2019-03-27 15:36:47 -04:00
Joel Bernstein d407d556cc SOLR-13294: TestSQLHandler failures on windows jenkins machines 2019-03-27 15:36:47 -04:00
jimczi 7e83451610 LUCENE-8732: ConstantScoreQuery can now early terminate the query if the minimum score is greater than the constant score and total hits are not requested 2019-03-27 18:09:23 +01:00
Alan Woodward 1c46dd1f9b LUCENE-8741: Fix ClassCastException in ValueSource.fromDoubleValuesSource() 2019-03-27 16:08:25 +00:00
Alan Woodward 3a63c58db3 LUCENE-8477: Add CHANGES entry 2019-03-27 11:29:20 +00:00
Alan Woodward f1782d0dd1
LUCENE-8477: Automatically rewrite disjunctions when internal gaps matter (#620)
We have a number of IntervalsSource implementations where automatic minimization of
disjunctions can lead to surprising results:

* PHRASE queries can miss matches because a longer matching sub-source is minimized
  away, leaving a gap
* MAXGAPS queries can miss matches for the same reason
* CONTAINING, NOT_CONTAINING, CONTAINED_BY and NOT_CONTAINED_BY queries
  can miss matches if the 'big' interval gets minimized

The proper way to deal with this is to rewrite the queries by pulling disjunctions to the top
of the query tree, so that PHRASE("a", OR(PHRASE("b", "c"), "c")) is rewritten to
OR(PHRASE("a", "b", "c"), PHRASE("a", "c")). To be able to do this generally, we need to
add a new pullUpDisjunctions() method to IntervalsSource that performs this rewriting
for each source that it would apply to.

Because these rewritten queries will in general be less efficient due to the duplication of
effort (eg the rewritten PHRASE query above pulls 5 term iterators rather than 4 in the
original), we also add an option to Intervals.or() that will prevent this happening, so that
consumers can choose speed over accuracy if it suits their usecase.
2019-03-27 11:23:43 +00:00
Ishan Chattopadhyaya e7939d5907 SOLR-7414: CSVResponseWriter & XLSXResponseWriter return empty field when fl alias is combined with * selector 2019-03-27 14:38:36 +05:30
Simon Willnauer 8d7619f4e6 LUCENE-8735: fix changes entry after backport 2019-03-26 15:57:43 +01:00
Henning Andersen 04afdb6442 LUCENE-8735: Avoid FileAlreadyExistsException on windows. (#619)
FilterDirectory.getPendingDeletions() did not delegate the call, which
resulted in a new IndexWriter on same directory not considering pending
delete files. This could in turn result in a FileAlreadyExistsException
when running windows.
2019-03-26 14:56:45 +01:00
Cassandra Targett 65165c7c87 SOLR-11959: Add docs on CDCR limitation with Basic Auth 2019-03-26 08:00:39 -05:00
Tommaso Teofili 42a548e28e LUCENE-6687 - avoid unnecessary looping 2019-03-26 11:27:09 +01:00
Kevin Risden 361d1e84ce
SOLR-13112: Upgrade jackson to 2.9.8
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-25 10:38:00 -04:00
Kevin Risden 11542aebce
Fix solr/CHANGES.txt
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-25 10:21:02 -04:00
Kevin Risden 4e230388ba
SOLR-13335: Upgrade to velocity 2.0 and velocity-tools 3.0
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-25 09:58:44 -04:00
Kevin Risden 0231c1ecb6
SOLR-13342: Remove dom4j from Solr
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-25 08:15:01 -04:00
Gus Heck dad414ca22 SOLR-13323 - remove unused csv related classes/tests 2019-03-24 20:01:46 -04:00
Gus Heck c60685f9e4 SOLR-13324 - Don't swallow/print exception in URLClassifyProcessor anymore 2019-03-24 19:07:26 -04:00
Shalin Shekhar Mangar bca22d58e2 SOLR-11126: Move change log entry under 8.0 2019-03-22 07:31:06 +05:30
Andrzej Bialecki 863d34bff5 SOLR-13322: Properly log exceptions. 2019-03-21 22:22:03 +01:00
Simon Willnauer 65e1b3ef2a Add assume to test since it only works with mmap directory 2019-03-21 14:20:23 +01:00
Kevin Risden 6222abf448
SOLR-9079: Remove commons-lang as a dependency
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-20 19:37:19 -04:00
Simon Willnauer 14175c46d2
LUCENE-8671: Load FST off-heap if reader is not opened from an index writer (#610)
Today we never load FSTs of ID-like fields off-heap since we need
very fast access for updates. Yet, a reader that is not loaded from
an IndexWriter can also leave the FST on disk. This change adds
this information to SegmentReadState to allow the postings format
to make this decision without configuration.
2019-03-20 11:28:10 +01:00
Uwe Schindler 2a1ed6e484 LUCENE-8729: Workaround to allow compile under JDK13+ 2019-03-19 19:05:15 +01:00
David Smiley 85a702cdff SOLR-13253: avoid using IndexSchema.getResourceLoader for non-schema things.
Furthermore it's reference to SolrConfig was removed.
2019-03-19 13:51:44 -04:00
Bar Rotstein 5b7866b085 SOLR-12955: Refactored DistributedUpdateProcessor to put SolrCloud specifics into a subclass
Closes #528
2019-03-19 13:26:31 -04:00
Andrzej Bialecki 6f2b7bf5c0 SOLR-11127: REINDEXCOLLECTION command for re-indexing of existing collections. 2019-03-19 13:42:59 +01:00
Kevin Risden 9fea3060b9
SOLR-8033: Remove debug if branch in HdfsTransactionLog
Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-19 06:20:09 -04:00
Adrien Grand 07f3535793 LUCENE-8138: Check that dv producers's next/advance and advanceExact impls are consistent. 2019-03-19 10:53:10 +01:00
Adrien Grand 577bef53dd LUCENE-8166: Require merge instances to be consumed in the thread that created them. 2019-03-19 10:51:54 +01:00
Kevin Risden cf828163bd
SOLR-13330: Improve HDFS tests
Related JIRAs:
* SOLR-11010
* SOLR-11381
* SOLR-12040
* SOLR-13297

Changes:
* Consolidate hdfs configuration into HdfsTestUtil
* Ensure socketTimeout long enough for HDFS tests
* Ensure HdfsTestUtil.getClientConfiguration used in tests
* Replace deprecated HDFS calls
* Use try-with-resources to ensure closing of HDFS resources

Signed-off-by: Kevin Risden <krisden@apache.org>
2019-03-18 15:25:36 -04:00
erick 3ac07b8dfb SOLR-13268: Patch that flushes when shutting down 2019-03-18 11:52:39 -07:00
Alan Woodward 5ca2524927 LUCENE-8694: Payload-filtered term intervals 2019-03-18 09:41:00 +00:00
Chris Hostetter 5c143022e7 SOLR-12923: Mea culpa: Remove useless import of java.lang... that breaks precommit 2019-03-15 14:39:19 -07:00
Simon Willnauer af5c2b22da Fix more tests to not use concurrent flushing in RIW#commit() 2019-03-15 22:18:20 +01:00
Chris Hostetter 1a54c6b19d SOLR-12923: fix SimClusterStateProvider to use lock.lockInterruptibly() exclusively, and make SimCloudManager's Callable checks tollerant of Callables that may have failed related to interrupts w/o explicitly throwing InterruptedException 2019-03-15 12:06:53 -07:00
Chris Hostetter c79aeee5f9 SOLR-12923: tweak the randomization in testCreateLargeSimCollections to reduce the max possible totalCores
also decrease the number of iters while increase the cluster shape wait time to reduce the risk of spurious failures on machines under heavy contention w/o making the the test any slower on average
2019-03-15 10:43:28 -07:00
Jan Høydahl 8f29d1eaad
SOLR-13244: Nodes view fails when a node is temporarily down 2019-03-15 13:30:02 +01:00
Andrzej Bialecki 571b307266 SOLR-13292: Fix a logic bug when point types are present, add more details to the unit test. 2019-03-15 11:52:37 +01:00
Simon Willnauer ad457d188e Improve RIW exception handling and opt out of concurrent flushing if exception is expected 2019-03-15 11:00:16 +01:00