From 0fc4704f300159e7c438362e3c2692d210fd357e Mon Sep 17 00:00:00 2001 From: John Dennis Casey Date: Fri, 8 Feb 2008 01:20:22 +0000 Subject: [PATCH] [MNG-2184] Commenting this out again, until I can figure out how to make aggregators run once and only once, regardless of the contents of the reactor. git-svn-id: https://svn.apache.org/repos/asf/maven/components/trunk@619724 13f79535-47bb-0310-9956-ffa450edef68 --- .../maven/lifecycle/DefaultLifecycleExecutor.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java b/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java index 258039eb41..5033befc37 100644 --- a/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java +++ b/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java @@ -523,11 +523,15 @@ public class DefaultLifecycleExecutor MojoDescriptor mojoDescriptor = pluginDescriptor.getMojo( mojoBinding.getGoal() ); - if ( mojoDescriptor.isAggregator() && ( project != rm.getTopLevelProject() ) ) - { - getLogger().debug( "Skipping mojo execution: " + MojoBindingUtils.toString( mojoBinding ) + "\nfor project: " + project.getId() + "\n\nIt is an aggregator mojo, and the current project is not the root project for the reactor." ); - return; - } + // TODO: Figure out how to make this logic produce the same result when the binding is in a module. + // At times, the module will build in isolation, in which case this logic would allow the aggregator to run. + // In other cases, the module will be part of a reactor build, and the aggregator won't run, because it's not + // bound to the root project. +// if ( mojoDescriptor.isAggregator() && ( project != rm.getTopLevelProject() ) ) +// { +// getLogger().debug( "Skipping mojo execution: " + MojoBindingUtils.toString( mojoBinding ) + "\nfor project: " + project.getId() + "\n\nIt is an aggregator mojo, and the current project is not the root project for the reactor." ); +// return; +// } validateMojoExecution( mojoBinding, mojoDescriptor, project, allowAggregators );