Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Code cleanup - It's better (for perfs) to use a chain of append() calls than a unique append with several Strings concatenations" 

This reverts commit c8e94a5b08.

Decreases too much the code readibility
This commit is contained in:
Arnaud Héritier 2013-06-14 10:28:27 +02:00
parent 456268af61
commit 21907a74e7
8 changed files with 22 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
maven-artifact/src/main/java/org/apache/maven/artifact/resolver/AbstractArtifactResolutionException.java
View File

@ -199,14 +199,13 @@ private static String constructMessageBase( String message,
if ( message == null || !message.contains( "from the specified remote repositories:" ) )
{
sb.append( LS );
sb.append( " " ).append( groupId ).append( ":" ).append( artifactId ).append( ":" ).append( type ).append(
":" ).append( version );
sb.append( " " + groupId + ":" + artifactId + ":" + type + ":" + version );
sb.append( LS );
if ( remoteRepositories != null )
{
sb.append( LS );
sb.append( "from the specified remote repositories:" );
sb.append( LS ).append( " " );
sb.append( LS + " " );
if ( remoteRepositories.isEmpty() )
{

3
maven-compat/src/main/java/org/apache/maven/project/validation/ModelValidationResult.java
View File

@ -85,8 +85,7 @@ public String render( String indentation )
//
for ( int i = 0; i < messages.size(); i++ )
{
message.append( indentation ).append( "[" ).append( i ).append( "] " ).append( messages.get( i ) ).append(
NEWLINE );
message.append( indentation + "[" + i + "] " + messages.get( i ) + NEWLINE );
}
return message.toString();

4
maven-compat/src/main/java/org/apache/maven/repository/metadata/ClasspathContainer.java
View File

@ -129,12 +129,12 @@ public void setScope( ArtifactScopeEnum scope )
public String toString()
{
StringBuilder sb = new StringBuilder( 256 );
sb.append( "[scope=" ).append( scope.getScope() );
sb.append( "[scope=" + scope.getScope() );
if ( classpath != null )
{
for ( ArtifactMetadata md : classpath )
{
sb.append( ": " ).append( md.toString() ).append( '{' ).append( md.getArtifactUri() ).append( '}' );
sb.append( ": " + md.toString() + '{' + md.getArtifactUri() + '}' );
}
}
sb.append( ']' );

6
maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraph.java
View File

@ -485,13 +485,13 @@ public String toString()
}
for ( MetadataGraphVertex v : vertices )
{
sb.append( "Vertex: " ).append( v.getMd().toString() ).append( "\n" );
sb.append( "Vertex: " + v.getMd().toString() + "\n" );
List<MetadataGraphEdge> ins = getIncidentEdges( v );
if ( ins != null )
{
for ( MetadataGraphEdge e : ins )
{
sb.append( " from : " ).append( e.toString() ).append( "\n" );
sb.append( " from : " + e.toString() + "\n" );
}
}
else
@ -504,7 +504,7 @@ public String toString()
{
for ( MetadataGraphEdge e : outs )
{
sb.append( " to : " ).append( e.toString() ).append( "\n" );
sb.append( " to : " + e.toString() + "\n" );
}
}
else

8
maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphVertex.java
View File

@ -192,17 +192,17 @@ public int hashCode()
return super.hashCode();
}
StringBuilder hashString = new StringBuilder( 128 );
hashString.append( md.groupId ).append( "|" );
hashString.append( md.artifactId ).append( "|" );
hashString.append( md.groupId + "|" );
hashString.append( md.artifactId + "|" );
if ( compareVersion )
{
hashString.append( md.version ).append( "|" );
hashString.append( md.version + "|" );
}
if ( compareScope )
{
hashString.append( md.getArtifactScope() ).append( "|" );
hashString.append( md.getArtifactScope() + "|" );
}
return hashString.toString().hashCode();

4
maven-core/src/main/java/org/apache/maven/plugin/PluginParameterException.java
View File

@ -144,8 +144,8 @@ else if ( isMap )
String alias = param.getAlias();
if ( StringUtils.isNotEmpty( alias ) && !alias.equals( param.getName() ) )
{
messageBuffer.append( "\n\n-OR-\n\n<configuration>\n ...\n <" ).append( alias ).append(
">VALUE</" ).append( alias ).append( ">\n</configuration>\n" );
messageBuffer.append(
"\n\n-OR-\n\n<configuration>\n ...\n <" + alias + ">VALUE</" + alias + ">\n</configuration>\n" );
}
}

15
maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java
View File

@ -55,14 +55,13 @@ public static String showVersion()
version.append( createMavenVersionString( properties ) ).append( LS );
version.append( reduce( properties.getProperty( "distributionShortName" ) + " home: "
+ System.getProperty( "maven.home", "<unknown maven home>" ) ) ).append( LS );
version.append( "Java version: " ).append(
System.getProperty( "java.version", "<unknown java version>" ) ).append( ", vendor: " ).append(
System.getProperty( "java.vendor", "<unknown vendor>" ) ).append( LS );
version.append( "Java home: " ).append( System.getProperty( "java.home", "<unknown java home>" ) ).append( LS );
version.append( "Default locale: " ).append( Locale.getDefault() ).append( ", platform encoding: " ).append(
System.getProperty( "file.encoding", "<unknown encoding>" ) ).append( LS );
version.append( "OS name: \"" ).append( Os.OS_NAME ).append( "\", version: \"" ).append( Os.OS_VERSION ).append(
"\", arch: \"" ).append( Os.OS_ARCH ).append( "\", family: \"" ).append( Os.OS_FAMILY ).append( "\"" );
version.append( "Java version: " + System.getProperty( "java.version", "<unknown java version>" )
+ ", vendor: " + System.getProperty( "java.vendor", "<unknown vendor>" ) ).append( LS );
version.append( "Java home: " + System.getProperty( "java.home", "<unknown java home>" ) ).append( LS );
version.append( "Default locale: " + Locale.getDefault() + ", platform encoding: "
+ System.getProperty( "file.encoding", "<unknown encoding>" ) ).append( LS );
version.append( "OS name: \"" + Os.OS_NAME + "\", version: \"" + Os.OS_VERSION + "\", arch: \"" + Os.OS_ARCH
+ "\", family: \"" + Os.OS_FAMILY + "\"" );
return version.toString();
}

2
maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerTest.java
View File

@ -70,7 +70,7 @@ public String getOptionsAsHtml()
for ( Option option : new CLIManagerExtension().getOptions() )
{
a = !a;
sb.append( "<tr class='" ).append( a ? 'a' : 'b' ).append( "'><td><code>-<a name='" );
sb.append( "<tr class='" + ( a ? 'a' : 'b' ) + "'><td><code>-<a name='" );
sb.append( option.getOpt() );
sb.append( "'>" );
sb.append( option.getOpt() );