[MNG-4338] Unexepceted "Unknown packaging: bundle" error for plugins with custom lifecycle mapping that defines optional mojos

o Added IT

git-svn-id: https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk@811511 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Benjamin Bentmann 2009-09-04 18:33:04 +00:00
parent 0ba2089726
commit 232f10a039
8 changed files with 256 additions and 0 deletions

View File

@ -85,6 +85,7 @@ public class IntegrationTestSuite
// suite.addTestSuite( MavenIT0109ReleaseUpdateTest.class );
// suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137
suite.addTestSuite( MavenITmng4338OptionalMojosTest.class );
suite.addTestSuite( MavenITmng4335SettingsOfflineModeTest.class );
suite.addTestSuite( MavenITmng4332DefaultPluginExecutionOrderTest.class );
suite.addTestSuite( MavenITmng4331DependencyCollectionTest.class );

View File

@ -0,0 +1,58 @@
package org.apache.maven.it;
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import org.apache.maven.it.Verifier;
import org.apache.maven.it.util.ResourceExtractor;
import java.io.File;
/**
* This is a test set for <a href="http://jira.codehaus.org/browse/MNG-4338">MNG-4338</a>.
*
* @author Benjamin Bentmann
*/
public class MavenITmng4338OptionalMojosTest
extends AbstractMavenIntegrationTestCase
{
public MavenITmng4338OptionalMojosTest()
{
super( ALL_MAVEN_VERSIONS );
}
/**
* Test that the <optional-mojos> element in custom lifecycle mappings is recognized and does not cause
* a configuration failure when loading the lifecycle.
*/
public void testit()
throws Exception
{
File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4338" );
Verifier verifier = new Verifier( testDir.getAbsolutePath() );
verifier.setAutoclean( false );
verifier.deleteDirectory( "target" );
verifier.executeGoal( "validate" );
verifier.verifyErrorFreeLog();
verifier.resetStreams();
}
}

View File

@ -163,6 +163,12 @@ under the License.
<version>${itPluginVersion}</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.its.plugins</groupId>
<artifactId>maven-it-plugin-optional-mojos</artifactId>
<version>${itPluginVersion}</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.its.plugins</groupId>
<artifactId>maven-it-plugin-packaging</artifactId>

View File

@ -0,0 +1,46 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.maven.its.mng4338</groupId>
<artifactId>test</artifactId>
<version>0.1</version>
<packaging>it-packaging</packaging>
<name>Maven Integration Test :: MNG-4338</name>
<description>
Test that the optional-mojos element in custom lifecycle mappings is recognized and does not cause
a configuration failure when loading the lifecycle.
</description>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.its.plugins</groupId>
<artifactId>maven-it-plugin-optional-mojos</artifactId>
<version>2.1-SNAPSHOT</version>
<extensions>true</extensions>
</plugin>
</plugins>
</build>
</project>

View File

@ -0,0 +1,62 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<artifactId>maven-it-plugins</artifactId>
<groupId>org.apache.maven.its.plugins</groupId>
<version>2.1-SNAPSHOT</version>
</parent>
<artifactId>maven-it-plugin-optional-mojos</artifactId>
<packaging>maven-plugin</packaging>
<name>Maven Integration Test Plugin :: Optional Mojos</name>
<description>
A test plugin that defines a custom lifecycle mapping with optional mojos.
</description>
<inceptionYear>2009</inceptionYear>
<properties>
<maven.test.skip>true</maven.test.skip>
</properties>
<dependencies>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>2.0</version>
</dependency>
<dependency>
<!--
NOTE: This is a dummy dependency whose contents doesn't matter. All that matters is that the plugin has at least
one dependency that is not excluded by the artifact filter of the core. This makes our IT plugin more closely
resemble a real-world plugin and in particular makes sure the extension manager does not consider the plugin
artifact as a standalone resource package. This subtle difference is crucial to reproduce MNG-2831.
-->
<groupId>org.apache.maven.its</groupId>
<artifactId>maven-core-it-support</artifactId>
<version>1.0</version>
</dependency>
</dependencies>
</project>

View File

@ -0,0 +1,59 @@
package org.apache.maven.plugin.coreit;
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import org.apache.maven.plugin.AbstractMojo;
import org.apache.maven.plugin.MojoExecutionException;
import java.io.File;
import java.io.IOException;
/**
* Creates an empty file to prove this goal was executed.
*
* @version $Id$
* @goal touch
*/
public class TouchMojo
extends AbstractMojo
{
/**
* @parameter default-value="${project.build.directory}/touch.txt"
*/
private File touchFile;
public void execute()
throws MojoExecutionException
{
getLog().info( "[MAVEN-CORE-IT-LOG] Creating touch file: " + touchFile );
try
{
touchFile.getParentFile().mkdirs();
touchFile.createNewFile();
}
catch ( IOException e )
{
throw new MojoExecutionException( "Error creating touch file: " + e.getMessage(), e );
}
}
}

View File

@ -0,0 +1,23 @@
<component-set>
<components>
<component>
<role>org.apache.maven.lifecycle.mapping.LifecycleMapping</role>
<role-hint>it-packaging</role-hint>
<implementation>org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping</implementation>
<configuration>
<lifecycles>
<lifecycle>
<id>default</id>
<phases>
<!-- NOTE: This is intentionally a very minimalistic lifecycle -->
<initialize>org.apache.maven.its.plugins:maven-it-plugin-optional-mojos:touch</initialize>
</phases>
<optional-mojos>
<optional-mojo>org.apache.maven.its.plugins:maven-it-plugin-optional-mojos:touch</optional-mojo>
</optional-mojos>
</lifecycle>
</lifecycles>
</configuration>
</component>
</components>
</component-set>

View File

@ -47,6 +47,7 @@ under the License.
<module>maven-it-plugin-log-file</module>
<module>maven-it-plugin-no-project</module>
<module>maven-it-plugin-online</module>
<module>maven-it-plugin-optional-mojos</module>
<module>maven-it-plugin-packaging</module>
<module>maven-it-plugin-parameter-implementation</module>
<module>maven-it-plugin-plugin-dependency</module>