[MNG-2720] Adding integration test.

git-svn-id: https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk@741834 13f79535-47bb-0310-9956-ffa450edef68

its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java

@@ -223,6 +223,7 @@ public class IntegrationTestSuite
         suite.addTestSuite( MavenITmng2749ExtensionAvailableToPluginTest.class );
         suite.addTestSuite( MavenITmng2744checksumVerificationTest.class );
         suite.addTestSuite( MavenITmng2739RequiredRepositoryElementsTest.class );
+        suite.addTestSuite( MavenITmng2720SiblingClasspathArtifactsTest.class );
         suite.addTestSuite( MavenITmng2695OfflinePluginSnapshotsTest.class );
         suite.addTestSuite( MavenITmng2668UsePluginDependenciesForSortingTest.class );
         suite.addTestSuite( MavenITmng2605BogusProfileActivationTest.class );

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2720SiblingClasspathArtifactsTest.java

@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.maven.it;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.maven.artifact.versioning.InvalidVersionSpecificationException;
+import org.apache.maven.it.AbstractMavenIntegrationTestCase;
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+/**
+ * This is a test set for <a href="http://jira.codehaus.org/browse/MNG-2720">MNG-2720</a>.
+ * 
+ * This test will ensure that running the 'package' phase on a multimodule build with child
+ * interdependency will result in one child using the JAR of the other child in its compile
+ * classpath, NOT the target/classes directory. This is critical, since sibling projects might
+ * use literally ANY artifact produced by another module project, and limiting to target/classes
+ * and target/test-classes eliminates many of the options that would be possible if the dependent
+ * sibling were built on its own.
+ *
+ * @author jdcasey
+ * 
+ */
+public class MavenITmng2720SiblingClasspathArtifactsTest
+    extends AbstractMavenIntegrationTestCase
+{
+    public MavenITmng2720SiblingClasspathArtifactsTest()
+        throws InvalidVersionSpecificationException
+    {
+        super( "(2.0.99,2.99.99)" );
+    }
+
+    public void testIT ()
+        throws Exception
+    {
+        File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-2720" );
+        File pluginDir = new File( testDir, "plugin" );
+        File projectDir = new File( testDir, "project-hierarchy" );
+
+        // First, install the plugin used for the test.
+        Verifier verifier = new Verifier( pluginDir.getAbsolutePath() );
+        verifier.executeGoal( "install" );
+        verifier.verifyErrorFreeLog();
+        verifier.resetStreams();
+        
+        // Now, build the project hierarchy that uses the plugin to verify sibling dependencies.
+        verifier = new Verifier( projectDir.getAbsolutePath() );
+        verifier.executeGoal( "package" );
+        verifier.verifyErrorFreeLog();
+    }
+}

its/core-it-suite/src/test/resources/mng-2720/plugin/pom.xml

@@ -0,0 +1,21 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <groupId>org.apache.maven.its.mng2720</groupId>
+  <artifactId>maven-mng2720-plugin</artifactId>
+  <packaging>maven-plugin</packaging>
+  <version>1</version>
+  
+  <dependencies>
+    <dependency>
+    	<groupId>org.apache.maven</groupId>
+    	<artifactId>maven-plugin-api</artifactId>
+    	<version>2.0.9</version>
+    </dependency>
+    <dependency>
+    	<groupId>org.apache.maven</groupId>
+    	<artifactId>maven-project</artifactId>
+    	<version>2.0.9</version>
+    </dependency>
+  </dependencies>
+</project>

its/core-it-suite/src/test/resources/mng-2720/plugin/src/main/java/org/apache/maven/debug/mng2720/ClasspathMojo.java

@@ -0,0 +1,88 @@
+package org.apache.maven.debug.mng2720;
+
+import org.apache.maven.artifact.DependencyResolutionRequiredException;
+import org.apache.maven.plugin.Mojo;
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.MojoFailureException;
+import org.apache.maven.plugin.logging.Log;
+import org.apache.maven.project.MavenProject;
+
+import java.util.Iterator;
+import java.util.List;
+
+/**
+ * @goal test
+ * @requiresDependencyResolution compile
+ * @phase package
+ */
+public class ClasspathMojo
+    implements Mojo
+{
+    
+    /**
+     * @parameter default-value="${project}"
+     * @readonly
+     */
+    private MavenProject project;
+    
+    /**
+     * @parameter default-value="${project.compileClasspathElements}"
+     * @readonly
+     */
+    private List compileClasspathElements;
+
+    private Log log;
+
+    public void execute() throws MojoExecutionException, MojoFailureException
+    {
+        if ( "child2".equals( project.getArtifactId() ) )
+        {
+            boolean found = false;
+            for ( Iterator it = compileClasspathElements.iterator(); it.hasNext(); )
+            {
+                String path = (String) it.next();
+                if ( path.indexOf( "child1-1.jar" ) > -1 )
+                {
+                    found = true;
+                    break;
+                }
+            }
+            
+            if ( !found )
+            {
+                throw new MojoExecutionException( "child1-1.jar dependency artifact path not found in compile classpath for project: " + project.getId() );
+            }
+        }
+        else if ( "child3".equals( project.getArtifactId() ) )
+        {
+            boolean found = false;
+            for ( Iterator it = compileClasspathElements.iterator(); it.hasNext(); )
+            {
+                String path = (String) it.next();
+                if ( path.indexOf( "child1-1-tests.jar" ) > -1 )
+                {
+                    found = true;
+                    break;
+                }
+            }
+            
+            if ( !found )
+            {
+                throw new MojoExecutionException( "child1-1-tests.jar dependency artifact path not found in compile classpath for project: " + project.getId() );
+            }
+        }
+        
+        log.info( "Tests succeeded." );
+    }
+
+    public Log getLog()
+    {
+        return log;
+    }
+
+    public void setLog( Log log )
+    {
+        this.log = log;
+    }
+
+}

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/child1/pom.xml

@@ -0,0 +1,38 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.apache.maven.its.mng2720</groupId>
+    <artifactId>project-hierarchy</artifactId>
+    <version>1</version>
+  </parent>
+  
+  <artifactId>child1</artifactId>
+  
+  <name>MNG-2720 Project Hierarchy 1 Child 1</name>
+
+  <dependencies>
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>
+      <version>3.8.1</version>
+      <scope>test</scope>
+    </dependency>
+  </dependencies>
+  
+  <build>
+    <plugins>
+      <plugin>
+        <artifactId>maven-jar-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>test-jar</id>
+            <goals>
+              <goal>test-jar</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/child1/src/main/java/org/apache/maven/debug/mng2720/App.java

@@ -0,0 +1,13 @@
+package org.apache.maven.debug.mng2720;
+
+/**
+ * Hello world!
+ *
+ */
+public class App 
+{
+    public static void main( String[] args )
+    {
+        System.out.println( "Hello World!" );
+    }
+}

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/child1/src/test/java/org/apache/maven/debug/mng2720/AppTest.java

@@ -0,0 +1,38 @@
+package org.apache.maven.debug.mng2720;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * Unit test for simple App.
+ */
+public class AppTest 
+    extends TestCase
+{
+    /**
+     * Create the test case
+     *
+     * @param testName name of the test case
+     */
+    public AppTest( String testName )
+    {
+        super( testName );
+    }
+
+    /**
+     * @return the suite of tests being tested
+     */
+    public static Test suite()
+    {
+        return new TestSuite( AppTest.class );
+    }
+
+    /**
+     * Rigourous Test :-)
+     */
+    public void testApp()
+    {
+        assertTrue( true );
+    }
+}

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/child2/pom.xml

@@ -0,0 +1,27 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.apache.maven.its.mng2720</groupId>
+    <artifactId>project-hierarchy</artifactId>
+    <version>1</version>
+  </parent>
+  
+  <artifactId>child2</artifactId>
+  
+  <name>MNG-2720 Project Hierarchy 1 Child 2</name>
+
+  <dependencies>
+    <dependency>
+      <groupId>org.apache.maven.its.mng2720</groupId>
+      <artifactId>child1</artifactId>
+      <version>1</version>
+    </dependency>
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>
+      <version>3.8.1</version>
+      <scope>test</scope>
+    </dependency>
+  </dependencies>
+</project>

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/child2/src/main/java/org/apache/maven/debug/mng2720/App.java

@@ -0,0 +1,13 @@
+package org.apache.maven.debug.mng2720;
+
+/**
+ * Hello world!
+ *
+ */
+public class App 
+{
+    public static void main( String[] args )
+    {
+        System.out.println( "Hello World!" );
+    }
+}

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/child2/src/test/java/org/apache/maven/debug/mng2720/AppTest.java

@@ -0,0 +1,38 @@
+package org.apache.maven.debug.mng2720;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * Unit test for simple App.
+ */
+public class AppTest 
+    extends TestCase
+{
+    /**
+     * Create the test case
+     *
+     * @param testName name of the test case
+     */
+    public AppTest( String testName )
+    {
+        super( testName );
+    }
+
+    /**
+     * @return the suite of tests being tested
+     */
+    public static Test suite()
+    {
+        return new TestSuite( AppTest.class );
+    }
+
+    /**
+     * Rigourous Test :-)
+     */
+    public void testApp()
+    {
+        assertTrue( true );
+    }
+}

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/child3/pom.xml

@@ -0,0 +1,28 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.apache.maven.its.mng2720</groupId>
+    <artifactId>project-hierarchy</artifactId>
+    <version>1</version>
+  </parent>
+  
+  <artifactId>child3</artifactId>
+  
+  <name>MNG-2720 Project Hierarchy 1 Child 3</name>
+
+  <dependencies>
+    <dependency>
+      <groupId>org.apache.maven.its.mng2720</groupId>
+      <artifactId>child1</artifactId>
+      <version>1</version>
+      <type>test-jar</type>
+    </dependency>
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>
+      <version>3.8.1</version>
+      <scope>test</scope>
+    </dependency>
+  </dependencies>
+</project>

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/child3/src/main/java/org/apache/maven/debug/mng2720/App.java

@@ -0,0 +1,13 @@
+package org.apache.maven.debug.mng2720;
+
+/**
+ * Hello world!
+ *
+ */
+public class App 
+{
+    public static void main( String[] args )
+    {
+        System.out.println( "Hello World!" );
+    }
+}

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/child3/src/test/java/org/apache/maven/debug/mng2720/AppTest.java

@@ -0,0 +1,38 @@
+package org.apache.maven.debug.mng2720;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * Unit test for simple App.
+ */
+public class AppTest 
+    extends TestCase
+{
+    /**
+     * Create the test case
+     *
+     * @param testName name of the test case
+     */
+    public AppTest( String testName )
+    {
+        super( testName );
+    }
+
+    /**
+     * @return the suite of tests being tested
+     */
+    public static Test suite()
+    {
+        return new TestSuite( AppTest.class );
+    }
+
+    /**
+     * Rigourous Test :-)
+     */
+    public void testApp()
+    {
+        assertTrue( true );
+    }
+}

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/pom.xml

@@ -0,0 +1,34 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <groupId>org.apache.maven.its.mng2720</groupId>
+  <artifactId>project-hierarchy</artifactId>
+  <packaging>pom</packaging>
+  <version>1</version>
+  <name>MNG-2720 Project Hierarchy 1</name>
+  
+  <modules>
+    <module>child1</module>
+    <module>child2</module>
+    <module>child3</module>
+  </modules>
+  
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.its.mng2720</groupId>
+        <artifactId>maven-mng2720-plugin</artifactId>
+        <version>1</version>
+        <executions>
+          <execution>
+            <id>test</id>
+            <phase>package</phase>
+            <goals>
+              <goal>test</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/src/main/java/org/apache/maven/debug/mng2720/App.java

@@ -0,0 +1,13 @@
+package org.apache.maven.debug.mng2720;
+
+/**
+ * Hello world!
+ *
+ */
+public class App 
+{
+    public static void main( String[] args )
+    {
+        System.out.println( "Hello World!" );
+    }
+}

its/core-it-suite/src/test/resources/mng-2720/project-hierarchy/src/test/java/org/apache/maven/debug/mng2720/AppTest.java

@@ -0,0 +1,38 @@
+package org.apache.maven.debug.mng2720;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * Unit test for simple App.
+ */
+public class AppTest 
+    extends TestCase
+{
+    /**
+     * Create the test case
+     *
+     * @param testName name of the test case
+     */
+    public AppTest( String testName )
+    {
+        super( testName );
+    }
+
+    /**
+     * @return the suite of tests being tested
+     */
+    public static Test suite()
+    {
+        return new TestSuite( AppTest.class );
+    }
+
+    /**
+     * Rigourous Test :-)
+     */
+    public void testApp()
+    {
+        assertTrue( true );
+    }
+}