Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MNG-6411] Improve readability of project list returned when --resume-from option value is invalid 

This closes #164
This commit is contained in:
Łukasz Dywicki 2018-05-11 15:38:04 +02:00 committed by Hervé Boutemy
parent 3c3a5901f3
commit 454a4e7954
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
View File

@ -25,6 +25,7 @@ import java.util.Arrays;
import java.util.Collection; import java.util.Collection;
import java.util.Collections; import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.Iterator;
import java.util.LinkedHashSet; import java.util.LinkedHashSet;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
@ -311,13 +312,29 @@ public class DefaultGraphBuilder
if ( !resumed ) if ( !resumed )
{ {
throw new MavenExecutionException( "Could not find project to resume reactor build from: " + selector throw new MavenExecutionException( "Could not find project to resume reactor build from: " + selector
+ " vs " + projects, request.getPom() ); + " vs " + formatProjects( projects ), request.getPom() );
} }
} }
return result; return result;
} }
private String formatProjects( List<MavenProject> projects )
{
StringBuilder projectNames = new StringBuilder();
Iterator<MavenProject> iterator = projects.iterator();
while ( iterator.hasNext() )
{
MavenProject project = iterator.next();
projectNames.append( project.getGroupId() ).append( ":" ).append( project.getArtifactId() );
if ( iterator.hasNext() )
{
projectNames.append( ", " );
}
}
return projectNames.toString();
}
private boolean isMatchingProject( MavenProject project, String selector, File reactorDirectory ) private boolean isMatchingProject( MavenProject project, String selector, File reactorDirectory )
{ {
// [groupId]:artifactId // [groupId]:artifactId