Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MNG-6275] Defang the tests when their core assumption is invalid. 

- The tests assume that the JRE has a ScriptEngineFactory
- Not all JREs have a ScriptEngineFactory (I'm looking at Azul's Zulu Open JDK 7 builds)
- Ideally we'd skip these tests using Assume.assumeThat(...) but PlexusTestCase doesn't support
  AssumptionViolatedException for marking tests as skipped.

Issue identified during testing of the 3.5.1 release candidate
This commit is contained in:
Stephen Connolly 2017-09-11 10:25:11 +01:00
parent 312eb53502
commit 542a7a8915
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
maven-core/src/test/java/org/apache/maven/classrealm/DefaultClassRealmManagerTest.java
View File

@ -34,6 +34,7 @@ import org.junit.Test;
public class DefaultClassRealmManagerTest extends PlexusTestCase
{
private ClassRealmManager classRealmManager;
private boolean haveScriptEngineFactory;
@Override
protected void setUp()
@ -41,6 +42,11 @@ public class DefaultClassRealmManagerTest extends PlexusTestCase
{
super.setUp();
this.classRealmManager = lookup( ClassRealmManager.class );
ClassLoader testRealm = getClass().getClassLoader();
ServiceLoader<ScriptEngineFactory> sef = ServiceLoader.load( ScriptEngineFactory.class, testRealm );
// TODO switch to Assume.assumeTrue( sef.iterator().hasNext() ) when PlexusTestCase
// supports assumptions. Not every Java 7 JRE has a ScriptEngineFactory.
this.haveScriptEngineFactory = sef.iterator().hasNext();
}
@Override
@ -59,7 +65,7 @@ public class DefaultClassRealmManagerTest extends PlexusTestCase
ClassRealm pluginRealm = classRealmManager.createPluginRealm( plugin, parent, null, null, null );
ServiceLoader<ScriptEngineFactory> sef = ServiceLoader.load( ScriptEngineFactory.class, pluginRealm );
assertTrue( sef.iterator().hasNext() );
assertEquals( haveScriptEngineFactory, sef.iterator().hasNext() );
}
@Test
@ -70,7 +76,7 @@ public class DefaultClassRealmManagerTest extends PlexusTestCase
ClassRealm extensionRealm = classRealmManager.createExtensionRealm( extension, null );
ServiceLoader<ScriptEngineFactory> sef = ServiceLoader.load( ScriptEngineFactory.class, extensionRealm );
assertTrue( sef.iterator().hasNext() );
assertEquals( haveScriptEngineFactory, sef.iterator().hasNext() );
}
@Test
@ -80,7 +86,7 @@ public class DefaultClassRealmManagerTest extends PlexusTestCase
ClassRealm projectRealm = classRealmManager.createProjectRealm( model, null );
ServiceLoader<ScriptEngineFactory> sef = ServiceLoader.load( ScriptEngineFactory.class, projectRealm );
assertTrue( sef.iterator().hasNext() );
assertEquals( haveScriptEngineFactory, sef.iterator().hasNext() );
}
@Test
@ -88,7 +94,7 @@ public class DefaultClassRealmManagerTest extends PlexusTestCase
{
ClassRealm mavenApiRealm = classRealmManager.getMavenApiRealm();
ServiceLoader<ScriptEngineFactory> sef = ServiceLoader.load( ScriptEngineFactory.class, mavenApiRealm );
assertTrue( sef.iterator().hasNext() );
assertEquals( haveScriptEngineFactory, sef.iterator().hasNext() );
}
@Test
@ -96,6 +102,6 @@ public class DefaultClassRealmManagerTest extends PlexusTestCase
{
ClassRealm coreRealm = classRealmManager.getCoreRealm();
ServiceLoader<ScriptEngineFactory> sef = ServiceLoader.load( ScriptEngineFactory.class, coreRealm );
assertTrue( sef.iterator().hasNext() );
assertEquals( haveScriptEngineFactory, sef.iterator().hasNext() );
}
}