From 542ee6f24a883734064724b823f173585982abe1 Mon Sep 17 00:00:00 2001 From: Benjamin Bentmann Date: Fri, 18 Sep 2009 09:51:29 +0000 Subject: [PATCH] [MNG-4343] maven always checks missing release artifacts o Added IT git-svn-id: https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk@816564 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/maven/it/IntegrationTestSuite.java | 1 + ...mng4343MissingReleaseUpdatePolicyTest.java | 256 ++++++++++++++++++ .../src/test/resources/mng-4343/pom.xml | 63 +++++ .../resources/mng-4343/settings-template.xml | 44 +++ 4 files changed, 364 insertions(+) create mode 100644 its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4343MissingReleaseUpdatePolicyTest.java create mode 100644 its/core-it-suite/src/test/resources/mng-4343/pom.xml create mode 100644 its/core-it-suite/src/test/resources/mng-4343/settings-template.xml diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java index 68eec40753..c5a5fc3ddb 100644 --- a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java +++ b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java @@ -97,6 +97,7 @@ public class IntegrationTestSuite suite.addTestSuite( MavenITmng4347ImportScopeWithSettingsProfilesTest.class ); suite.addTestSuite( MavenITmng4345DefaultPluginExecutionOrderTest.class ); suite.addTestSuite( MavenITmng4344ManagedPluginExecutionOrderTest.class ); + suite.addTestSuite( MavenITmng4343MissingReleaseUpdatePolicyTest.class ); suite.addTestSuite( MavenITmng4342IndependentMojoParameterDefaultValuesTest.class ); suite.addTestSuite( MavenITmng4341PluginExecutionOrderTest.class ); suite.addTestSuite( MavenITmng4338OptionalMojosTest.class ); diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4343MissingReleaseUpdatePolicyTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4343MissingReleaseUpdatePolicyTest.java new file mode 100644 index 0000000000..ec570f4582 --- /dev/null +++ b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4343MissingReleaseUpdatePolicyTest.java @@ -0,0 +1,256 @@ +package org.apache.maven.it; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.it.Verifier; +import org.apache.maven.it.util.ResourceExtractor; + +import java.io.File; +import java.io.IOException; +import java.io.PrintWriter; +import java.util.ArrayList; +import java.util.List; +import java.util.Properties; + +import javax.servlet.ServletException; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; + +import org.mortbay.jetty.Handler; +import org.mortbay.jetty.Request; +import org.mortbay.jetty.Server; +import org.mortbay.jetty.handler.AbstractHandler; + +/** + * This is a test set for MNG-4343. + * + * @author Benjamin Bentmann + * @version $Id$ + */ +public class MavenITmng4343MissingReleaseUpdatePolicyTest + extends AbstractMavenIntegrationTestCase +{ + + private Server server; + + private List requestedUris; + + private boolean blockAccess; + + public MavenITmng4343MissingReleaseUpdatePolicyTest() + { + super( "[3.0-alpha-3,)" ); + } + + protected void setUp() + throws Exception + { + Handler repoHandler = new AbstractHandler() + { + public void handle( String target, HttpServletRequest request, HttpServletResponse response, int dispatch ) + throws IOException, ServletException + { + System.out.println( "Handling " + request.getMethod() + " " + request.getRequestURL() ); + + if ( request.getRequestURI().startsWith( "/org/apache/maven/its/mng4343" ) ) + { + requestedUris.add( request.getRequestURI() ); + } + + if ( blockAccess ) + { + response.setStatus( HttpServletResponse.SC_NOT_FOUND ); + } + else + { + PrintWriter writer = response.getWriter(); + + response.setStatus( HttpServletResponse.SC_OK ); + + if ( request.getRequestURI().endsWith( ".pom" ) ) + { + writer.println( "" ); + writer.println( " 4.0.0" ); + writer.println( " org.apache.maven.its.mng4343" ); + writer.println( " dep" ); + writer.println( " 0.1" ); + writer.println( "" ); + } + else if ( request.getRequestURI().endsWith( ".jar" ) ) + { + writer.println( "empty" ); + } + else if ( request.getRequestURI().endsWith( ".md5" ) || request.getRequestURI().endsWith( ".sha1" ) ) + { + response.setStatus( HttpServletResponse.SC_NOT_FOUND ); + } + } + + ( (Request) request ).setHandled( true ); + } + }; + + server = new Server( 0 ); + server.setHandler( repoHandler ); + server.start(); + + requestedUris = new ArrayList(); + } + + protected void tearDown() + throws Exception + { + if ( server != null ) + { + server.stop(); + server = null; + } + requestedUris = null; + } + + /** + * Verify that checking for *missing* release artifacts respects the update policy that is configured in the + * release section for the respective repository, in this case "always". + */ + public void testitAlways() + throws Exception + { + File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4343" ); + + Verifier verifier = new Verifier( testDir.getAbsolutePath() ); + verifier.setAutoclean( false ); + verifier.deleteArtifacts( "org.apache.maven.its.mng4343" ); + verifier.getCliOptions().add( "-s" ); + verifier.getCliOptions().add( "settings.xml" ); + + Properties filterProps = verifier.newDefaultFilterProperties(); + filterProps.setProperty( "@updates@", "always" ); + filterProps.setProperty( "@port@", Integer.toString( server.getConnectors()[0].getLocalPort() ) ); + verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", filterProps ); + + blockAccess = true; + + verifier.setLogFileName( "log-always-1.txt" ); + try + { + verifier.executeGoal( "validate" ); + verifier.verifyErrorFreeLog(); + fail( "Build succeeded despite missing dependency" ); + } + catch ( VerificationException e ) + { + // expected + } + + assertTrue( requestedUris.toString(), requestedUris.contains( "/org/apache/maven/its/mng4343/dep/0.1/dep-0.1.jar" ) ); + requestedUris.clear(); + + blockAccess = false; + + verifier.setLogFileName( "log-always-2.txt" ); + verifier.executeGoal( "validate" ); + verifier.verifyErrorFreeLog(); + + assertTrue( requestedUris.toString(), requestedUris.contains( "/org/apache/maven/its/mng4343/dep/0.1/dep-0.1.jar" ) ); + assertTrue( requestedUris.toString(), requestedUris.contains( "/org/apache/maven/its/mng4343/dep/0.1/dep-0.1.pom" ) ); + verifier.assertArtifactPresent( "org.apache.maven.its.mng4343", "dep", "0.1", "jar" ); + verifier.assertArtifactPresent( "org.apache.maven.its.mng4343", "dep", "0.1", "pom" ); + + verifier.resetStreams(); + } + + /** + * Verify that checking for *missing* release artifacts respects the update policy that is configured in the + * release section for the respective repository, in this case "never", unless overriden from the CLI via -U. + */ + public void testitNever() + throws Exception + { + File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4343" ); + + Verifier verifier = new Verifier( testDir.getAbsolutePath() ); + verifier.setAutoclean( false ); + verifier.deleteArtifacts( "org.apache.maven.its.mng4343" ); + verifier.getCliOptions().add( "-s" ); + verifier.getCliOptions().add( "settings.xml" ); + + Properties filterProps = verifier.newDefaultFilterProperties(); + filterProps.setProperty( "@updates@", "never" ); + filterProps.setProperty( "@port@", Integer.toString( server.getConnectors()[0].getLocalPort() ) ); + verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", filterProps ); + + blockAccess = true; + + verifier.setLogFileName( "log-never-1.txt" ); + try + { + verifier.executeGoal( "validate" ); + verifier.verifyErrorFreeLog(); + fail( "Build succeeded despite missing dependency" ); + } + catch ( VerificationException e ) + { + // expected + } + + assertTrue( requestedUris.toString(), requestedUris.contains( "/org/apache/maven/its/mng4343/dep/0.1/dep-0.1.jar" ) ); + requestedUris.clear(); + + blockAccess = false; + + verifier.setLogFileName( "log-never-2.txt" ); + try + { + verifier.executeGoal( "validate" ); + verifier.verifyErrorFreeLog(); + fail( "Remote repository was accessed despite updatePolicy=never" ); + } + catch ( VerificationException e ) + { + // expected + } + + assertEquals( new ArrayList(), requestedUris ); + verifier.assertArtifactNotPresent( "org.apache.maven.its.mng4343", "dep", "0.1", "jar" ); + verifier.assertArtifactNotPresent( "org.apache.maven.its.mng4343", "dep", "0.1", "pom" ); + + verifier.setLogFileName( "log-never-3.txt" ); + verifier.getCliOptions().add( "-U" ); + verifier.executeGoal( "validate" ); + verifier.verifyErrorFreeLog(); + + assertTrue( requestedUris.toString(), requestedUris.contains( "/org/apache/maven/its/mng4343/dep/0.1/dep-0.1.jar" ) ); + assertTrue( requestedUris.toString(), requestedUris.contains( "/org/apache/maven/its/mng4343/dep/0.1/dep-0.1.pom" ) ); + verifier.assertArtifactPresent( "org.apache.maven.its.mng4343", "dep", "0.1", "jar" ); + verifier.assertArtifactPresent( "org.apache.maven.its.mng4343", "dep", "0.1", "pom" ); + + requestedUris.clear(); + + verifier.setLogFileName( "log-never-4.txt" ); + verifier.getCliOptions().add( "-U" ); + verifier.executeGoal( "validate" ); + verifier.verifyErrorFreeLog(); + + assertEquals( new ArrayList(), requestedUris ); + + verifier.resetStreams(); + } + +} diff --git a/its/core-it-suite/src/test/resources/mng-4343/pom.xml b/its/core-it-suite/src/test/resources/mng-4343/pom.xml new file mode 100644 index 0000000000..5657fbe061 --- /dev/null +++ b/its/core-it-suite/src/test/resources/mng-4343/pom.xml @@ -0,0 +1,63 @@ + + + + + + 4.0.0 + + org.apache.maven.its.mng4343 + test + 0.1 + jar + + Maven Integration Test :: MNG-4343 + + Verify that checking for *missing* release artifacts respects the update policy that is configured in the + release section for the respective repository or set globally via "-U". + + + + + org.apache.maven.its.mng4343 + dep + 0.1 + compile + + + + + + + org.apache.maven.its.plugins + maven-it-plugin-dependency-resolution + 2.1-SNAPSHOT + + + test + validate + + compile + + + + + + + diff --git a/its/core-it-suite/src/test/resources/mng-4343/settings-template.xml b/its/core-it-suite/src/test/resources/mng-4343/settings-template.xml new file mode 100644 index 0000000000..7669a9257c --- /dev/null +++ b/its/core-it-suite/src/test/resources/mng-4343/settings-template.xml @@ -0,0 +1,44 @@ + + + + + + + + maven-core-it-repo + + + maven-core-it + http://localhost:@port@/ + + ignore + @updates@ + + + false + + + + + + + maven-core-it-repo + +