From 56932ec01d3ef611d01737c2de696e6eb224ead4 Mon Sep 17 00:00:00 2001 From: Benjamin Bentmann Date: Mon, 26 Apr 2010 17:56:55 +0000 Subject: [PATCH] [MNG-4644] Misplaced text contents in root element of POM is not rejected by parser o Added IT git-svn-id: https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk@938155 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/maven/it/IntegrationTestSuite.java | 1 + ...ictPomParsingRejectsMisplacedTextTest.java | 69 +++++++++++++++++++ .../src/test/resources/mng-4644/pom.xml | 35 ++++++++++ 3 files changed, 105 insertions(+) create mode 100644 its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4644StrictPomParsingRejectsMisplacedTextTest.java create mode 100644 its/core-it-suite/src/test/resources/mng-4644/pom.xml diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java index d0e3fc85c6..324f36939b 100644 --- a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java +++ b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java @@ -82,6 +82,7 @@ public static Test suite() // suite.addTestSuite( MavenIT0109ReleaseUpdateTest.class ); // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137 + suite.addTestSuite( MavenITmng4644StrictPomParsingRejectsMisplacedTextTest.class ); suite.addTestSuite( MavenITmng4629NoPomValidationErrorUponMissingSystemDepTest.class ); suite.addTestSuite( MavenITmng4625SettingsXmlInterpolationWithXmlMarkupTest.class ); suite.addTestSuite( MavenITmng4618AggregatorBuiltAfterModulesTest.class ); diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4644StrictPomParsingRejectsMisplacedTextTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4644StrictPomParsingRejectsMisplacedTextTest.java new file mode 100644 index 0000000000..c0e364ce72 --- /dev/null +++ b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4644StrictPomParsingRejectsMisplacedTextTest.java @@ -0,0 +1,69 @@ +package org.apache.maven.it; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.it.VerificationException; +import org.apache.maven.it.Verifier; +import org.apache.maven.it.util.ResourceExtractor; + +import java.io.File; + +/** + * This is a test set for MNG-4644. + * + * @author Benjamin Bentmann + */ +public class MavenITmng4644StrictPomParsingRejectsMisplacedTextTest + extends AbstractMavenIntegrationTestCase +{ + + public MavenITmng4644StrictPomParsingRejectsMisplacedTextTest() + { + super( "[3.0-alpha-7,)" ); + } + + /** + * Verify that misplaced text inside the project element of a POM causes a parser error during reactor builds. + */ + public void testit() + throws Exception + { + File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4644" ); + + Verifier verifier = new Verifier( testDir.getAbsolutePath() ); + verifier.setAutoclean( false ); + try + { + verifier.executeGoal( "validate" ); + verifier.verifyErrorFreeLog(); + + fail( "Should fail to validate the POM syntax due to misplaced text in element." ); + } + catch ( VerificationException e ) + { + // expected + } + finally + { + verifier.resetStreams(); + } + } + +} diff --git a/its/core-it-suite/src/test/resources/mng-4644/pom.xml b/its/core-it-suite/src/test/resources/mng-4644/pom.xml new file mode 100644 index 0000000000..b0c53f5de4 --- /dev/null +++ b/its/core-it-suite/src/test/resources/mng-4644/pom.xml @@ -0,0 +1,35 @@ + + + + + + 4.0.0 + + org.apache.maven.its.mng4644 + test + 0.1 + + Maven Integration Test :: MNG-4644 + + Verify that misplaced text inside the project element of a POM causes a parser error during reactor builds. + + + This text must not be allowed here... +