Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MNG-6342] Emit a WARNING about LATEST/RELEASE in parent

This commit is contained in:
Karl Heinz Marbaise 2018-01-18 15:50:36 +01:00
parent 6285bb96c5
commit 5988085525
4 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
View File

@ -105,6 +105,13 @@ public class DefaultModelValidator
+ ", the parent element cannot have the same groupId:artifactId as the project.", + ", the parent element cannot have the same groupId:artifactId as the project.",
parent ); parent );
} }
if ( equals( "LATEST", parent.getVersion() ) || equals( "RELEASE", parent.getVersion() ) )
{
addViolation( problems, Severity.WARNING, Version.BASE, "parent.version", null,
"is either LATEST or RELEASE (both of them are being deprecated)", parent );
}
} }
if ( request.getValidationLevel() >= ModelBuildingRequest.VALIDATION_LEVEL_MAVEN_2_0 ) if ( request.getValidationLevel() >= ModelBuildingRequest.VALIDATION_LEVEL_MAVEN_2_0 )

15
maven-model-builder/src/test/java/org/apache/maven/model/validation/DefaultModelValidatorTest.java
View File

@ -781,4 +781,19 @@ public class DefaultModelValidatorTest
assertEquals( "'version' contains an expression but should be a constant.", result.getWarnings().get( 0 ) ); assertEquals( "'version' contains an expression but should be a constant.", result.getWarnings().get( 0 ) );
} }
public void testParentVersionLATEST()
throws Exception
{
SimpleProblemCollector result = validateRaw( "raw-model/bad-parent-version-latest.xml" );
assertViolations( result, 0, 0, 1 );
assertEquals( "'parent.version' is either LATEST or RELEASE (both of them are being deprecated)", result.getWarnings().get( 0 ) );
}
public void testParentVersionRELEASE()
throws Exception
{
SimpleProblemCollector result = validateRaw( "raw-model/bad-parent-version-release.xml" );
assertViolations( result, 0, 0, 1 );
assertEquals( "'parent.version' is either LATEST or RELEASE (both of them are being deprecated)", result.getWarnings().get( 0 ) );
}
} }

37
maven-model-builder/src/test/resources/poms/validation/raw-model/bad-parent-version-latest.xml Normal file
View File

@ -0,0 +1,37 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.example.group</groupId>
<artifactId>com-parent</artifactId>
<version>LATEST</version>
</parent>
<groupId>com.example.group</groupId>
<artifactId>valid-version-wrong</artifactId>
<version>1.0</version>
<description>
This will test if the validation for the parent version
is working correct in case of usage of LATEST
</description>
</project>

37
maven-model-builder/src/test/resources/poms/validation/raw-model/bad-parent-version-release.xml Normal file
View File

@ -0,0 +1,37 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>com.example.group</groupId>
<artifactId>com-parent</artifactId>
<version>RELEASE</version>
</parent>
<groupId>com.example.group</groupId>
<artifactId>valid-version-wrong</artifactId>
<version>1.0</version>
<description>
This will test if the validation for the parent version
is working correct in case of usage of RELEASE
</description>
</project>