From 5f939ed28586926b706d616c511d37a055f951bc Mon Sep 17 00:00:00 2001
From: Benjamin Bentmann <bentmann@apache.org>
Date: Sat, 19 Dec 2009 23:56:41 +0000
Subject: [PATCH] [MNG-4500] [regression] Maven checks for updates of
 timestamped snapshots

o Added IT

git-svn-id: https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk@892534 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/maven/it/IntegrationTestSuite.java |   1 +
 ...500NoUpdateOfTimestampedSnapshotsTest.java | 129 ++++++++++++++++++
 .../src/test/resources/mng-4500/pom.xml       |  65 +++++++++
 .../dep-0.1-20091219.230823-1.jar             | Bin 0 -> 1989 bytes
 .../dep-0.1-20091219.230823-1.pom             |  38 ++++++
 .../dep/0.1-SNAPSHOT/maven-metadata.xml       |  13 ++
 .../resources/mng-4500/settings-template.xml  |  45 ++++++
 7 files changed, 291 insertions(+)
 create mode 100644 its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4500NoUpdateOfTimestampedSnapshotsTest.java
 create mode 100644 its/core-it-suite/src/test/resources/mng-4500/pom.xml
 create mode 100644 its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/dep-0.1-20091219.230823-1.jar
 create mode 100644 its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/dep-0.1-20091219.230823-1.pom
 create mode 100644 its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/maven-metadata.xml
 create mode 100644 its/core-it-suite/src/test/resources/mng-4500/settings-template.xml

diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
index 8f894aadf7..0ddb87e7de 100644
--- a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
+++ b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
@@ -85,6 +85,7 @@ public class IntegrationTestSuite
         // suite.addTestSuite( MavenIT0109ReleaseUpdateTest.class );
         // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137
 
+        suite.addTestSuite( MavenITmng4500NoUpdateOfTimestampedSnapshotsTest.class );
         suite.addTestSuite( MavenITmng4498IgnoreBrokenMetadataTest.class );
         suite.addTestSuite( MavenITmng4489MirroringOfExtensionRepoTest.class );
         suite.addTestSuite( MavenITmng4488ValidateExternalParenPomLenientTest.class );
diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4500NoUpdateOfTimestampedSnapshotsTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4500NoUpdateOfTimestampedSnapshotsTest.java
new file mode 100644
index 0000000000..55ee39cc74
--- /dev/null
+++ b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4500NoUpdateOfTimestampedSnapshotsTest.java
@@ -0,0 +1,129 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.it.Verifier;
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Properties;
+
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.mortbay.jetty.Server;
+import org.mortbay.jetty.handler.AbstractHandler;
+import org.mortbay.jetty.handler.DefaultHandler;
+import org.mortbay.jetty.handler.HandlerList;
+import org.mortbay.jetty.handler.ResourceHandler;
+
+/**
+ * This is a test set for <a href="http://jira.codehaus.org/browse/MNG-4500">MNG-4500</a>.
+ * 
+ * @author Benjamin Bentmann
+ */
+public class MavenITmng4500NoUpdateOfTimestampedSnapshotsTest
+    extends AbstractMavenIntegrationTestCase
+{
+
+    public MavenITmng4500NoUpdateOfTimestampedSnapshotsTest()
+    {
+        super( "[2.0.3,3.0-alpha-1),[3.0-alpha-6,)" );
+    }
+
+    /**
+     * Test that timestamped snapshots are treated as immutable, i.e. Maven should never check for updates of them
+     * once downloaded from a remote repo regardless of the update policy.
+     */
+    public void testit()
+        throws Exception
+    {
+        File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4500" );
+
+        String pomUri = "/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/dep-0.1-20091219.230823-1.pom";
+        String jarUri = "/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/dep-0.1-20091219.230823-1.jar";
+
+        final List requestedUris = new ArrayList();
+
+        AbstractHandler logHandler = new AbstractHandler()
+        {
+            public void handle( String target, HttpServletRequest request, HttpServletResponse response, int dispatch )
+                throws IOException, ServletException
+            {
+                requestedUris.add( request.getRequestURI() );
+            }
+        };
+
+        ResourceHandler repoHandler = new ResourceHandler();
+        repoHandler.setResourceBase( testDir.getAbsolutePath() );
+
+        HandlerList handlerList = new HandlerList();
+        handlerList.addHandler( logHandler );
+        handlerList.addHandler( repoHandler );
+        handlerList.addHandler( new DefaultHandler() );
+
+        Server server = new Server( 0 );
+        server.setHandler( handlerList );
+        server.start();
+
+        Verifier verifier = new Verifier( testDir.getAbsolutePath() );
+        try
+        {
+            verifier.setAutoclean( false );
+            verifier.deleteDirectory( "target" );
+            verifier.deleteArtifacts( "org.apache.maven.its.mng4500" );
+            Properties filterProps = verifier.newDefaultFilterProperties();
+            filterProps.setProperty( "@port@", Integer.toString( server.getConnectors()[0].getLocalPort() ) );
+            verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", filterProps );
+            verifier.getCliOptions().add( "-s" );
+            verifier.getCliOptions().add( "settings.xml" );
+
+            verifier.setLogFileName( "log-1.txt" );
+            verifier.executeGoal( "validate" );
+            verifier.verifyErrorFreeLog();
+
+            List classpath = verifier.loadLines( "target/classpath.txt", "UTF-8" );
+            assertTrue( classpath.toString(), classpath.contains( "dep-0.1-SNAPSHOT.jar" ) );
+            assertTrue( requestedUris.toString(), requestedUris.contains( pomUri ) );
+            assertTrue( requestedUris.toString(), requestedUris.contains( jarUri ) );
+
+            requestedUris.clear();
+
+            verifier.setLogFileName( "log-2.txt" );
+            verifier.executeGoal( "validate" );
+            verifier.verifyErrorFreeLog();
+
+            classpath = verifier.loadLines( "target/classpath.txt", "UTF-8" );
+            assertTrue( classpath.toString(), classpath.contains( "dep-0.1-SNAPSHOT.jar" ) );
+            assertFalse( requestedUris.toString(), requestedUris.contains( pomUri ) );
+            assertFalse( requestedUris.toString(), requestedUris.contains( jarUri ) );
+        }
+        finally
+        {
+            verifier.resetStreams();
+            server.stop();
+        }
+    }
+
+}
diff --git a/its/core-it-suite/src/test/resources/mng-4500/pom.xml b/its/core-it-suite/src/test/resources/mng-4500/pom.xml
new file mode 100644
index 0000000000..ec95966cd6
--- /dev/null
+++ b/its/core-it-suite/src/test/resources/mng-4500/pom.xml
@@ -0,0 +1,65 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>org.apache.maven.its.mng4500</groupId>
+  <artifactId>test</artifactId>
+  <version>0.1</version>
+
+  <name>Maven Integration Test :: MNG-4500</name>
+  <description>
+    Test that timestamped snapshots are treated as immutable, i.e. Maven should never check for updates of them
+    once downloaded from a remote repo regardless of the update policy.
+  </description>
+
+  <dependencies>
+    <dependency>
+      <groupId>org.apache.maven.its.mng4500</groupId>
+      <artifactId>dep</artifactId>
+      <version>0.1-SNAPSHOT</version>
+    </dependency>
+  </dependencies>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.its.plugins</groupId>
+        <artifactId>maven-it-plugin-dependency-resolution</artifactId>
+        <version>2.1-SNAPSHOT</version>
+        <configuration>
+          <testClassPath>target/classpath.txt</testClassPath>
+          <significantPathLevels>1</significantPathLevels>
+        </configuration>
+        <executions>
+          <execution>
+            <id>test</id>
+            <phase>validate</phase>
+            <goals>
+              <goal>test</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>
diff --git a/its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/dep-0.1-20091219.230823-1.jar b/its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/dep-0.1-20091219.230823-1.jar
new file mode 100644
index 0000000000000000000000000000000000000000..bb648e340b9a1724f9dfe6d99017416e9179e663
GIT binary patch
literal 1989
zcmWIWW@h1H00ADxDb`>Hl;8x?zOEsTx}JV+`T<a791Pq*WoK`tF{J{ftASVqS(&e+
zpQoE^aEP9-+h^Z1r+vJ2^)B*y>uQ}lbAEG>!4=~NPm6TC&YjTl)^*}wf3hTOikS8R
zm5QBnx`TwhgMv%uYONKK;TD=~93)yJd^+eeP{zx+*z3R}zjc1=1nRohg?pKuC@{8d
zu3#>X(~Hw%fH@1(_58@r%1taw&4c>^Q?U-F;{2j?y~KjV<cw53ux`D~l48BwymS*&
z0|PuJ8IWjFN@@YzG!6z<VAxiE&%M5%iGkr23j>2W8KxEF=jv7D=9Gqb=g%<^*r)ta
ze%Xq4x2S~Rr9o4L7UfRL4G`YOwIr}FZbs_d2H#%J$k4y<Wto3xte!XFZDmcrWYg#C
zt6IcEc&9%)WBF|v-+~h<=UfY)-C17zeQ~ket!cTe`7zhG<yEvTIw-S+Wv|<et2&GQ
zmBM!=b0z9UPc-&D`rxk4OnFAxz($db=paW`O|{8R+WT@$W2ZRVCbT-O33zdg*+by>
zqmN3xdg~I7dY?L1X`B-Hx$m{9>jyTgmGcr^TO;NbU!FGg0BdZBEywMk2!qrc0k^9b
zS8TkdVC~p)eb2JEm5LM3Y<HNo@Xduu7I`VwK^6(tT?UQsoAW;0n|;WdYlCijO>v*y
z*PWub8zxBIV*5UoG2VEMDWhsYXl#+1(J9%;x37eE9pBgzljU}CjXGmdsRWykbUnkh
zsO!u3-7lScylTO`kk<XG&+bo{R#@~@C_=bi-z!Hd;K$;pT_&-44Od%Klf9iHHu3eW
zIyUWI&Z~QxK@lRtx3jjD$<Nv}J(IiVg&f<2fF7B`G)|XJ=K1NKQ+ysMdaW1#u4!}T
z-Mh3xsaVwwJDR&)Yb2LmR9bdfChg<m+}hqpr#TfmU2;Ec4P&!QeB$PKhW}aG?fYk3
z-+Kio9}Blpj#`uv*%;t4t1|J}BDc_w$8OvZ*fWQ1;iFyh^Nwx%_wdQhX|MTy2WbCn
znaS7t#Zk3b=XfE9|DKiRynpQ9v2`~&o!r*<X~LYFvqCnCi^wfMx!$GlQ=-?*+bir^
zHP43YTrN4ck?&7)@qatLe2cGrcU9)qdao1De6at`uOJT7sx;P(yz^&p{rOwyq8icq
zaP2|Hi5DVPBsK@<n9P}XDEH4%*@mx;$(PPWaqUfQ3NihC+k8oQ>((5LwLjAKEVQ22
zZX0R7_<qCb(g&Yw{@+?<WOCb4`OW^nJ5#<)fB0&8J{Rl0N*V3n^;7x&{8v(3Wj(o$
z8J4j*z{S$?y9~^=z`W1^#CBxniGrg1g4Cjt%+zAhGrnAh3<Mk=)+&@sytrk+#;RKq
z7;>f6enMPA&aoM;lP4@=&Cidu`%!UqCUd%0&cm;*(r0CstT-d`;Dl`k%Mq#at=9@H
zO1&S)b<O<zA~_>qZTPc$c4wbn^n6$}=h9U(Lu=R0U;L{d?hoGAlf{v@*>y@&(Z~E(
zr<rusHR}Sr8JR?wahJG2-vNOD!&^rXja2@^v|%rSL5e|ONuxTDglj`8kMUUyDl8!Y
zWbr;A6K(>m=!991z3@b6evPS_Kv9a@WKdxW0U&3YGGaIjugQ?26=pj2!WCxzlE!8-
tOotY=h>*peS`n5^2bSq*AxqE;AWINwH^7^f4P+iW5ZVK4i2_y-4*+mQo&^8^

literal 0
HcmV?d00001

diff --git a/its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/dep-0.1-20091219.230823-1.pom b/its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/dep-0.1-20091219.230823-1.pom
new file mode 100644
index 0000000000..c26528cc73
--- /dev/null
+++ b/its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/dep-0.1-20091219.230823-1.pom
@@ -0,0 +1,38 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project>
+  <modelVersion>4.0.0</modelVersion>
+
+  <groupId>org.apache.maven.its.mng4500</groupId>
+  <artifactId>dep</artifactId>
+  <version>0.1-SNAPSHOT</version>
+  <packaging>jar</packaging>
+
+  <name>Maven Integration Test :: MNG-4500</name>
+
+  <distributionManagement>
+    <repository>
+      <id>maven-core-it</id>
+      <url>file:///${basedir}/repo</url>
+    </repository>
+  </distributionManagement>
+</project>
diff --git a/its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/maven-metadata.xml b/its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/maven-metadata.xml
new file mode 100644
index 0000000000..c1ec8c490e
--- /dev/null
+++ b/its/core-it-suite/src/test/resources/mng-4500/repo/org/apache/maven/its/mng4500/dep/0.1-SNAPSHOT/maven-metadata.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<metadata>
+  <groupId>org.apache.maven.its.mng4500</groupId>
+  <artifactId>dep</artifactId>
+  <version>0.1-SNAPSHOT</version>
+  <versioning>
+    <snapshot>
+      <timestamp>20091219.230823</timestamp>
+      <buildNumber>1</buildNumber>
+    </snapshot>
+    <lastUpdated>20091219230823</lastUpdated>
+  </versioning>
+</metadata>
diff --git a/its/core-it-suite/src/test/resources/mng-4500/settings-template.xml b/its/core-it-suite/src/test/resources/mng-4500/settings-template.xml
new file mode 100644
index 0000000000..dd8cfd62a9
--- /dev/null
+++ b/its/core-it-suite/src/test/resources/mng-4500/settings-template.xml
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<settings>
+  <profiles>
+    <profile>
+      <id>maven-core-it-repo</id>
+      <repositories>
+        <repository>
+          <id>maven-core-it</id>
+          <url>http://localhost:@port@/repo</url>
+          <releases>
+            <enabled>false</enabled>
+          </releases>
+          <snapshots>
+            <!-- The update policy should only apply to metadata but not to timestamped snapshots themselves! -->
+            <updatePolicy>always</updatePolicy>
+            <checksumPolicy>ignore</checksumPolicy>
+          </snapshots>
+        </repository>
+      </repositories>
+    </profile>
+  </profiles>
+  <activeProfiles>
+    <activeProfile>maven-core-it-repo</activeProfile>
+  </activeProfiles>
+</settings>