added generics

git-svn-id: https://svn.apache.org/repos/asf/maven/maven-3/trunk@1391579 13f79535-47bb-0310-9956-ffa450edef68

maven-core/src/test/java/org/apache/maven/lifecycle/internal/BuildListCalculatorTest.java

@@ -1,3 +1,5 @@
+package org.apache.maven.lifecycle.internal;
+
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
  * agreements. See the NOTICE file distributed with this work for additional information regarding
@@ -13,8 +15,6 @@
  * the License.
  */
 
-package org.apache.maven.lifecycle.internal;
-
 import junit.framework.TestCase;
 import org.apache.maven.execution.MavenSession;
 import org.apache.maven.lifecycle.internal.stub.LifecycleTaskSegmentCalculatorStub;

maven-core/src/test/java/org/apache/maven/lifecycle/internal/BuilderCommonTest.java

@@ -1,3 +1,5 @@
+package org.apache.maven.lifecycle.internal;
+
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
  * agreements. See the NOTICE file distributed with this work for additional information regarding
@@ -13,8 +15,6 @@
  * the License.
  */
 
-package org.apache.maven.lifecycle.internal;
-
 import junit.framework.TestCase;
 import org.apache.maven.artifact.Artifact;
 import org.apache.maven.execution.MavenSession;

maven-core/src/test/java/org/apache/maven/lifecycle/internal/ConcurrencyDependencyGraphTest.java

@@ -1,3 +1,5 @@
+package org.apache.maven.lifecycle.internal;
+
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
  * agreements. See the NOTICE file distributed with this work for additional information regarding
@@ -12,7 +14,6 @@
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
-package org.apache.maven.lifecycle.internal;
 
 import org.apache.maven.execution.MavenSession;
 import org.apache.maven.execution.ProjectDependencyGraph;

maven-core/src/test/java/org/apache/maven/lifecycle/internal/ExecutionPlanItemTest.java

@@ -1,3 +1,5 @@
+package org.apache.maven.lifecycle.internal;
+
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
  * agreements. See the NOTICE file distributed with this work for additional information regarding
@@ -12,7 +14,6 @@
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
-package org.apache.maven.lifecycle.internal;
 
 import junit.framework.TestCase;
 import org.apache.maven.lifecycle.Schedule;

maven-core/src/test/java/org/apache/maven/lifecycle/internal/LifecycleExecutionPlanCalculatorTest.java

@@ -1,3 +1,5 @@
+package org.apache.maven.lifecycle.internal;
+
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
  * agreements. See the NOTICE file distributed with this work for additional information regarding
@@ -13,10 +15,6 @@
  * the License.
  */
 
-package org.apache.maven.lifecycle.internal;
-
-import java.io.File;
-
 import org.apache.maven.AbstractCoreMavenComponentTestCase;
 import org.apache.maven.execution.MavenSession;
 import org.apache.maven.lifecycle.MavenExecutionPlan;

maven-core/src/test/java/org/apache/maven/lifecycle/internal/LifecycleWeaveBuilderTest.java

@@ -1,3 +1,5 @@
+package org.apache.maven.lifecycle.internal;
+
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
  * agreements. See the NOTICE file distributed with this work for additional information regarding
@@ -12,7 +14,6 @@
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
-package org.apache.maven.lifecycle.internal;
 
 import junit.framework.TestCase;
 import org.apache.maven.execution.DefaultMavenExecutionResult;
@@ -41,7 +42,7 @@
 import java.util.concurrent.Executors;
 
 /**
- * @author Kristian Rosenvold>
+ * @author Kristian Rosenvold
  */
 public class LifecycleWeaveBuilderTest
     extends TestCase

maven-core/src/test/java/org/apache/maven/lifecycle/internal/PhaseRecorderTest.java

@@ -1,4 +1,5 @@
 package org.apache.maven.lifecycle.internal;
+
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
  * agreements. See the NOTICE file distributed with this work for additional information regarding
@@ -13,6 +14,7 @@
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
+
 import junit.framework.TestCase;
 import org.apache.maven.lifecycle.MavenExecutionPlan;
 import org.apache.maven.lifecycle.internal.stub.LifecycleExecutionPlanCalculatorStub;

maven-core/src/test/java/org/apache/maven/lifecycle/internal/ProjectBuildListTest.java

@@ -1,3 +1,5 @@
+package org.apache.maven.lifecycle.internal;
+
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
  * agreements. See the NOTICE file distributed with this work for additional information regarding
@@ -12,7 +14,6 @@
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
-package org.apache.maven.lifecycle.internal;
 
 import junit.framework.TestCase;
 import org.apache.maven.execution.MavenSession;

maven-core/src/test/java/org/apache/maven/lifecycle/internal/ThreadOutputMuxerTest.java

@@ -1,3 +1,5 @@
+package org.apache.maven.lifecycle.internal;
+
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
  * agreements. See the NOTICE file distributed with this work for additional information regarding
@@ -12,7 +14,6 @@
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
-package org.apache.maven.lifecycle.internal;
 
 import junit.framework.TestCase;
 import org.apache.maven.execution.MavenSession;
@@ -94,7 +95,6 @@ public void testMultiThreaded()
             Arrays.asList( "Thinkin", "of", "a", "master", "plan", "Cuz", "ain’t", "nuthin", "but", "sweat", "inside",
                            "my", "hand" );
         Iterator<String> lyrics = stringList.iterator();
-        List<Outputter> outputters = new ArrayList<Outputter>();
 
         ExecutorService executor = Executors.newFixedThreadPool( 10 );
         CompletionService<ProjectSegment> service = new ExecutorCompletionService<ProjectSegment>( executor );

maven-core/src/test/java/org/apache/maven/project/TestMetadataSource.java

@@ -26,11 +26,10 @@
 import org.apache.maven.artifact.metadata.ArtifactMetadataSource;
 import org.apache.maven.artifact.metadata.ResolutionGroup;
 import org.apache.maven.artifact.repository.ArtifactRepository;
-import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
 import org.apache.maven.project.artifact.MavenMetadataSource;
 import org.codehaus.plexus.component.annotations.Component;
 
-@Component(role=ArtifactMetadataSource.class,hint="classpath")
+@Component( role = ArtifactMetadataSource.class, hint = "classpath" )
 public class TestMetadataSource
     extends MavenMetadataSource
 {

maven-core/src/test/java/org/apache/maven/project/canonical/CanonicalProjectBuilderTest.java

@@ -20,7 +20,6 @@
  */
 
 import java.io.File;
-import java.util.Iterator;
 import java.util.List;
 
 import org.apache.maven.model.Plugin;
@@ -52,17 +51,15 @@ public void testProjectBuilder()
         // Plugins
         // ----------------------------------------------------------------------
 
-        List plugins = project.getBuildPlugins();
+        List<Plugin> plugins = project.getBuildPlugins();
 
         // Plugin0 [plexus]
 
         String key = "org.apache.maven.plugins:maven-plexus-plugin";
 
         Plugin plugin = null;
-        for ( Iterator it = plugins.iterator(); it.hasNext(); )
+        for ( Plugin check : plugins )
         {
-            Plugin check = (Plugin) it.next();
-
             if ( key.equals( check.getKey() ) )
             {
                 plugin = check;
@@ -87,7 +84,7 @@ public void testProjectBuilder()
         // Goal specific configuration
         // ----------------------------------------------------------------------
 
-        List executions = plugin.getExecutions();
+        List<PluginExecution> executions = plugin.getExecutions();
 
         PluginExecution execution = (PluginExecution) executions.get( 0 );
 

maven-core/src/test/java/org/apache/maven/settings/SettingsUtilsTest.java

@@ -41,7 +41,7 @@ public void testShouldAppendRecessivePluginGroupIds()
 
         SettingsUtils.merge( dominant, recessive, Settings.GLOBAL_LEVEL );
 
-        List pluginGroups = dominant.getPluginGroups();
+        List<String> pluginGroups = dominant.getPluginGroups();
 
         assertNotNull( pluginGroups );
         assertEquals( 3, pluginGroups.size() );