From 6e3f24babc6290d9370a79a25c748e50ef7d8840 Mon Sep 17 00:00:00 2001 From: Jason van Zyl Date: Mon, 6 Jan 2014 12:16:06 -0500 Subject: [PATCH] Updated the notes about the order of processing and a small problem with the conflation of duplicate checkingin getProjectMap --- maven-core/src/main/java/org/apache/maven/DefaultMaven.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/maven-core/src/main/java/org/apache/maven/DefaultMaven.java b/maven-core/src/main/java/org/apache/maven/DefaultMaven.java index 152bd4b508..3fd3ef4fcd 100644 --- a/maven-core/src/main/java/org/apache/maven/DefaultMaven.java +++ b/maven-core/src/main/java/org/apache/maven/DefaultMaven.java @@ -183,12 +183,14 @@ public class DefaultMaven // // 5) Execute AbstractLifecycleParticipant.afterSessionStart(session) // - // 6) Get reactor projects looking for read errors, and duplicate declarations + // 6) Get reactor projects looking for general POM errors // // 7) Create ProjectDependencyGraph using trimming which takes into account --projects and reactor mode. This ensures // that the projects passed into the ReactorReader are only those specified. // - // 8) Create ReactorReader with the project map created in 7) + // 8) Create ReactorReader with the getProjectMap( projects ). NOTE that getProjectMap(projects) is the code that + // checks for duplicate projects definitions in the build. Ideally this type of duplicate checking should be part of + // getting the reactor projects in 6). The duplicate checking is conflated with getProjectMap(projects). // // 9) Execute AbstractLifecycleParticipant.afterProjectsRead(session) //