Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Proposal to change abstract provider 

Changes:
* validate input
* do not modify loop invariant within loop body
This commit is contained in:
Tamas Cservenak 2022-01-06 08:47:54 +01:00 committed by Hervé Boutemy
parent a53083db6c
commit 7180d68a18
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java
View File

@ -29,6 +29,8 @@ import org.apache.maven.lifecycle.mapping.Lifecycle;
import org.apache.maven.lifecycle.mapping.LifecycleMapping; import org.apache.maven.lifecycle.mapping.LifecycleMapping;
import org.apache.maven.lifecycle.mapping.LifecyclePhase; import org.apache.maven.lifecycle.mapping.LifecyclePhase;
import static java.util.Objects.requireNonNull;
/** /**
* Base lifecycle mapping provider, ie per-packaging plugin bindings for {@code default} lifecycle. * Base lifecycle mapping provider, ie per-packaging plugin bindings for {@code default} lifecycle.
*/ */
@ -39,11 +41,17 @@ public abstract class AbstractLifecycleMappingProvider
protected AbstractLifecycleMappingProvider( String[] pluginBindings ) protected AbstractLifecycleMappingProvider( String[] pluginBindings )
{ {
HashMap<String, LifecyclePhase> lifecyclePhases = new HashMap<>(); requireNonNull( pluginBindings );
int len = pluginBindings.length; final int len = pluginBindings.length;
for ( int i = 0; i < len; i++ ) if ( len < 1 || len % 2 != 0 )
{ {
lifecyclePhases.put( pluginBindings[i++], new LifecyclePhase( pluginBindings[i] ) ); throw new IllegalArgumentException( "Plugin bindings must have more than 0, even count of elements" );
}
HashMap<String, LifecyclePhase> lifecyclePhases = new HashMap<>( len / 2 );
for ( int i = 0; i < len; i = i + 2 )
{
lifecyclePhases.put( pluginBindings[i], new LifecyclePhase( pluginBindings[i + 1] ) );
} }
Lifecycle lifecycle = new Lifecycle(); Lifecycle lifecycle = new Lifecycle();