Apache
/
maven
mirror of https://github.com/apache/maven.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MNG-4312] Magic expressions injected by PluginParameterExpressionEvalutor conflict with expressions used by plugins to access system properties 

o Added IT

git-svn-id: https://svn.apache.org/repos/asf/maven/core-integration-testing/trunk@806280 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Benjamin Bentmann 2009-08-20 18:08:19 +00:00
parent 0adc235ad2
commit 7c10898703
3 changed files with 134 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
View File

@ -86,6 +86,7 @@ public class IntegrationTestSuite
// suite.addTestSuite( MavenIT0109ReleaseUpdateTest.class );
// suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137
suite.addTestSuite( MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest.class );
suite.addTestSuite( MavenITmng4305LocalRepoBasedirTest.class );
suite.addTestSuite( MavenITmng4304ProjectDependencyArtifactsTest.class );
suite.addTestSuite( MavenITmng4293RequiresCompilePlusRuntimeScopeTest.class );

66
its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest.java Normal file
View File

@ -0,0 +1,66 @@
package org.apache.maven.it;
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import org.apache.maven.it.Verifier;
import org.apache.maven.it.util.ResourceExtractor;
import java.io.File;
import java.util.Properties;
/**
* This is a test set for <a href="http://jira.codehaus.org/browse/MNG-4312">MNG-4312</a>.
*
* @author Benjamin Bentmann
*/
public class MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest
extends AbstractMavenIntegrationTestCase
{
public MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest()
{
super( "[3.0-alpha-3,)" );
}
/**
* Verify that plugins that use magic parameter expressions like ${plugin} for ordinary system properties
* get properly configured and don't crash due to Maven trying to inject a type-incompatible magic value
* into the String-type mojo parameter.
*/
public void testit()
throws Exception
{
File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4312" );
Verifier verifier = new Verifier( testDir.getAbsolutePath() );
verifier.setAutoclean( false );
verifier.deleteDirectory( "target" );
verifier.executeGoal( "validate" );
verifier.verifyErrorFreeLog();
verifier.resetStreams();
Properties props = verifier.loadProperties( "target/config.properties" );
assertEquals( "", props.getProperty( "stringParam", "" ) );
assertEquals( "", props.getProperty( "aliasParam", "" ) );
assertEquals( "maven-core-it", props.getProperty( "defaultParam" ) );
}
}

67
its/core-it-suite/src/test/resources/mng-4312/pom.xml Normal file
View File

@ -0,0 +1,67 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<project>
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.maven.its.mng4312</groupId>
<artifactId>test</artifactId>
<version>0.1</version>
<packaging>jar</packaging>
<name>Maven Integration Test :: MNG-4312</name>
<description>
Verify that plugins that use magic parameter expressions like ${plugin} for ordinary system properties
get properly configured and don't crash due to Maven trying to inject a type-incompatible magic value
into the String-type mojo parameter.
</description>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.its.plugins</groupId>
<artifactId>maven-it-plugin-configuration</artifactId>
<version>2.1-SNAPSHOT</version>
<configuration>
<propertiesFile>target/config.properties</propertiesFile>
<!-- all the expressions below intentionally conflict with magic expressions -->
<!--
Having the expressions in the POM is not usual but it uses the same code path as if the
expressions would be used in the @parameter annotation of the mojo
-->
<stringParam>${plugin}</stringParam>
<aliasParam>${localRepository}</aliasParam>
<defaultParam>${settings}</defaultParam>
</configuration>
<executions>
<execution>
<id>test</id>
<phase>validate</phase>
<goals>
<goal>config</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>