diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java index 9934d7aa77..3afce5cafb 100644 --- a/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java +++ b/its/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java @@ -86,6 +86,7 @@ public class IntegrationTestSuite // suite.addTestSuite( MavenIT0109ReleaseUpdateTest.class ); // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class ); -- MNG-3137 + suite.addTestSuite( MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest.class ); suite.addTestSuite( MavenITmng4305LocalRepoBasedirTest.class ); suite.addTestSuite( MavenITmng4304ProjectDependencyArtifactsTest.class ); suite.addTestSuite( MavenITmng4293RequiresCompilePlusRuntimeScopeTest.class ); diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest.java new file mode 100644 index 0000000000..9701bb77ce --- /dev/null +++ b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest.java @@ -0,0 +1,66 @@ +package org.apache.maven.it; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.it.Verifier; +import org.apache.maven.it.util.ResourceExtractor; + +import java.io.File; +import java.util.Properties; + +/** + * This is a test set for MNG-4312. + * + * @author Benjamin Bentmann + */ +public class MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest + extends AbstractMavenIntegrationTestCase +{ + + public MavenITmng4312TypeAwarePluginParameterExpressionInjectionTest() + { + super( "[3.0-alpha-3,)" ); + } + + /** + * Verify that plugins that use magic parameter expressions like ${plugin} for ordinary system properties + * get properly configured and don't crash due to Maven trying to inject a type-incompatible magic value + * into the String-type mojo parameter. + */ + public void testit() + throws Exception + { + File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-4312" ); + + Verifier verifier = new Verifier( testDir.getAbsolutePath() ); + verifier.setAutoclean( false ); + verifier.deleteDirectory( "target" ); + verifier.executeGoal( "validate" ); + verifier.verifyErrorFreeLog(); + verifier.resetStreams(); + + Properties props = verifier.loadProperties( "target/config.properties" ); + + assertEquals( "", props.getProperty( "stringParam", "" ) ); + assertEquals( "", props.getProperty( "aliasParam", "" ) ); + assertEquals( "maven-core-it", props.getProperty( "defaultParam" ) ); + } + +} diff --git a/its/core-it-suite/src/test/resources/mng-4312/pom.xml b/its/core-it-suite/src/test/resources/mng-4312/pom.xml new file mode 100644 index 0000000000..3bc016de7f --- /dev/null +++ b/its/core-it-suite/src/test/resources/mng-4312/pom.xml @@ -0,0 +1,67 @@ + + + + + + 4.0.0 + + org.apache.maven.its.mng4312 + test + 0.1 + jar + + Maven Integration Test :: MNG-4312 + + Verify that plugins that use magic parameter expressions like ${plugin} for ordinary system properties + get properly configured and don't crash due to Maven trying to inject a type-incompatible magic value + into the String-type mojo parameter. + + + + + + + org.apache.maven.its.plugins + maven-it-plugin-configuration + 2.1-SNAPSHOT + + target/config.properties + + + ${plugin} + ${localRepository} + ${settings} + + + + test + validate + + config + + + + + + +